Raised This Month: $51 Target: $400
 12% 

[INC] More Colors (1.9.1)


Post New Thread Reply   
 
Thread Tools Display Modes
Root_
Veteran Member
Join Date: Jan 2012
Location: ryssland
Old 01-08-2013 , 04:15   Re: [INC] More Colors (1.6.0)
Reply With Quote #131

Unfourdately {teamcolor} is still not working with DoD:S
I tested it in two ways: within a translation file (used) {teamcolor} and within a code like
Code:
decl String:teamcolor[32]; Format(teamcolor, sizeof(teamcolor), "{teamcolor}"); CPrintToChat(client, "%t", "a phrase", teamcolor, GetConVarInt(something));
with a format in a translation file like {1:s}
It's wont replace {teamcolor} at all from the message
__________________


dodsplugins.com - Plugins and Resources for Day of Defeat
http://twitch.tv/zadroot
Root_ is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 01-08-2013 , 08:58   Re: [INC] More Colors (1.6.0)
Reply With Quote #132

You need to use CPrintToChatEx for {teamcolor} to work.
__________________
Dr. McKay is offline
Root_
Veteran Member
Join Date: Jan 2012
Location: ryssland
Old 01-08-2013 , 18:13   Re: [INC] More Colors (1.6.0)
Reply With Quote #133

Still not working. {teamcolor} is stripped, but phrase wasnt colored (and there is no hex color code in client console as well)
__________________


dodsplugins.com - Plugins and Resources for Day of Defeat
http://twitch.tv/zadroot
Root_ is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 01-08-2013 , 18:20   Re: [INC] More Colors (1.6.0)
Reply With Quote #134

Quote:
Originally Posted by Root_ View Post
Still not working. {teamcolor} is stripped, but phrase wasnt colored (and there is no hex color code in client console as well)
It uses the same method as the original colors.inc. It should work.

I'm downloading DoD:S right now to try it out.

In the meantime, TF2 definitely works:


(excuse the JPEG, Steam apparently decided it's 90% reduction time)
__________________

Last edited by Dr. McKay; 01-08-2013 at 18:29.
Dr. McKay is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 01-08-2013 , 18:55   Re: [INC] More Colors (1.6.1)
Reply With Quote #135

Upon inspection, it appears that you are correct. The original colors.inc also had this issue.

I've committed 1.6.1, which just has the DoD:S colors hardcoded for {teamcolor}.
__________________
Dr. McKay is offline
koFF
Junior Member
Join Date: Dec 2012
Old 01-11-2013 , 14:20   Re: [INC] More Colors (1.6.1)
Reply With Quote #136

Dr. McKay, PMed you about bug.
koFF is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 01-11-2013 , 18:03   Re: [INC] More Colors (1.6.2)
Reply With Quote #137

1.6.2 has been committed. Increased MAX_MESSAGE_LENGTH to 256, fixed bug relating to chat printing in DoD:S, changed tag searching method to use RegEx.
__________________
Dr. McKay is offline
animalnots
Senior Member
Join Date: Dec 2012
Old 01-12-2013 , 02:37   Re: [INC] More Colors (1.6.2)
Reply With Quote #138

Why increased to 256?
I tried the max is 250 249, stable is 248, which is used in Adsql plugin.
Everything above 248-250 is cut off.
__________________
STEAM is the best of the west
Quote:
Never argue with an idiot. He lowers you to his level and then wins on experience!
animalnots is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 01-12-2013 , 11:39   Re: [INC] More Colors (1.6.2)
Reply With Quote #139

Quote:
Originally Posted by animalnots View Post
Why increased to 256?
I tried the max is 250 249, stable is 248, which is used in Adsql plugin.
Everything above 248-250 is cut off.
It's 256 in Simple Chat Processor, I'm going with that.
__________________
Dr. McKay is offline
asherkin
SourceMod Developer
Join Date: Aug 2009
Location: OnGameFrame()
Old 01-12-2013 , 14:03   Re: [INC] More Colors (1.6.2)
Reply With Quote #140

Quote:
Originally Posted by Dr. McKay View Post
It's 256 in Simple Chat Processor, I'm going with that.
The network limit is 255, and 2 bytes are used for the data that isn't the string itself.

Also, while I don't have the pre-regex one for comparison, regex is generally not a good tool for applications like like - lexing the string per-character would probably give the best results.
__________________
asherkin is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 07:38.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode