[loranger]

anyone got it working with tf2?

It says in console: unknown command sm_binoculars

[Calystos]

I managed to get some workarounds sorta working in TF2 & ND, but haven't had the time to fully work at it yet.

I say sort of working, it spams chat with errors if you try to fire when using the binoculars. But it DOES work other than that. Least, it did when I was testing it on ND. And since TF2 has the same issue it should work on TF2 too. Since both appear to be missing the same functions that this plugin by default was using.

Will look further into it when I get more time.

[RedSword]

Hi there,

I can't approve this for the following reason :

• You're putting your plugin as [ANY], but you're hooking weapon_zoom, which doesn't exist in all mods, which generates errors on mods such as DODS. Either hook it in predefined mods (checking game folders) or try creating such an event and check if != INVALID_HANDLE to hook it.

Also, your code could get some change (note those are recommendations) :

• Use tabs or spaces, not both.
• Rather than hardcoding default FOV to 90, take the one that the client has before zooming/using binoculars. TF2 allows the user to choose its own FOV, which mess up your "Prismaticos" code (i.e. default 75 --> 90 = ...)
• Remove FCVAR_REPLICATED from version ConVar.
• Add minimum FOV ConVar value.

Red

[Franc1sco]

Originally Posted by RedSword Hi there, I can't approve this for the following reason : You're putting your plugin as [ANY], but you're hooking weapon_zoom, which doesn't exist in all mods, which generates errors on mods such as DODS. Either hook it in predefined mods (checking game folders) or try creating such an event and check if != INVALID_HANDLE to hook it. Also, your code could get some change (note those are recommendations) : Use tabs or spaces, not both. Rather than hardcoding default FOV to 90, take the one that the client has before zooming/using binoculars. TF2 allows the user to choose its own FOV, which mess up your "Prismaticos" code (i.e. default 75 --> 90 = ...) Remove FCVAR_REPLICATED from version ConVar. Add minimum FOV ConVar value. Red

ok I will look it

[DarthNinja]

Originally Posted by RedSword Either hook it in predefined mods (checking game folders) or try creating such an event and check if != INVALID_HANDLE to hook it.

HookEventEx exists for a reason.

[RedSword]

Originally Posted by DarthNinja HookEventEx exists for a reason.

:$

That too :$.

[Franc1sco]

Originally Posted by RedSword Hi there, I can't approve this for the following reason : You're putting your plugin as [ANY], but you're hooking weapon_zoom, which doesn't exist in all mods, which generates errors on mods such as DODS. Either hook it in predefined mods (checking game folders) or try creating such an event and check if != INVALID_HANDLE to hook it. Also, your code could get some change (note those are recommendations) : Use tabs or spaces, not both. Rather than hardcoding default FOV to 90, take the one that the client has before zooming/using binoculars. TF2 allows the user to choose its own FOV, which mess up your "Prismaticos" code (i.e. default 75 --> 90 = ...) Remove FCVAR_REPLICATED from version ConVar. Add minimum FOV ConVar value. Red

Ok I think that already everything is done.


New version v3.0

-bugfixeds y optimized for approval

[Groger]

Cheers, using it as a donate benefit. Nice little extra for our donators

Thx again

[RedSword]

Something I overlooked; you should check that the client that uses sm_binoculars isn't 0; it causes an error when called in server console.

Also why keep both plugins in first post ?

[Franc1sco]

Originally Posted by RedSword Something I overlooked; you should check that the client that uses sm_binoculars isn't 0; it causes an error when called in server console. Also why keep both plugins in first post ?

Fixed