[elitetaco]

Great Job Drekes! This is very Fun to have in servers

[fysiks]

I'm confused. Why would you do this:

PHP Code:

    switch(szSound[strlen(szSound) - 1])
    {
        case 'v', 'V':
            client_cmd(iVictim, "spk ^"sound/%s^"", szSound);
            
        case '3':
            client_cmd(iVictim, "mp3 play ^"%s^"", szSound);
    } 


and

; sound/misc/example.mp3^n^n; Be sure to write sound/ when the file is a .mp3^n

Why not just add the "sound/" in the mp3 situation just like you do in the wave situation? Then, you don't need to worry about putting wavs and mp3s in the .ini file differently.

EDIT: Just realized it was because of the precache_generic() BUT you could just add "sound/" when precaching mp3s. This would make it more "user friendly".

[drekes]

Originally Posted by fysiks EDIT: Just realized it was because of the precache_generic() BUT you could just add "sound/" when precaching mp3s. This would make it more "user friendly".

will do.

EDIT: Done

[ConnorMcLeod]

You musn't (don't have to ? w/e) pass 'sound/' in wav play cmd.

[Arkshine]

You should not register the event if no sounds were found from the parsing.

Also, I would suggest to format directly the sound with spk or mp3 play at parsing time before saving in the array, so you can use directly something like that :

public EventDeathMsg()
{
    client_cmd( read_data( 2 ), "%a", ArrayGetStringHandle( g_aSounds, g_iTotalSounds == 1 ? 0 : random( g_iTotalSounds ) ) );
}

[drekes]

Originally Posted by ConnorMcLeod You musn't (don't have to ? w/e) pass 'sound/' in wav play cmd.

I've tried with and without /sound for .wav files, and it seems to work with both, so what is the difference ?

Originally Posted by Arkshine You should not register the event if no sounds were found from the parsing. Also, I would suggest to format directly the sound with spk or mp3 play at parsing time before saving in the array, so you can use directly something like that : Code: public EventDeathMsg() { client_cmd( read_data( 2 ), "%a", ArrayGetStringHandle( g_aSounds, g_iTotalSounds == 1 ? 0 : random( g_iTotalSounds ) ) ); }

I'll update it once i have received an answer from Connor for the question above.

[GuTo]

cool man

[dark_style]

Also you should use formatex where applicable.

[drekes]

Originally Posted by dark_style Also you should use formatex where applicable.

I know but it isn't applicable in this code.
This is the only format() i use:

PHP Code:

format(szData, charsmax(szData), "sound/%s", szData); 


As you can see, i use szData[] as output, but also use szData as the 4th param, which isn't possible with formatex()

[dark_style]

Sorry, my fault. The idea of the plugin is good, but you should add more features.