motd prints all playing players in rows - Page 3

eat1k · 02-06-2019 , 16:08 Re: motd prints all playing players in rows

Quote:

Originally Posted by iceeedr

I am almost sure that it is only necessary to check first, since by obvious if you have not defined max_players we can already establish that it is not amxx > 1.8.2

PHP Code:


			
#if !defined MAX_PLAYERS

    #define MAX_PLAYERS 32

    #define MAX_NAME_LENGTH 32

    #define MAX_MOTD_LENGTH 1536

#endif

Or, check directly the version of amxx

PHP Code:


			
#if AMXX_VERSION_NUM < 190

    #define MAX_PLAYERS 32

    #define MAX_NAME_LENGTH 32

    #define MAX_MOTD_LENGTH 1536

#endif

It's easier as I said. Using the method you gave will throw errors depending on the build of AMXX. MAX_PLAYERS was introduced in AMXX 1.8.3, not AMXX 1.8.2. So it's not right to use it like that.

TheBladerX · *Last edited by TheBladerX; 02-06-2019 at 16:09.*

Quote:

Originally Posted by shauli

This one has many problems. It's probably works fine when you test it alone but no way it will work when your server is full. It doesn't check all players.

You should use the one eat1k posted. Try this in 1.8.2:

PHP Code:


			
#include <amxmodx>
#include <amxmisc>

#define MAX_MOTD_LENGTH 1536
#define MAX_PLAYERS 32
#define MAX_NAME_LENGTH 32

public plugin_init()
{
    register_clcmd("say /hraci", "player_skills");
}

public player_skills(id)
{
    new szMessage[MAX_MOTD_LENGTH], iLen;
    
    iLen = formatex(szMessage, charsmax(szMessage), "<HTML><head></head><body bgcolor=#000000><font color=#FFB000>");
    
    new iPlayers[MAX_PLAYERS], iPlayerCount, szName[MAX_NAME_LENGTH];
    get_players(iPlayers, iPlayerCount, "ch");
    
    for(new i; i < iPlayerCount; i++)
    {
        get_user_name(iPlayers[i], szName, charsmax(szName));
        iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%s<br>", szName);
    }
    
    show_motd(id, szMessage, "Info players");
    return PLUGIN_HANDLED;
}

Okay, I have a problem with this one too. It seems like "i" goes from -1, which is impossible. Every time I try to add player_class[i] as another string, it shows player's class, which is after this person, if I try [i+1], it does not show the last one. When I try [i], it does not show the first one. I don't get it. Even if I try to add [j] as new, it does not show correctly. And also I use bots to test it. I do not know, if that can cause the problem.

eat1k · 02-06-2019 , 16:16 Re: motd prints all playing players in rows

Quote:

Originally Posted by TheBladerX

Okay, I have a problem with this one too. It seems like "i" goes from -1, which is impossible. Every time I try to add player_class[i] as another string, it shows player's class, which is after this person, if I try [i+1], it does not show the last one. When I try [i], it does not show the first one. I don't get it. Even if I try to add [j] as new, it does not show correctly. And also I use bots to test it. I do not know, if that can cause the problem.

Show the code you're trying to use.

TheBladerX · *Last edited by TheBladerX; 02-06-2019 at 16:23.*

Quote:

Originally Posted by eat1k

Show the code you're trying to use.

PHP Code:


			
public player_skills(id) 
{ 
    new szMessage[MAX_MOTD_LENGTH], iLen; 
     
    iLen = formatex(szMessage, charsmax(szMessage), "<HTML><head></head><body bgcolor=#000000><font color=#FFB000>");     
     
    new iPlayers[MAX_PLAYER], iPlayerCount, szName[MAX_NAME_LENGTH]; 
    get_players(iPlayers, iPlayerCount, "hi"); 
     
    for(new i; i < iPlayerCount; i++) 
    { 
    get_user_name(iPlayers[i], szName, charsmax(szName)); 
    iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%s - %s (%i)<br>", szName, class_name[player_class[i]], player_level[i]);
    }
    
     
    show_motd(id, szMessage, "Triedy hracov"); 
    return PLUGIN_HANDLED; 
}

if I add player_name[i] as string to display in motd, which I mainly use for names in this plugin, it shows one person after szName.

iceeedr · 02-06-2019 , 16:23 Re: motd prints all playing players in rows

Quote:

Originally Posted by eat1k

It's easier as I said. Using the method you gave will throw errors depending on the build of AMXX. MAX_PLAYERS was introduced in AMXX 1.8.3, not AMXX 1.8.2. So it's not right to use it like that.

I'd rather assume that people use the last build thrown ... but looking at it all, I give you reason.

iceeedr · 02-06-2019 , 16:25 Re: motd prints all playing players in rows

Quote:

Originally Posted by TheBladerX

PHP Code:


			
public player_skills(id) 

{ 

    new szMessage[MAX_MOTD_LENGTH], iLen; 

     

    iLen = formatex(szMessage, charsmax(szMessage), "<HTML><head></head><body bgcolor=#000000><font color=#FFB000>");     

     

    new iPlayers[MAX_PLAYER], iPlayerCount, szName[MAX_NAME_LENGTH]; 

    get_players(iPlayers, iPlayerCount, "hi"); 

     

    for(new i; i < iPlayerCount; i++) 

    { 

    get_user_name(iPlayers[i], szName, charsmax(szName)); 

    iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%s - %s (%i)<br>", szName, class_name[player_class[i]], player_level[i]);

    }

    

     

    show_motd(id, szMessage, "Triedy hracov"); 

    return PLUGIN_HANDLED; 

}

if I add player_name[i] as string to display in motd, which I mainly use for names in this plugin, it shows one person after szName.

Give a shot

PHP Code:


			
iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%s - %s (%i)<br>", szName, class_name[player_class[iPlayers[i]]], player_level[iPlayers[i]])

TheBladerX · 02-06-2019 , 16:29 Re: motd prints all playing players in rows

Quote:

Originally Posted by iceeedr

Give a shot

PHP Code:


			
iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%s - %s (%i)<br>", szName, class_name[player_class[iPlayers[i]]], player_level[iPlayers[i]])

That was the issue all the time ffs

Thank you all. Solved.

eat1k · 02-06-2019 , 16:33 Re: motd prints all playing players in rows

Change the for() to:

PHP Code:


			
for(new i, iPlayer; i < iPlayerCount; i++)  
{
    iPlayer = iPlayers[i];

    get_user_name(iPlayer, szName, charsmax(szName));  
    iLen += formatex(szMessage[iLen], charsmax(szMessage) - iLen, "%s - %s (%i)<br>", szName, class_name[player_class[iPlayer]], player_level[iPlayer]);
}