[C1PA]

Does this work for counter strike to?
If not, can someone change it so it will?

[pizzahut]

I had v4.2 with the engclient_cmd and some minor changes lying around on my HDD since October last year. I guess I didn't publish it because I wasn't satisfied with it, probably to do with FoxBot behaving a bit random and maybe latency issues (things working fine on listen but not on a dedicated due to different reaction times). So here it is (added to the 1st post).

From comparing the source code, changes I did:

- Added handling of changeteam command - it uses the same function as jointeam.
- The function used by above commands was renamed from "clcmd_jointeam" to "force_human_team" because it's not used by jointeam exclusively any more.
- With the engclient_cmd testing whether the human player wants to join the right team isn't needed any more, since the "jointeam" command isn't sent to the player. Saves parsing of the team argument (read_argv) as well.
- Added some additional checks of bvh_enabled so tasks won't even be started. There already was/is another check in the task itself though.

[HamletEagle]

Some thoughts:

• static is misused in client commands(also in task_adjust_bot_count), you should initialize them with "new".
• Instead of this:

  get_players(Players, playerCount, "c")  // skip bots, don't skip the HLTV
      for(i = 0; i < playerCount; i++)
      {
          teamnumber = get_user_team(Players[i])
          if((1 <= teamnumber) && (teamnumber <= 4))
              HumanCount++
          else
              SpecCount++
      }

  You could do something like:
  

  new TeroCount, CtCound
  get_players(Players, TeroCount, "ce", "TERRORIST")
  get_players(Players, CtCount, "ce", "CT")
  get_players(Players, SpecCount, "ce", "SPECTATOR")
  HumanCount = TeroCount + CtCound

  Anyway, it's also ok to loop and count.
• Be consistent with your style. For example, in some places you use camelcase and in some you don't. Just choose one style and use it everywhere.
• Instead of format, use formatex, it's faster.
• In task_check_bot_team cache g_bvh_bot_team cvar value before looping.

Also, because I don't know much about TFC I am just asking.
I see from the wiki that TeamInfo message is present also in TFC, so maybe you could use it instead of creating a permanent looping task. My point is, all team changes are send with this message, so you could hook it and do your checks and fix bot team.

Unapproved until you make changes, because section needs to be cleaned. PM me and I'll check again.

[pizzahut]

Originally Posted by HamletEagle static is misused in client commands(also in task_adjust_bot_count), you should initialize them with "new".

I use static for speed. As I understand it, "new" creates a variable every time the function is called, and the variable is destroyed every time the function ends. With static, the variable is kept in memory, but has to be initialised manually if necessary.

Originally Posted by HamletEagle Instead of this: get_players(Players, playerCount, "c")  // skip bots, don't skip the HLTV     for(i = 0; i < playerCount; i++)     {         teamnumber = get_user_team(Players[i])         if((1 <= teamnumber) && (teamnumber <= 4))             HumanCount++         else             SpecCount++     } You could do something like: new TeroCount, CtCound get_players(Players, TeroCount, "ce", "TERRORIST") get_players(Players, CtCount, "ce", "CT") get_players(Players, SpecCount, "ce", "SPECTATOR") HumanCount = TeroCount + CtCound Anyway, it's also ok to loop and count.

Team names in TFC aren't fixed like in CS. Each map can have custom names.

Even if they were fixed, the effort in terms of performance to compare against a string instead of a numeric variable is probably higher.

Originally Posted by HamletEagle Be consistent with your style. For example, in some places you use camelcase and in some you don't. Just choose one style and use it everywhere. Instead of format, use formatex, it's faster. In task_check_bot_team cache g_bvh_bot_team cvar value before looping.

I agree with this, thank you for your input and time looking into new plugin releases - much appreciated.

Originally Posted by HamletEagle I see from the wiki that TeamInfo message is present also in TFC, so maybe you could use it instead of creating a permanent looping task. My point is, all team changes are send with this message, so you could hook it and do your checks and fix bot team.

There's no permanent looping task, but yes it's better to use a TeamInfo message (game event) instead of a log event.

[HamletEagle]

Originally Posted by pizzahut I use static for speed. As I understand it, "new" creates a variable every time the function is called, and the variable is destroyed every time the function ends. With static, the variable is kept in memory, but has to be initialised manually if necessary.

That's correct, but it only matters when you are working in "heavy" forwards(I mean forwards called per frame - PreThink, AddToFullPack, CmdStart, etc) or on big arrays. Here it's not the case, so I would prefer you to use "new", it makes more sense.

Originally Posted by pizzahut Team names in TFC aren't fixed like in CS. Each map can have custom names. Even if they were fixed, the effort in terms of performance to compare against a string instead of a numeric variable is probably higher.

Like I said before, it's okay to count, was just showing another way, most of people don't know that get_players can filter by team.

Originally Posted by pizzahut There's no permanent looping task, but yes it's better to use a TeamInfo message (game event) instead of a log event.

My bad about the task. Anyway, I would still go for TeamInfo message.

If you decide to make the changes, PM me when you are ready so I can approve this.

[tarantula2]

Does anyone know why my bots randomly try to switch to the red team? Then they immediately switch back to blue.

foxbot are settings correct:

max_bots -1
min_bots -1
Bot chat 500
Bot auto team balance Off
Bot per team balance Off

I also have:
tfc_autoteam 0
tfc_balance_teams 0

Also, do I need to have 41.amxx and 42.amxx loaded?
Or just one of them? Currently only have 41 loaded. Also tried swapping them with same issue.

Thanks in advance,
tarantula

[pizzahut]

The bots don't keep assigned teams, they can switch when they die AFAIK.

Maybe -X- (server admin) or RoboCop (FoxBot maintainer) have an idea how to prevent this from happening.

https://steamcommunity.com/profiles/76561198213218781/
https://steamcommunity.com/id/SCO_RoboCop/

I'm not sure why I kept v4.1 in this thread. There might have been a reason, so I'll leave it be.

I made a customised version for -X- which doesn't adjust bot count / ratio. I think it also fixes a minor issue present in v4.1 and v4.2 - the scoreboard might not get updated when using the "jointeam" command on a bot.

https://rv.apg-clan.org/dlds/amxx_pl..._humans_x2.sma