[wicho]

Hi everybody, well i use the mod of zombie plague and this mod use a plugin to send teamscore when a team won and when no one won (round draw) using register_message(get_user_msgid("TeamScore"), but the problem is this only change on scoreboard not the internal value so i try to use orpheu using Arkshine code but i dont know much about this module, i try this but dont work correctly i mean on the teamscore said ct 3 and 2 terrorist all the time and dont change when a team won i mean permanently, i dont want to change the normal score, i mean when the team won a round give the normal score, i only want to give the point to ct when no one won(round draw) on scoreboard and internally, can someone tell me how i can fix it?

PHP Code:

/*================================================================================
    
    -------------------------
    -*- [ZP] Team Scoring -*-
    -------------------------
    
    This plugin is part of Zombie Plague Mod and is distributed under the
    terms of the GNU General Public License. Check ZP_ReadMe.txt for details.
    
================================================================================*/

#include <amxmodx>
#include <amx_settings_api>
#include <zp50_gamemodes>
#include <orpheu>
#include <orpheu_memory>

// Settings file
new const ZP_SETTINGS_FILE[] = "zombieplague.ini"

// Default sounds
new const sound_win_zombies[][] = { "ambience/the_horror1.wav" , "ambience/the_horror3.wav" , "ambience/the_horror4.wav" }
new const sound_win_humans[][] = { "zombie_plague/win_humans1.wav" , "zombie_plague/win_humans2.wav" }
new const sound_win_no_one[][] = { "ambience/3dmstart.wav" }

// HUD messages
#define HUD_EVENT_X -1.0
#define HUD_EVENT_Y 0.12

#define SOUND_MAX_LENGTH 64

// Custom sounds
new Array:g_sound_win_zombies
new Array:g_sound_win_humans
new Array:g_sound_win_no_one

new g_ScoreHumans, g_ScoreZombies
new g_HudSync

new cvar_winner_show_hud, cvar_winner_sounds

new g_pGameRules;

#define set_mp_pdata(%1,%2)  ( OrpheuMemorySetAtAddress( g_pGameRules, %1, 1, %2 ) )
#define get_mp_pdata(%1)     ( OrpheuMemoryGetAtAddress( g_pGameRules, %1 ) )

public OnInstallGameRules()
{
    g_pGameRules = OrpheuGetReturn();
}

public plugin_init()
{
    register_plugin("[ZP] Team Scoring", ZP_VERSION_STRING, "ZP Dev Team")
    
    // Create the HUD Sync Objects
    g_HudSync = CreateHudSyncObj()
    
    register_message(get_user_msgid("TextMsg"), "message_textmsg")
    register_message(get_user_msgid("SendAudio"), "message_sendaudio")
    register_message(get_user_msgid("TeamScore"), "message_teamscore")  
    
    cvar_winner_show_hud = register_cvar("zp_winner_show_hud", "1")
    cvar_winner_sounds = register_cvar("zp_winner_sounds", "1")
}

public plugin_precache()
{
    // Initialize arrays
    g_sound_win_zombies = ArrayCreate(SOUND_MAX_LENGTH, 1)
    g_sound_win_humans = ArrayCreate(SOUND_MAX_LENGTH, 1)
    g_sound_win_no_one = ArrayCreate(SOUND_MAX_LENGTH, 1)
    
    // Load from external file
    amx_load_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN ZOMBIES", g_sound_win_zombies)
    amx_load_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN HUMANS", g_sound_win_humans)
    amx_load_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN NO ONE", g_sound_win_no_one)
    
    // If we couldn't load custom sounds from file, use and save default ones
    new index
    if (ArraySize(g_sound_win_zombies) == 0)
    {
        for (index = 0; index < sizeof sound_win_zombies; index++)
            ArrayPushString(g_sound_win_zombies, sound_win_zombies[index])
        
        // Save to external file
        amx_save_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN ZOMBIES", g_sound_win_zombies)
    }
    if (ArraySize(g_sound_win_humans) == 0)
    {
        for (index = 0; index < sizeof sound_win_humans; index++)
            ArrayPushString(g_sound_win_humans, sound_win_humans[index])
        
        // Save to external file
        amx_save_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN HUMANS", g_sound_win_humans)
    }
    if (ArraySize(g_sound_win_no_one) == 0)
    {
        for (index = 0; index < sizeof sound_win_no_one; index++)
            ArrayPushString(g_sound_win_no_one, sound_win_no_one[index])
        
        // Save to external file
        amx_save_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN NO ONE", g_sound_win_no_one)
    }
    
    // Precache sounds
    new sound[SOUND_MAX_LENGTH]
    for (index = 0; index < ArraySize(g_sound_win_zombies); index++)
    {
        ArrayGetString(g_sound_win_zombies, index, sound, charsmax(sound))
        if (equal(sound[strlen(sound)-4], ".mp3"))
        {
            format(sound, charsmax(sound), "sound/%s", sound)
            precache_generic(sound)
        }
        else
            precache_sound(sound)
    }
    for (index = 0; index < ArraySize(g_sound_win_humans); index++)
    {
        ArrayGetString(g_sound_win_humans, index, sound, charsmax(sound))
        if (equal(sound[strlen(sound)-4], ".mp3"))
        {
            format(sound, charsmax(sound), "sound/%s", sound)
            precache_generic(sound)
        }
        else
            precache_sound(sound)
    }
    for (index = 0; index < ArraySize(g_sound_win_no_one); index++)
    {
        ArrayGetString(g_sound_win_no_one, index, sound, charsmax(sound))
        if (equal(sound[strlen(sound)-4], ".mp3"))
        {
            format(sound, charsmax(sound), "sound/%s", sound)
            precache_generic(sound)
        }
        else
            precache_sound(sound)
    }
    
    OrpheuRegisterHook( OrpheuGetFunction( "InstallGameRules" ), "OnInstallGameRules", OrpheuHookPost );
}

public zp_fw_gamemodes_end()
{
    // Determine round winner, show HUD notice
    new sound[SOUND_MAX_LENGTH]
    if (!zp_core_get_zombie_count())
    {
        // Human team wins
        if (get_pcvar_num(cvar_winner_show_hud))
        {
            set_hudmessage(0, 0, 200, HUD_EVENT_X, HUD_EVENT_Y, 0, 0.0, 3.0, 2.0, 1.0, -1)
            ShowSyncHudMsg(0, g_HudSync, "%L", LANG_PLAYER, "WIN_HUMAN")
        }
        
        if (get_pcvar_num(cvar_winner_sounds))
        {
            ArrayGetString(g_sound_win_humans, random_num(0, ArraySize(g_sound_win_humans) - 1), sound, charsmax(sound))
            PlaySoundToClients(sound, 1)
        }
        
        g_ScoreHumans++
    }
    else if (!zp_core_get_human_count())
    {
        // Zombie team wins
        if (get_pcvar_num(cvar_winner_show_hud))
        {
            set_hudmessage(200, 0, 0, HUD_EVENT_X, HUD_EVENT_Y, 0, 0.0, 3.0, 2.0, 1.0, -1)
            ShowSyncHudMsg(0, g_HudSync, "%L", LANG_PLAYER, "WIN_ZOMBIE")
        }
        
        if (get_pcvar_num(cvar_winner_sounds))
        {
            ArrayGetString(g_sound_win_zombies, random_num(0, ArraySize(g_sound_win_zombies) - 1), sound, charsmax(sound))
            PlaySoundToClients(sound, 1)
        }
        
        g_ScoreZombies++
    }
    else
    {
        // No one wins
        if (get_pcvar_num(cvar_winner_show_hud))
        {
            set_hudmessage(0, 0, 200, HUD_EVENT_X, HUD_EVENT_Y, 0, 0.0, 3.0, 2.0, 1.0, -1)
            ShowSyncHudMsg(0, g_HudSync, "%L", LANG_PLAYER, "WIN_NO_ONE")
        }
        
        if (get_pcvar_num(cvar_winner_sounds))
        {
            ArrayGetString(g_sound_win_humans, random_num(0, ArraySize(g_sound_win_humans) - 1), sound, charsmax(sound))
            PlaySoundToClients(sound, 1)
        }
        
        g_ScoreHumans++
    }
}

// Block some text messages
public message_textmsg()
{
    new textmsg[22]
    get_msg_arg_string(2, textmsg, charsmax(textmsg))
    
    // Game restarting/game commencing, reset scores
    if (equal(textmsg, "#Game_will_restart_in") || equal(textmsg, "#Game_Commencing"))
    {
        g_ScoreHumans = 0
        g_ScoreZombies = 0
    }
    // Block round end related messages
    else if (equal(textmsg, "#Hostages_Not_Rescued") || equal(textmsg, "#Round_Draw") || equal(textmsg, "#Terrorists_Win") || equal(textmsg, "#CTs_Win"))
        return PLUGIN_HANDLED;
    
    return PLUGIN_CONTINUE;
}

// Block CS round win audio messages, since we're playing our own instead
public message_sendaudio()
{
    new audio[17]
    get_msg_arg_string(2, audio, charsmax(audio))
    
    if(equal(audio[7], "terwin") || equal(audio[7], "ctwin") || equal(audio[7], "rounddraw"))
        return PLUGIN_HANDLED;
    
    return PLUGIN_CONTINUE;
}

// Send actual team scores (T = zombies // CT = humans)
public message_teamscore()
{
        new team[2]    
        read_argv( 1, team , charsmax( team ) );
              
        switch ( team[ 0 ] )
        {
            case 'C': 
            {
                set_mp_pdata( "m_iNumCTWins", g_ScoreHumans );
            }
            case 'T': 
            {
                set_mp_pdata( "m_iNumTerroristWins", g_ScoreZombies );
            }         
            default :
            {
                return PLUGIN_HANDLED;
            }
        }
        
        UpdateTeamScores( .notifyAllPlugins = true );
        
    return PLUGIN_HANDLED;
}  

UpdateTeamScores ( const bool:notifyAllPlugins = false )
{
        static OrpheuFunction:handleFuncUpdateTeamScores;

        if ( !handleFuncUpdateTeamScores )
        {
            handleFuncUpdateTeamScores = OrpheuGetFunction( "UpdateTeamScores", "CHalfLifeMultiplay" )
        }

        ( notifyAllPlugins ) ?

            OrpheuCallSuper( handleFuncUpdateTeamScores, g_pGameRules ) :
            OrpheuCall( handleFuncUpdateTeamScores, g_pGameRules );
} 
    
// Plays a sound on clients
PlaySoundToClients(const sound[], stop_sounds_first = 0)
{
    if (stop_sounds_first)
    {
        if (equal(sound[strlen(sound)-4], ".mp3"))
            client_cmd(0, "stopsound; mp3 play ^"sound/%s^"", sound)
        else
            client_cmd(0, "mp3 stop; stopsound; spk ^"%s^"", sound)
    }
    else
    {
        if (equal(sound[strlen(sound)-4], ".mp3"))
            client_cmd(0, "mp3 play ^"sound/%s^"", sound)
        else
            client_cmd(0, "spk ^"%s^"", sound)
    }
} 


[NikKOo31]

I used this and works Set and Get TeamScore with Orpheu

P.S: In your code you are using a native from zp

PHP Code:

zp_fw_gamemodes_end 


You can keep using this, or you can register round_end and get the team score there

[wicho]

thx, u mean on this way?

PHP Code:

/*================================================================================
    
    -------------------------
    -*- [ZP] Team Scoring -*-
    -------------------------
    
    This plugin is part of Zombie Plague Mod and is distributed under the
    terms of the GNU General Public License. Check ZP_ReadMe.txt for details.
    
================================================================================*/

#include <amxmodx>
#include <amx_settings_api>
#include <zp50_gamemodes>
#include <orpheu>
#include <orpheu_memory>

// Settings file
new const ZP_SETTINGS_FILE[] = "zombieplague.ini"

// Default sounds
new const sound_win_zombies[][] = { "ambience/the_horror1.wav" , "ambience/the_horror3.wav" , "ambience/the_horror4.wav" }
new const sound_win_humans[][] = { "zombie_plague/win_humans1.wav" , "zombie_plague/win_humans2.wav" }
new const sound_win_no_one[][] = { "ambience/3dmstart.wav" }

// HUD messages
#define HUD_EVENT_X -1.0
#define HUD_EVENT_Y 0.12

#define SOUND_MAX_LENGTH 64

// Custom sounds
new Array:g_sound_win_zombies
new Array:g_sound_win_humans
new Array:g_sound_win_no_one

new g_ScoreHumans, g_ScoreZombies
new g_HudSync

new cvar_winner_show_hud, cvar_winner_sounds

new g_pGameRules;

new OrpheuFunction:_UpdateTeamScores;

#define SetTeamScore(%0,%1) OrpheuMemorySetAtAddress( g_pGameRules, g_szMemoryOfs[ %0 ], 1, %1 )
#define GetTeamScore(%0)    OrpheuMemoryGetAtAddress( g_pGameRules, g_szMemoryOfs[ %0 ] )

new const g_szMemoryOfs[][] = 
{
    "", 
    "m_iNumTerroristWins",
    "m_iNumCTWins"
}

public plugin_init()
{
    register_plugin("[ZP] Team Scoring", ZP_VERSION_STRING, "ZP Dev Team")
    
    // Create the HUD Sync Objects
    g_HudSync = CreateHudSyncObj()
    
    register_message(get_user_msgid("TextMsg"), "message_textmsg")
    register_message(get_user_msgid("SendAudio"), "message_sendaudio")
    register_message(get_user_msgid("TeamScore"), "message_teamscore")  
    
    cvar_winner_show_hud = register_cvar("zp_winner_show_hud", "1")
    cvar_winner_sounds = register_cvar("zp_winner_sounds", "1")
}

public plugin_precache()
{
    // Initialize arrays
    g_sound_win_zombies = ArrayCreate(SOUND_MAX_LENGTH, 1)
    g_sound_win_humans = ArrayCreate(SOUND_MAX_LENGTH, 1)
    g_sound_win_no_one = ArrayCreate(SOUND_MAX_LENGTH, 1)
    
    // Load from external file
    amx_load_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN ZOMBIES", g_sound_win_zombies)
    amx_load_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN HUMANS", g_sound_win_humans)
    amx_load_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN NO ONE", g_sound_win_no_one)
    
    // If we couldn't load custom sounds from file, use and save default ones
    new index
    if (ArraySize(g_sound_win_zombies) == 0)
    {
        for (index = 0; index < sizeof sound_win_zombies; index++)
            ArrayPushString(g_sound_win_zombies, sound_win_zombies[index])
        
        // Save to external file
        amx_save_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN ZOMBIES", g_sound_win_zombies)
    }
    if (ArraySize(g_sound_win_humans) == 0)
    {
        for (index = 0; index < sizeof sound_win_humans; index++)
            ArrayPushString(g_sound_win_humans, sound_win_humans[index])
        
        // Save to external file
        amx_save_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN HUMANS", g_sound_win_humans)
    }
    if (ArraySize(g_sound_win_no_one) == 0)
    {
        for (index = 0; index < sizeof sound_win_no_one; index++)
            ArrayPushString(g_sound_win_no_one, sound_win_no_one[index])
        
        // Save to external file
        amx_save_setting_string_arr(ZP_SETTINGS_FILE, "Sounds", "WIN NO ONE", g_sound_win_no_one)
    }
    
    // Precache sounds
    new sound[SOUND_MAX_LENGTH]
    for (index = 0; index < ArraySize(g_sound_win_zombies); index++)
    {
        ArrayGetString(g_sound_win_zombies, index, sound, charsmax(sound))
        if (equal(sound[strlen(sound)-4], ".mp3"))
        {
            format(sound, charsmax(sound), "sound/%s", sound)
            precache_generic(sound)
        }
        else
            precache_sound(sound)
    }
    for (index = 0; index < ArraySize(g_sound_win_humans); index++)
    {
        ArrayGetString(g_sound_win_humans, index, sound, charsmax(sound))
        if (equal(sound[strlen(sound)-4], ".mp3"))
        {
            format(sound, charsmax(sound), "sound/%s", sound)
            precache_generic(sound)
        }
        else
            precache_sound(sound)
    }
    for (index = 0; index < ArraySize(g_sound_win_no_one); index++)
    {
        ArrayGetString(g_sound_win_no_one, index, sound, charsmax(sound))
        if (equal(sound[strlen(sound)-4], ".mp3"))
        {
            format(sound, charsmax(sound), "sound/%s", sound)
            precache_generic(sound)
        }
        else
            precache_sound(sound)
    }
    
    OrpheuRegisterHook( OrpheuGetFunction( "InstallGameRules" ), "On_InstallGameRules", OrpheuHookPost );
         _UpdateTeamScores = OrpheuGetFunction( "UpdateTeamScores", "CHalfLifeMultiplay" );
}

public OrpheuHookReturn:On_InstallGameRules()
{
    g_pGameRules = OrpheuGetReturn();
}

public zp_fw_gamemodes_end()
{
    // Determine round winner, show HUD notice
    new sound[SOUND_MAX_LENGTH]
    if (!zp_core_get_zombie_count())
    {
        // Human team wins
        if (get_pcvar_num(cvar_winner_show_hud))
        {
            set_hudmessage(0, 0, 200, HUD_EVENT_X, HUD_EVENT_Y, 0, 0.0, 3.0, 2.0, 1.0, -1)
            ShowSyncHudMsg(0, g_HudSync, "%L", LANG_PLAYER, "WIN_HUMAN")
        }
        
        if (get_pcvar_num(cvar_winner_sounds))
        {
            ArrayGetString(g_sound_win_humans, random_num(0, ArraySize(g_sound_win_humans) - 1), sound, charsmax(sound))
            PlaySoundToClients(sound, 1)
        }
        
        ChangeTeamScore( 2, 1, true )
                UpdateTeamScores();
    }
    else if (!zp_core_get_human_count())
    {
        // Zombie team wins
        if (get_pcvar_num(cvar_winner_show_hud))
        {
            set_hudmessage(200, 0, 0, HUD_EVENT_X, HUD_EVENT_Y, 0, 0.0, 3.0, 2.0, 1.0, -1)
            ShowSyncHudMsg(0, g_HudSync, "%L", LANG_PLAYER, "WIN_ZOMBIE")
        }
        
        if (get_pcvar_num(cvar_winner_sounds))
        {
            ArrayGetString(g_sound_win_zombies, random_num(0, ArraySize(g_sound_win_zombies) - 1), sound, charsmax(sound))
            PlaySoundToClients(sound, 1)
        }
        
        ChangeTeamScore( 1, 1, true )
                UpdateTeamScores();
    }
    else
    {
        // No one wins
        if (get_pcvar_num(cvar_winner_show_hud))
        {
            set_hudmessage(0, 0, 200, HUD_EVENT_X, HUD_EVENT_Y, 0, 0.0, 3.0, 2.0, 1.0, -1)
            ShowSyncHudMsg(0, g_HudSync, "%L", LANG_PLAYER, "WIN_NO_ONE")
        }
        
        if (get_pcvar_num(cvar_winner_sounds))
        {
            ArrayGetString(g_sound_win_humans, random_num(0, ArraySize(g_sound_win_humans) - 1), sound, charsmax(sound))
            PlaySoundToClients(sound, 1)
        }
        
        ChangeTeamScore( 2, 1, true )
                UpdateTeamScores();
    }
}

// Block some text messages
public message_textmsg()
{
    new textmsg[22]
    get_msg_arg_string(2, textmsg, charsmax(textmsg))
    
    // Game restarting/game commencing, reset scores
    if (equal(textmsg, "#Game_will_restart_in") || equal(textmsg, "#Game_Commencing"))
    {
        g_ScoreHumans = 0
        g_ScoreZombies = 0
    }
    // Block round end related messages
    else if (equal(textmsg, "#Hostages_Not_Rescued") || equal(textmsg, "#Round_Draw") || equal(textmsg, "#Terrorists_Win") || equal(textmsg, "#CTs_Win"))
        return PLUGIN_HANDLED;
    
    return PLUGIN_CONTINUE;
}

// Block CS round win audio messages, since we're playing our own instead
public message_sendaudio()
{
    new audio[17]
    get_msg_arg_string(2, audio, charsmax(audio))
    
    if(equal(audio[7], "terwin") || equal(audio[7], "ctwin") || equal(audio[7], "rounddraw"))
        return PLUGIN_HANDLED;
    
    return PLUGIN_CONTINUE;
}

ChangeTeamScore( const iTeam, const iValue, bool:Add )
{
    new iScore;
    
    if( Add )
        iScore = GetTeamScore( iTeam ) + iValue;
    else    iScore = iValue;
    
    SetTeamScore( iTeam, iScore );
}

UpdateTeamScores()
{
    OrpheuCall( _UpdateTeamScores, g_pGameRules );
}
    
// Plays a sound on clients
PlaySoundToClients(const sound[], stop_sounds_first = 0)
{
    if (stop_sounds_first)
    {
        if (equal(sound[strlen(sound)-4], ".mp3"))
            client_cmd(0, "stopsound; mp3 play ^"sound/%s^"", sound)
        else
            client_cmd(0, "mp3 stop; stopsound; spk ^"%s^"", sound)
    }
    else
    {
        if (equal(sound[strlen(sound)-4], ".mp3"))
            client_cmd(0, "mp3 play ^"sound/%s^"", sound)
        else
            client_cmd(0, "spk ^"%s^"", sound)
    }
} 


P.S: i tested and work fine but i have a problem for some reason now the sound and the hud dont appear when round end, i mean this emit a sound and show a hud when rounds end too, but now dont show, anyone know why this happens and know how to fix it?

[NikKOo31]

The code is fine. Did you check your error logs? If not, debug your plugin and post trace here ^^

[wicho]

Ok for some reason now the hud and sound work fine, but now i have another problem when a team won this gives two points instead of one and when no one won (round draw) gives one point to each team.. why this happens? i use the same code

[NikKOo31]

The game adds 1 point to the winner team, and you are adding 1 more >_<

PHP Code:

ChangeTeamScore( 2, 1, true ) 


If round draw you add 1 point to CT team, the other point is given by game (probably a map with hostages?)

[wicho]

I see, so i need to remove this when ct and terrorist won, and about the maps i use zm_ maps i dont think this have to hostages, but is strange cuz in the first time i tested this worked fine just the hud and sounds dont worked i dunno why happen this, the idea is to set my own teamscore i mean not taking the point that gives the game by default, if not I assign..

I have a question this is to update the scoreboard ChangeTeamScore( 1, 1, true ) and this internally UpdateTeamScores() right?

[wicho]

Someone know?