[YamiKaitou]

No temporary banning?

Better to use a const over a define for these

#define KEY_AUTHID "AuthID"
#define KEY_REASON "Reason"

const KEY_AUTHID[] = "AuthID";
const KEY_REASON[] = "Reason";

Does this support multiple servers using the same database? The code suggests no, but asking just in case.

Use formatex as opposed to format (where you can), it is faster.

[Expade]

You're right, no temporary banning.

#define ≈ new const;
format ≈ formatex;
Are you count bits of RAM?

And, this plugin is support multiple servers. Why do you think that not?

[YamiKaitou]

Originally Posted by Expade This plugin is support multiple servers (Why not? O_o)

So if I ban a player on Server1 and then he tries to connect to Server2 right away, he will be kicked?

[Expade]

He will be kicked after changelevel or restart on Server2

[klippy]

Originally Posted by Expade You're right, no temporary banning. #define ≈ new const; format ≈ formatex; Are you count bits of RAM? And, this plugin is support multiple servers. Why do you think that not?

If a string literal is found multiple times in code, it is better to use a constant to save some memory.
And formatex() is faster than format(), although format() must be used in some situations.

[HamletEagle]

Originally Posted by KliPPy If a string literal is found multiple times in code, it is better to use a constant to save some memory. And formatex() is faster than format(), although format() must be used in some situations.

Can you please explain where formatex can't be used and where format is a must ?

[YamiKaitou]

Originally Posted by HamletEagle Can you please explain where formatex can't be used and where format is a must ?

When you use the destination within the formatting, such as
format(msg, charsmax(msg), "[%s] %s", tag, msg);

[Backstabnoob]

Do not establish the database connection .15 seconds after plugin_init has been called. It's not safe and it doesn't guarantee that the cvars will be loaded - open the connection in plugin_cfg instead.

On the other hand, can you explain why exactly is this better than the other ban management plugins? "I don't like Advanced Bans" is not a valid reason and "my plugin is simpler" is not always a green instant-approval flag either.

[Expade]

Hmm. I think that ≈0.1 seconds is guarantee that SLAG's CVARs will be loaded very well. "plugin_cfg" function have too much timeout (it has been tested)

My plugin is better 'cause:
1. Have not any MySQL query errors (like Advanced Bans)
2. Clean, simple code (against again Advanced Bans, look at "QueryCreateTable" function in adv.bans for example)
3. Support new and old amxx versions
4. In plans - add compatibility sqlite, etc.

[YamiKaitou]

Originally Posted by Expade Hmm. I think that ≈0.1 seconds is guarantee that SLAG's CVARs will be loaded very well. "plugin_cfg" function have too much timeout (it has been tested)

If I put the CVars in amxx.cfg, then they will not get set until plugin_cfg as that is when admin(_sql).amxx executes that file. What timeout are you talking about? If it is related to SQL, there will be no difference.

1. Have not any MySQL query errors (like Advanced Bans)

Really? Cause right now, I can use SQL Injection with your plugin and cause errors or worse

2. Clean, simple code (against again Advanced Bans, look at "QueryCreateTable" function in adv.bans for example)

That actually doesn't mean much

3. Support new and old amxx versions

As do all the other ones