[joeyeyey]

Hey guys!
I am trying to store clients kills in a sqlite database. It is storing steamId correctly, creating table and creating new rows for new users properly. But the I can't read the kills with SQL_FetchInt and I can't understand what the problem is..

Here I am creating the table on plugin start:
// Create sql table

PHP Code:

new String:queryCreateTable[300];
    
    Format(queryCreateTable, sizeof(queryCreateTable), "CREATE TABLE killCounter(steamId tinytext, kills int)");
    
    new Handle:queryHCreateTable = SQL_Query(DB, queryCreateTable); 


And here I am creating the rows on client authorized:

PHP Code:

// Check if row created
    new String:queryCheck[300];
    decl String:SteamId[64];
    GetClientAuthString(client, SteamId, sizeof(SteamId));
    
    Format(queryCheck, sizeof(queryCheck), "SELECT steamId FROM killCounter WHERE steamId='%s'", SteamId);
    new Handle:queryHCheck = SQL_Query(DB, queryCheck);
    
    if(queryHCheck != INVALID_HANDLE) {
        if(SQL_FetchRow(queryHCheck)) {
            PrintToServer("Client exists in db, no need to create a new row!")
        } else {
            // Create sql row for new user
            PrintToServer("Creating row for new user!");
            new String:queryCreateRow[300];
            Format(queryCreateRow, sizeof(queryCreateRow), "INSERT INTO killCounter (steamId, kills) VALUES ('%s', 99)", SteamId);
            new Handle:queryHCreateRow = SQL_Query(DB, queryCreateRow);
        }
    } 


I am setting the kills to 99 just to get the reading and writing to the DB done since I am new to this.

Here I am looping out the table on command:

PHP Code:

PrintResults(Handle: queryH) {
        new String:SteamId[64];
        new Integer:kills;
        
        while(SQL_FetchRow(queryH)) {
            SQL_FetchString(queryH, 0, SteamId, sizeof(SteamId));
            SQL_FetchInt(queryH, 0, kills); // Warning 213: tag mismatch 
            PrintToServer("SteamId: %s, Kills: %n", SteamId, kills);
            PrintToChatAll("SteamId: %s, Kills: %n", SteamId, kills);
        }
    } 


It loops out my steamId correctly, since im doing it offline its just mine. But the kills are just giving random numbers(probably not really random). Has been 2 or 3 kills so far that was printed out.
Note the warning I am getting above in the while loop.
I would really appreciate help since I have been staring at this one hour plus googling sooo much.
Thanks in advance guys!

[Miu]

the second argument is an index into the row of results, you'd want it to be 1 instead of 0. 0 grabs the steamid again as an int (which would give some garbage address)

also the SQL_FetchTypeByName functions in smlib tend to be easier to use and maintain, e.g. SQL_FetchIntByName(queryH, "kills")

edit: also you use it like kills = SQL_FetchInt(queryH, 1), you're actually getting the dbresult

[joeyeyey]

Originally Posted by Miu the second argument is an index into the row of results, you'd want it to be 1 instead of 0. 0 grabs the steamid again as an int (which would give some garbage address) also the SQL_FetchTypeByName functions in smlib tend to be easier to use and maintain, e.g. SQL_FetchIntByName(queryH, "kills") edit: also you use it like kills = SQL_FetchInt(queryH, 1), you're actually getting the dbresult

Oh okay, I knew it would be some simple thing like that! Oh so you can actually use it like a method to save in a variable like in java/php? That's great! You're awesome, once again you save the day! Haha
Btw, I am failing to use smlib. I have extracted it to the sourcemod folder like they said and manually moved all the files and folders to its places. Still I get an error when I try to simply #include smlib in my plugins. Do you know if there are some common mistake I am doing there? It was a while ago I tried it, maybe I will understand what I am doing wrong now when Im not that new to everything.
Anyway, thanks for the help!

[Miu]

Originally Posted by joeyeyey Oh so you can actually use it like a method to save in a variable like in java/php?

there aren't methods in sourcepawn because it doesn't have classes, it's just a function returning an integer. you can't return arrays so you need to pass one by reference in order to return strings instead, but you can return single primitives fine.

also php is insane, don't compare it to anything else

Originally Posted by joeyeyey Btw, I am failing to use smlib. I have extracted it to the sourcemod folder like they said and manually moved all the files and folders to its places. Still I get an error when I try to simply #include smlib in my plugins.

you put it in the wrong place, you need to put it in /include relative to the compiler location

[joeyeyey]

Originally Posted by Miu there aren't methods in sourcepawn because it doesn't have classes, it's just a function returning an integer. you can't return arrays so you need to pass one by reference in order to return strings instead, but you can return single primitives fine. also php is insane, don't compare it to anything else you put it in the wrong place, you need to put it in /include relative to the compiler location

Okay, I will try it. Now, it shows the starting value of kills properly. But I can't seem to change it. I am trying to add 1 kill every round just to find out how it is working. But it doesn't change the value.

PHP Code:

public OnRoundStart(client) {
    
    new Integer:kills;
    new String:query[300];
    new String:SteamId[64];
    GetClientAuthString(client, SteamId, sizeof(SteamId));
    Format(query, sizeof(query), "SELECT kills FROM killCounter WHERE steamId = %s", SteamId);
    new Handle:queryH = SQL_Query(DB, query);
    kills = SQL_FetchInt(queryH, 1);
    kills += 1;
    Format(query, sizeof(query), "UPDATE killCounter SET kills = '%i' WHERE steamId = '%s'", kills, SteamId);
    new Handle:queryH2 = SQL_Query(DB, query);
    
} 


Can you see what I am doing wrong this time?
Cheers

[joeyeyey]

Edited the code since I forgot the handler the first time. It isnt updating and addnig 1 kills every round start that its supposed to. What am I doing wrong?

[Potato Uno]

Originally Posted by joeyeyey PHP Code: public OnRoundStart(client) {          new Handle:queryH = SQL_Query(DB, query);     new Handle:queryH2 = SQL_Query(DB, query);      }  Can you see what I am doing wrong this time? Cheers

BAD BAD BAD BAD BAD!

Use THREADED queries, SQL_TQuery.

[Miu]

the index needs to be 0 there since the result set is just the kills, not (steamid, kills)

this is why sql_fetchintbyname is easier :)

[joeyeyey]

Originally Posted by Potato Uno BAD BAD BAD BAD BAD! Use THREADED queries, SQL_TQuery.

Will look that up, but that shouldn't be what causing it to not update right?

Also, is it that SQL_TQuery destroys itself afterwards. So that I can just use the same variable names over and over? Or why is it that TQuery is better? Just want to learn this stuff

[joeyeyey]

Originally Posted by Miu the index needs to be 0 there since the result set is just the kills, not (steamid, kills) this is why sql_fetchintbyname is easier

Okay, yeah will definitely fix that smlib. But it still ain't updating with index set to "0" in the query.