Yet another High Ping Kicker works for me.
As in loads, compiles, and runs. That is the short term impression. There might be CPU spike or general lag issue still present that slowly makes way or just happens when there are certain loads of traffic, and or mixture of metamods on the server. Somebody with code skills will need to review the code itself. I am giving it 1 last test as a server admin. With some code curiosity I did uncover 1 tiny thing that is confirmed part of the change log but wasn't really complete. TYPOS.
That looks like a typo on the name. This is the only thing I found that JDLR when I test but is not a functionality issue. It causes annoying typo in the log.
Now I look further. Everywhere I look I see typos but the plugin is not broken in the sense where admins are unable to use and test this dynamic plug. Although it has i
f not a bot and etc in the code; monitoring continues to see if it does spike CPU as I have wondered. Last comment was years ago. Vaguely saying it is broken does not mean anything without others chiming in.
There are comments in source about going easy on the CPU already.
Code:
new g_CheckPlayer[MAXPLAYERS+1] // To save the poor cpu having to keep track of the connected players
That leaves me with the impression CPU-spike has been a problem in the past with this sort of code with
similar plugins steaming from the amxmodx's engine timer itself. What concerns me is typo heaven here. I can read English but not Pawn as well.
Changing was misspelled 3x in 1 line of a change log comment depicting fixing typos.
Quote:
1.1.2
- Fixed: Typo in log_amx()
- Added: #define To disable cl_updaterate on the client.
- Added: Automaticly changeing client settings without chaning the cvar ( Just changeing the setinfo field instead )
|
Then again, where it counts more, 1x in the code itself from at a glance just watching my server run.
Quote:
register_cvar("yhpk_version",PluginVersion,FC VAR_SERVER)
|
I knew code was off there minimally and potentially a lag maker here when plugin's task is to control it not cause it!
Edit: My bad that stands for Yet. Since hpk.sma is the name here and I am assuming Y stands for 'yet'. It just looked, off. Consider matching yhpk_version with yhpk.sma or other way around.
This plugin is suspect to lag out when certain other metamod plugins are used or it has already kicked everybody, lag, disabled plug then issue goes away. One does not need to know how to program to see that. Plugin goes away and so does lag in the past. 1 last try. Running vanilla.
__________________