[Kraizen]

Lol dont worry probably all of the conflicts are of my own creation haha

Yep got it working completely woooohoooo! lol

[Whosat]

Originally Posted by Kraizen Lol dont worry probably all of the conflicts are of my own creation haha Yep got it working completely woooohoooo! lol

Alright that's good!

[Whosat]

Originally Posted by turktheturd this what people usually type "!laser". I don't know anythign about scripting but how to change commands from "/laseron" to "!laseron"?

Ah found the link which describes this.
!laser and /laser will both work.

[olj]

Originally Posted by Whosat Will look into this. Did some big code moving in 1.0.1 might have broken some of that. Eh. I didn't change any code relating to the upgrades in 1.0.1. Only changed the locations of code checking for convar values. And its weird for the tank to be having 150hp. There are checks before every upgrade giving for the player's team. My guess is its l4d's survivor upgrades bug. Does it always happen?

No, not always, but there wasnt such bugs in older version. Im pretty sure somewhere in code the ckeck fails and tank got random upgrade, then if this is hot meal upgrade, he get pityful 150 hp. I will play more today, and i tell if it happens in older version.

PS. 1.0 version is emerged from 0.5.4 build i believe? What changes you made in 0.5.4 related to 0.5.3? Maybe this will clear situation.

EDIT: didnt see new version, will try now, thanx.
EDIT2:

PHP Code:

// Fix for olj's tank problem.
    // Plugin Compat: Secondfinaletank, SuperVersus:Supertank
    if(FindConVar("l4d_secondfinaletank_version") != INVALID_HANDLE && FindConVar("l4d_supertank") != INVALID_HANDLE && GetConVarInt(FindConVar("l4d_supertank")) != 0) {
        new client = GetClientOfUserId(GetEventInt(event, "userid"));
        SetEntProp(client,Prop_Send,"m_iHealth", 6000);
        SetEntProp(client,Prop_Send,"m_iMaxHealth", 6000);
    } 


That wont fix anything - i dont use superversus and secondfinale tank plugins

[Chaotic Llama]

Originally Posted by Whosat Ah found the link which describes this. !laser and /laser will both work.

This is true. Buy default Sourcemod is configured to use both / and !. The forward slash is easiest and is hidden. Using ! your message will be broadcast in chat ie: !laser will be seen along with the message that your laser was toggled on/off.

I tested... both work.

[Chaotic Llama]

Originally Posted by olj PS. 1.0 version is emerged from 0.5.4 build i believe? What changes you made in 0.5.4 related to 0.5.3? Maybe this will clear situation.

Thats the history I remember olj 5.4dev rolled into v1.0's release. A quick compare of 5.4 to 5.3 below if it helps you. I'm pretty sure changes between 5.3 and 5.4 were all related to surup not enabling in versus.

Comparing: krx_surup v0.5.4dev.sp to krx_surup v0.5.3.bak.sp
====
====
78     <! #define PLUGIN_VERSION        "0.5.4.dev2"
     !> #define PLUGIN_VERSION        "0.5.3"
     !>     #if BOOL_SELECTIVE_GAMEMODES
599     <-         #if BOOL_DONT_RETAIN_UPGRADES
600     <!         if(GetConVarInt(ResetOnMapChange)) {
601     <-             HookEvent("map_transition", Event_RoundEnd, EventHookMode_Pre);            // Resets players' upgrades on next mission
605     <!     #if BOOL_SELECTIVE_GAMEMODES
606     <!     } else {
607     <!         g_Verbosity = 0;
608     <!         b_CanAnnounce = false;
609     <!         b_Enabled = false;
610     <!     }
(599)     ->     #if BOOL_DONT_RETAIN_UPGRADES
     !>     if(GetConVarInt(ResetOnMapChange))
(601)     ->         HookEvent("map_transition", Event_RoundEnd, EventHookMode_Pre);            // Resets players' upgrades on next mission
636     <!         ResetValues();
721     <!         return Plugin_Continue;
875     <!     CreateTimer(5.0, GiveInitialUpgrades, botClient);
876     <!     CreateTimer(6.0, ReGiveClientUpgrades, botClient);
877     <!     //GiveInitialUpgrades(INVALID_HANDLE, botClient);
878     <!     //ReGiveClientUpgrades(INVALID_HANDLE, botClient);
879     <!     //RemoveAllUpgrades(INVALID_HANDLE, playerClient);
     !>     GiveInitialUpgrades(INVALID_HANDLE, botClient);
     !>     ReGiveClientUpgrades(INVALID_HANDLE, botClient);
     !>     RemoveAllUpgrades(INVALID_HANDLE, playerClient);
913     <!     CreateTimer(5.0, GiveInitialUpgrades, playerClient);
914     <!     CreateTimer(6.0, ReGiveClientUpgrades, playerClient);
915     <!     //GiveInitialUpgrades(INVALID_HANDLE, playerClient);
916     <!     //ReGiveClientUpgrades(INVALID_HANDLE, playerClient);
917     <!     //RemoveAllUpgrades(INVALID_HANDLE, botClient);
     !>     GiveInitialUpgrades(INVALID_HANDLE, playerClient);
     !>     ReGiveClientUpgrades(INVALID_HANDLE, playerClient);
     !>     RemoveAllUpgrades(INVALID_HANDLE, botClient);
1468     <!     #if BOOL_SELECTIVE_GAMEMODES
1469     <!     //     InvalidGameMode?    Real Client?    Connected?                    Survivors?                Already got init upgrades?
1470     <!     if(b_InvalidGameMode || !client || !IsClientInGame(client) || GetClientTeam(client) != 2 || b_Upgrades_GivenInit[client]) return;
1471     <!     #else
     !>     //     Real Client?    Connected?                    Survivors?                Already got init upgrades?
1473     <!     #endif
1494     <!     #if BOOL_SELECTIVE_GAMEMODES
1495     <!     if(b_InvalidGameMode)    return;
1496     <!     #endif
1523     <!     #if BOOL_SELECTIVE_GAMEMODES
1524     <!     if(b_InvalidGameMode)    return;
1525     <!     #endif
     !>             //PrintToChatAll("%s \x04%N\x01 got %s\x01.", PLUGIN_TAG_C, client, UpgradeShortInfo[upgrade]);
1569     <!     #if BOOL_SELECTIVE_GAMEMODES
1570     <!     if(!b_InvalidGameMode && IsClientInGame(client)) {
1571     <!     #else
1573     <!     #endif

[Whosat]

Originally Posted by olj No, not always, but there wasnt such bugs in older version. Im pretty sure somewhere in code the ckeck fails and tank got random upgrade, then if this is hot meal upgrade, he get pityful 150 hp. I will play more today, and i tell if it happens in older version. PS. 1.0 version is emerged from 0.5.4 build i believe? What changes you made in 0.5.4 related to 0.5.3? Maybe this will clear situation. EDIT: didnt see new version, will try now, thanx. EDIT2: PHP Code: // Fix for olj's tank problem.     // Plugin Compat: Secondfinaletank, SuperVersus:Supertank     if(FindConVar("l4d_secondfinaletank_version") != INVALID_HANDLE && FindConVar("l4d_supertank") != INVALID_HANDLE && GetConVarInt(FindConVar("l4d_supertank")) != 0) {         new client = GetClientOfUserId(GetEventInt(event, "userid"));         SetEntProp(client,Prop_Send,"m_iHealth", 6000);         SetEntProp(client,Prop_Send,"m_iMaxHealth", 6000);     }  That wont fix anything - i dont use superversus and secondfinale tank plugins

Ah crap could you change that line to

PHP Code:

if(FindConVar("l4d_secondfinaletank_version") == INVALID_HANDLE && (FindConVar("l4d_supertank") == INVALID_HANDLE || GetConVarInt(FindConVar("l4d_supertank")) != 0)) { 


Sorry, see what happens when you code after just waking up :X

@Chaotic Llama: Yup the only changes were for surup not working in versus.

Erm I'll be quite inactive for the coming week because of tests and such.
So I'll be back the next week end

[olj]

I need to clear this all a bit. The quick fix is reverting tanks healt back to its value. That can work, but well, thats not bug fixing, just workaround.

On the other hand if this is upgrades' problem (read: Valve's), this can hardly be repaired, BUT - IM 100% SURE I DIDNT GET THIS IN 0.5.3.. Thats why i go more testing with 0.5.3.

ChaoticLama, thanx very much, i will check these lines.

[Whosat]

Originally Posted by olj I need to clear this all a bit. The quick fix is reverting tanks healt back to its value. That can work, but well, thats not bug fixing, just workaround. On the other hand if this is upgrades' problem (read: Valve's), this can hardly be repaired, BUT - IM 100% SURE I DIDNT GET THIS IN 0.5.3.. Thats why i go more testing with 0.5.3. ChaoticLama, thanx very much, i will check these lines.

Yeah workaround.

Ah alright but if you disabled the Hot Meal upgrade by the convar, the plugin will never give the upgrade. So it has to be L4D giving the upgrade to the tank (by mistake - Valve's bug)

[olj]

Originally Posted by Whosat Yeah workaround. Ah alright but if you disabled the Hot Meal upgrade by the convar, the plugin will never give the upgrade. So it has to be L4D giving the upgrade to the tank (by mistake - Valve's bug)

If hot meal disabled - you sure it would be disabled for BOTS also? I mean you checked the code for bots right? This is really hard to dig in 80 kb of code. If noone else getting this error this can be my side problem only. But i hadn't problems with hot meal with 0.5.3, neither with Jerrith version.

I wonder what will happen if i disable upgrades for bots.