[MFS]

Does it work for TF2?

[Horsedick]

Originally Posted by MFS Does it work for TF2?

yeah it does but as I said it needs to have a way to restrict targeting certain steamid's or flag users vs everyone under any use of SM commands

[daleGEND]

Has anyone looked into these errors?

L 08/12/2012 - 190:12: [SM] Native "GetUserAdmin" reported: Client index -1 is invalid L 08/12/2012 - 190:12: [SM] Displaying call stack trace for plugin "admin_logging_custom.smx": L 08/12/2012 - 190:12: [SM] [0] Line 25, /home/groups/alliedmodders/forums/files/3/0/8/7/6/28025.attach::OnLogAction() L 08/12/2012 - 1908: [SM] Native "GetUserAdmin" reported: Client index -1 is invalid L 08/12/2012 - 1908: [SM] Displaying call stack trace for plugin "admin_logging_custom.smx": L 08/12/2012 - 1908: [SM] [0] Line 25, /home/groups/alliedmodders/forums/files/3/0/8/7/6/28025.attach::OnLogAction() L 08/12/2012 - 190:58: [SM] Native "GetUserAdmin" reported: Client index -1 is invalid L 08/12/2012 - 190:58: [SM] Displaying call stack trace for plugin "admin_logging_custom.smx": L 08/12/2012 - 190:58: [SM] [0] Line 25, /home/groups/alliedmodders/forums/files/3/0/8/7/6/28025.attach::OnLogAction()

[Pixeli]

Hello, its possible to get logs from THC RPG Plugin? can someone make it? like see who admin giving levels,credits,xp and etc

[TheHardstyleBro]

Originally Posted by daleGEND Has anyone looked into these errors?

Well -1 is an unconnected client. Could be rcon or console.

[Powerlord]

Originally Posted by Horsedick yeah it does but as I said it needs to have a way to restrict targeting certain steamid's or flag users vs everyone under any use of SM commands

The problem here is that CheckCommandAccess/CheckAccess only check users that have all the flags you specify. It's a bit trickier to add support to log commands of admins who have any of a specific list of flags.

Originally Posted by daleGEND Has anyone looked into these errors?

admin_logging_custom doesn't check if the client is -1 or 0 before attempting to get the user's admin ID. -1 and 0 are both documented client values of OnLogAction when the admin is either not applicable (-1) or the server console (0), but aren't valid client IDs.

This is apparently a bug introduced into the custom version, as the version in the first post doesn't have this bug.

The fix is to split the two checks up, as attached.

[daleGEND]

Originally Posted by Powerlord The problem here is that CheckCommandAccess/CheckAccess only check users that have all the flags you specify. It's a bit trickier to add support to log commands of admins who have any of a specific list of flags. admin_logging_custom doesn't check if the client is -1 or 0 before attempting to get the user's admin ID. -1 and 0 are both documented client values of OnLogAction when the admin is either not applicable (-1) or the server console (0), but aren't valid client IDs. This is apparently a bug introduced into the custom version, as the version in the first post doesn't have this bug. The fix is to split the two checks up, as attached.

Thank you!

[daleGEND]

Odd, it doesn't seem to be logging anything lol.

[NameUser]

Originally Posted by daleGEND Odd, it doesn't seem to be logging anything lol.

Yeah, it's not working for me either...

[gH0sTy]

Originally Posted by daleGEND Has anyone looked into these errors?

You're probably using an outdated version as line 25 checks if the client is > 0 before attempting to get the admin ID.

Originally Posted by Powerlord admin_logging_custom doesn't check if the client is -1 or 0 before attempting to get the user's admin ID...

Incorrect, read above.

Originally Posted by Horsedick yeah it does but as I said it needs to have a way to restrict targeting certain steamid's or flag users vs everyone under any use of SM commands

Try the attached version, it will create a sm_admin_logging.cfg file where you can set the flag(s) you want to log.