[Simo123]

Description
This plugin fixes spray/impulse 201 sound bug, when you're under for ex. an train on de_train map you couldn't hear the sound of your own spray or others. Fixes also a bug when you spray at a certain distance and the decal is not displayed.

Modules
-amxmodx
-fakemeta

Credits
Arkshine - A method that fixes decal at certain distance and sound bug.

Other info
It should work on other mods as well.

I made a fast video where the spray sound bug is shown,
(with and without fix).
http://youtu.be/gj-fFqi9oAo

Updated the plugin - 1.0 -> 1.1.
Fixes now decal distance bug
Spray sound bug fix -> Spray bug fix
Other method to fix those bugs

Tested with amxmodx 1.8.1 in Counter-Strike 1.6.

[tuty]

afaik in linux servers that spray event won't work, try it and you will see , anyway using spk to only that client is bad and is useless...the sprayer sound is emited not spoken in players console

[ConnorMcLeod]

Real fix would prevent the sound from playing only when the spray is not done and would prevent private data (next decal time) from being set.

[Simo123]

I can't find any other way, client_cmd is just like you would write it in your console, I wouldn't say it would harm anyone, and no it didn't work with emitsound, I don't know any other way since I don't know what is causing it, if it's entities or what it is.

Also sound is working properly, you can hear it and others can do so, imo it's good as it is. Ofc if anyone is coming up with a better idea which may work, feel free to post it here then.

EDIT: The plugin worked fine on my linux server tuty.

[ConnorMcLeod]

Originally Posted by Simo123 I can't find any other way, client_cmd is just like you would write it in your console, I wouldn't say it would harm anyone, and no it didn't work with emitsound, I don't know any other way since I don't know what is causing it, if it's entities or what it is. Also sound is working properly, you can hear it and others can do so, imo it's good as it is. Ofc if anyone is coming up with a better idea which may work, feel free to post it here then.

But all players hear it, whatever the place they are on the map lol.

Well, from your event you could retrieve player index using read_data(2) and then emit sound from that player (no index is passed to the event, so id you use is equal to 0).
This won't fix the wrong pdata though. edit : misread, i thought about another bug.

[Simo123]

The thing is, I guess there isn't any better solution though now atm. Anyway I will look into this really fast as soon as I can, I got it working with read_data(2), the only problem was that it did the sound only for yourself, but I didn't even try with emit_sound, so I will look into it.

EDIT: Failed with the text, obv it would just make the sound "only" for you, anyways new update coming.

[ConnorMcLeod]

I would do it like this :

Declare a Float global array, 33 cells, to store when a sound was played for a player.
When emitsound is sent, with the correct sound, retrieve the entity owner, it is the player id, store the gametime in the global array.
When the even is called, check that time, if it is more than 0.1 for actual gametime, send your emit_sound.

[Simo123]

Originally Posted by ConnorMcLeod I would do it like this : Declare a Float global array, 33 cells, to store when a sound was played for a player. When emitsound is sent, with the correct sound, retrieve the entity owner, it is the player id, store the gametime in the global array. When the even is called, check that time, if it is more than 0.1 for actual gametime, send your emit_sound.

Tested, it didn't work. As I got it now it seems as client_cmd only can only get the real sound, also with impulse 201 sound remake plugins it wouldn't fix the bug cause it uses the emit_sound function.

It seems as it would require to do a own distance check between the impulse 201 sounds, since read_data(2) did not work well, it was just for your own "id" and that isn't properly if we compare it to as how the standard impulse 201 sound is, it should be played to all but at a certain distance of couse.

[Arkshine]

There are actually 2 bugs you can easily solved because of one line.
The spray works like that :

1) Throw a traceline and see if we can paint a decal.

Spoiler

PHP Code:

    case 201 : // paint decal
        
        if( gpGlobals->time < m_flNextDecalTime )
        {
            break;
        }

        UTIL_MakeVectors (pev->v_angle );
        UTIL_TraceLine ( pev->origin + pev->view_ofs, pev->origin + pev->view_ofs + gpGlobals->v_forward * 128, ignore_monsters, ENT(pev), & tr);

        if( tr.flFraction != 1.0 )
        {
            m_flNextDecalTime = gpGlobals->time + decalfrequency.value;
            CSprayCan *pCan = GetClassPtr((CSprayCan *)NULL);
            pCan->Spawn( pev );
        }

        break; 


2) If we can, an "ultra temporary SprayCan entity" is spawned and is set with the player's origin/angles.

Spoiler

PHP Code:

void CSprayCan::Spawn ( entvars_t *pevOwner )
{
    pev->origin = pevOwner->origin + Vector ( 0 , 0 , 32 );
    pev->angles = pevOwner->v_angle;
    pev->owner = ENT(pevOwner);
    pev->frame = 0;

    pev->nextthink = gpGlobals->time + 0.1;
    EMIT_SOUND(ENT(pev), CHAN_VOICE, "player/sprayer.wav", 1, ATTN_NORM);
} 


3) 0.1 second later, before painting the decal it checks again if we can with a traceline :

Spoiler

PHP Code:

void CSprayCan::Think( void )
{
    TraceResult    tr;    
    int playernum;
    int nFrames;
    CBasePlayer *pPlayer;
    
    pPlayer = (CBasePlayer *)GET_PRIVATE(pev->owner);

    if (pPlayer)
        nFrames = pPlayer->GetCustomDecalFrames();
    else
        nFrames = -1;

    playernum = ENTINDEX(pev->owner);
    
    // ALERT(at_console, "Spray by player %i, %i of %i\n", playernum, (int)(pev->frame + 1), nFrames);

    UTIL_MakeVectors(pev->angles);
    UTIL_TraceLine ( pev->origin, pev->origin + gpGlobals->v_forward * 128, ignore_monsters, pev->owner, & tr);

    // No customization present.
    if (nFrames == -1)
    {
        UTIL_DecalTrace( &tr, DECAL_LAMBDA6 );
        UTIL_Remove( this );
    }
    else
    {
        UTIL_PlayerDecalTrace( &tr, playernum, pev->frame, TRUE );
        // Just painted last custom frame.
        if ( pev->frame++ >= (nFrames - 1))
            UTIL_Remove( this );
    }

    pev->nextthink = gpGlobals->time + 0.1;
} 


The 2 bugs happen because of 2) on the first line, where the entity origin is set with the player's origin + 32 on z axis. And the problem is +32.

- The first bug : When you try to spray at the distance limit you won't see decal. It's because the first traceline was ok with origin + pev->viewofs (+17 on z) but the second traceline has failed because of the start origin is not the same (+32 on z).
- The second bug : When you try to spray below something, sometimes you won't hear the sound. It's because the entity origin starts in a non-open area, meaning starts inside something.

To solve these issues, you would use pev->view_ofs (+17) instead of +32.

#include <amxmodx>
#include <fakemeta>

public plugin_init( )
{
    register_forward( FM_EmitSound, "OnEmitSound" );
}

public OnEmitSound( const entity, const channel, const sound[ ] )
{
    static const spraySound[] = "player/sprayer.wav";

    if( equal( sound, spraySound, charsmax( spraySound ) ) )
    {
        new player = pev( entity, pev_owner );

        new Float:origin[3]; 
        new Float:viewOfs[3];
        
        pev( player, pev_origin, origin );
        pev( player, pev_view_ofs, viewOfs );
        
        origin[0] += viewOfs[0];
        origin[1] += viewOfs[1];
        origin[2] += viewOfs[2];

        set_pev( entity, pev_origin, origin );
    }
}

[tpt]

Originally Posted by ConnorMcLeod I would do it like this : Declare a Float global array, 33 cells, to store when a sound was played for a player. When emitsound is sent, with the correct sound, retrieve the entity owner, it is the player id, store the gametime in the global array. When the even is called, check that time, if it is more than 0.1 for actual gametime, send your emit_sound.

Originally Posted by Simo123 Tested, it didn't work. As I got it now it seems as client_cmd only can only get the real sound, also with impulse 201 sound remake plugins it wouldn't fix the bug cause it uses the emit_sound function. It seems as it would require to do a own distance check between the impulse 201 sounds, since read_data(2) did not work well, it was just for your own "id" and that isn't properly if we compare it to as how the standard impulse 201 sound is, it should be played to all but at a certain distance of couse.

Tested and works fine...



edit: It doesn't matter anyway since Arkshine has better way to fix this.