[JoKeR LauGh]

Originally Posted by edon1337 Weird, I've read that Ham_Killed doesn't get called on grenades.

AFAIK, DeathMsg is the one which will not be called on grenade kill.

[Bugsy]

Originally Posted by JoKeR LauGh AFAIK, DeathMsg is the one which will not be called on grenade kill.

That makes no sense..The DeathMsg is shown in my screen shot.

[klippy]

I'm sure you are talking about this post: https://forums.alliedmods.net/showpo...26&postcount=5
He said "bomb", not "grenade". "Bomb" as in C4.

[edon1337]

Originally Posted by KliPPy I'm sure you are talking about this post: https://forums.alliedmods.net/showpo...26&postcount=5 He said "bomb", not "grenade". "Bomb" as in C4.

Oh a mis-understanding haha.

[JoKeR LauGh]

Originally Posted by KliPPy I'm sure you are talking about this post: https://forums.alliedmods.net/showpo...26&postcount=5 He said "bomb", not "grenade". "Bomb" as in C4.

Ahhh, I got it wrong there. My bad.

[aron9forever]

Well I've already went ahead and changed to deathmsg
Can't see any other reason for it not working other than what I wrote in the 2nd post

I'll wait for user reports and if it's still broken do some proper debugging. I was hoping someone with in-depth knowledge about the modules as well as the order in which things happen might spot something obvious.

[Bugsy]

Why don't you test your timing idea on your own to rule that out?

I'm sure there is a way to work around this. If you want more help, post the plugin and provide a way to produce the issue and what you are expecting to happen.

[PRoSToTeM@]

Originally Posted by aron9forever Well I've already went ahead and changed to deathmsg Can't see any other reason for it not working other than what I wrote in the 2nd post

Don't forget about this:

Originally Posted by PRoSToTeM@ DeathMsg isn't sent when player is killed by bomb.

[aron9forever]

Originally Posted by PRoSToTeM@ Don't forget about this:

thanks, but I only need to account for instances of players killing other players so its fine

Originally Posted by Bugsy Why don't you test your timing idea on your own to rule that out? I'm sure there is a way to work around this. If you want more help, post the plugin and provide a way to produce the issue and what you are expecting to happen.

That's the problem though, I'm not actively using the plugin, it's just people reporting stuff to me and sending random screenshots saying "its not working" without giving any other details.

I kept thinking it's hard to test with no players or bots installed but I realize now I could've just added some prints to check this.

It seems to be working fine now with deathmsg so I might have been right.

Originally Posted by EFFx PHP Code: if((cs_get_user_team(attacker)==CS_TEAM_CT && cs_get_user_team(victim)==CS_TEAM_T) || (cs_get_user_team(attacker)==CS_TEAM_T && cs_get_user_team(victim)==CS_TEAM_CT))  LOL, you just need this: PHP Code: if(cs_get_user_team(attacker) != cs_get_user_team(victim))

I've done most of my scripting work on "fun" modes so what you're seeing there is me making sure spectators killing people, or people killing spectators doesn't count. I know it's irrelevant since they don't even have a revive command but it's micro optimization against avoiding unexpected behavior, I'll leave it as is.

Originally Posted by EFFx Here PHP Code: if(cs_get_user_team(player)==CS_TEAM_T || cs_get_user_team(player)==CS_TEAM_CT)  Just add the flag 'e' on get_players() Like this PHP Code: get_players(iPlayers,iNum,"e")  Here's the API - https://www.amxmodx.org/api/amxmodx/get_players

I was actually contemplating using the 'e' flag when writing the plugin, however I decided not to for the following reasons:
-I have not found any examples or mentions of using the flag for both teams. All I can find is people using it to either select terrorists, or counter-terrorists, never both. You're supposed to pass another parameter if using the 'e' flag, the one that specifies what team to match against.
-The 'e' flag has had many problems in the past, I'm pretty sure they're all fixed in 1.8.3, but I'm compiling under 1.8.1. I'd rather avoid another micro-optimization than do the research on whether it works or not.


However since you've brought these parts of the code up and had me thinking of optimization I went ahead and cached the player's team.

PHP Code:

iTeam = cs_get_user_team(player);
if(iTeam==CS_TEAM_T || iTeam==CS_TEAM_CT)
{


new CsTeams:iTeamAttacker = cs_get_user_team(attacker);
new CsTeams:iTeamVictim = cs_get_user_team(victim);
if((iTeamAttacker==CS_TEAM_CT && iTeamVictim==CS_TEAM_T) || (iTeamAttacker==CS_TEAM_T && iTeamVictim==CS_TEAM_CT))
{ 


[EFFx]

I understand your side,

About your 'optimization', for check if the killer/victim is not on spectator, you can use a macro instead of repeating the same if() check.

PHP Code:

#define isOnAvaliableTeam(%1,%2) (cs_get_user_team(%1) != CS_TEAM_SPECTATOR && cs_get_user_team(%2) != CS_TEAM_SPECTATOR)