[urban_ninja]

I am trying to fix the rifles being able to shoot through walls exploite but the is_visible() and is_visible_origin() always return false whether both players can see each other or not. I have no issue with the function working properly in tfc. I use these 2 functions all the time in tfc. Could some one explain to me why these engine module functions have no effect in Counter Strike?

PHP Code:

public damage(victim, wpn, attacker, Float:dmg, bit)
{
    if(!is_visible(victim, attacker))
    {
        ExecuteHam(Ham_TakeDamage, attacker, wpn, attacker, dmg, bit)
        return HAM_SUPERCEDE;
    }
    return HAM_IGNORED;
} 


[Ef_Deas]

SDK function looks pretty simple and workable,

Spoiler

PHP Code:

static cell AMX_NATIVE_CALL is_visible(AMX *amx, cell *params)
{
    int src = params[1];
    int dest = params[2];
    CHECK_ENTITY(src);
    CHECK_ENTITY(dest);

    edict_t *pEntity = INDEXENT2(src);
    edict_t *pTarget = INDEXENT2(dest);

    if (pTarget->v.flags & FL_NOTARGET)
        return 0;

    Vector vLooker = pEntity->v.origin + pEntity->v.view_ofs;
    Vector vTarget = pTarget->v.origin + pTarget->v.view_ofs;

    TraceResult tr;

    TRACE_LINE(vLooker, vTarget, FALSE, pEntity, &tr);

    if (tr.fInOpen && tr.fInWater)
        return 0;
    else if (tr.flFraction == 1.0)
        return 1;

    return 0;
} 


but you can try something like this:

Spoiler

PHP Code:

// FakeMeta
stock bool:origin_sees_origin(Float:StartOrigin[3], Float:EndOrigin[3], IgnoreEnt)
{
    new thdl = create_tr2()

    engfunc(EngFunc_TraceLine, StartOrigin, EndOrigin, IGNORE_GLASS | IGNORE_MONSTERS, IgnoreEnt, thdl)

    new Float:fraction
    get_tr2(thdl, TR_flFraction, fraction)

    free_tr2(thdl)

    return (fraction == 1.0)
}

stock bool:ent_sees_ent(idUser, iTargetID)
{
    new Float:StartOrigin[3], Float:EndOrigin[3]
    pev(idUser, pev_origin, StartOrigin)   
    pev(iTargetID, pev_origin, EndOrigin)

    return origin_sees_origin(StartOrigin, EndOrigin, idUser)
} 


Or this

Spoiler

PHP Code:

// Engine
stock bool:ent_sees_ent( idUser, iEnt )
{
    new Float:vPlayerOrigin[3];
    entity_get_vector( idUser, EV_VEC_origin, vPlayerOrigin );

    new Float:vEntOrigin[3];
    entity_get_vector( iEnt, EV_VEC_origin, vEntOrigin );

    new Float:vReturn[3];

    new iHitEnt = trace_line( idUser, vPlayerOrigin, vEntOrigin, vReturn );

    return iHitEnt == iEnt;
} 


[meTaLiCroSS]

Originally Posted by urban_ninja I am trying to fix the rifles being able to shoot through walls exploite but the is_visible() and is_visible_origin() always return false whether both players can see each other or not. I have no issue with the function working properly in tfc. I use these 2 functions all the time in tfc. Could some one explain to me why these engine module functions have no effect in Counter Strike? PHP Code: public damage(victim, wpn, attacker, Float:dmg, bit) {     if(!is_visible(victim, attacker))     {         ExecuteHam(Ham_TakeDamage, attacker, wpn, attacker, dmg, bit)         return HAM_SUPERCEDE;     }     return HAM_IGNORED; }

What?

Try to explain what do you "think" that is_visible checks...

[urban_ninja]

Originally Posted by meTaLiCroSS What? Try to explain what do you "think" that is_visible checks...

It checks if 2 entities are visible to each other. However it does not work in counter strike for some reason. I switched to using a fakemeta stock fm_is_ent_visible() in fakemeta_util.inc which does pretty much the same thing but in fakemeta and it works. It seems to be a bug with the engine module its self running with counter strike.

[Black Rose]

These functions are very simple. In clear english you can translate fm_is_ent_visible() to "can the engine draw a straigt line from the attackers eyes to the middle point of the victims body without hitting anything else?".
So this will return false when someone is sticking their head up behind something as long as their belly is covered.
If the first one fails, I would suggest adding at least 2 more levels of tracelines to cover the head and the legs or feet. One at a time of course.

There are differences as well. is_visible() is from eyes to eyes. fm_is_ent_visible() is from eyes to middle(belly).
origin_sees_origin() is middle to middle unless used with offsets. ent_sees_ent() is basically the same as origin_sees_origin() but you can't use offsets.

On top of that, I think tracelines are CPU intensive. I would not run multiple traces on a 32 player server on any aim_* map every time someone shoots.

[urban_ninja]

I didn't ask how the is_visible(), is_visible_origin(),ect.. functions work. I asked why it does not work in counter strike through the engine module.

On top of that, I think tracelines are CPU intensive. I would not run multiple traces on a 32 player server on any aim_* map every time someone shoots.

How CPU intensive it is depends on OS and the speed of the core HLDS is running on as HLDS can only run on 1 core at any given time. I have at least ~100s of tracelines executed on my server per frame and performance isn't effected. Its all a relative concept.

[meTaLiCroSS]

Originally Posted by urban_ninja I didn't ask how the is_visible(), is_visible_origin(),ect.. functions work. I asked why it does not work in counter strike through the engine module. How CPU intensive it is depends on OS and the speed of the core HLDS is running on as HLDS can only run on 1 core at any given time. I have at least ~100s of tracelines executed on my server per frame and performance isn't effected. Its all a relative concept.

They WORK lol, he's telling you the functionality of them because you may think another think of their functionality

[urban_ninja]

Originally Posted by meTaLiCroSS They WORK lol, he's telling you the functionality of them because you may think another think of their functionality

Not for me. I use those functions all the time when making plugins for tfc but when I use those functions in cs they return the same value unconditionally and this problem only occurs with the engine module in cs. When a wall is between both players, it turns 0 which is expected. But when there's absolutely nothing between both players, it still returns 0. This is definitely an unusual scenario im having with it in cs and im not imagining this.

I've even had some craziness with the get_user_health() function in recent months returning some absurd value in the trillions while entity_get_float(id, EV_FL_health) returns the correct value matching the hud.

[Ef_Deas]

Originally Posted by urban_ninja Not for me. I use those functions all the time when making plugins for tfc but when I use those functions in cs they return the same value unconditionally and this problem only occurs with the engine module in cs. When a wall is between both players, it turns 0 which is expected. But when there's absolutely nothing between both players, it still returns 0. This is definitely an unusual scenario im having with it in cs and im not imagining this.

I gave you the SDK code, it works exactly like it says

Originally Posted by urban_ninja I've even had some craziness with the get_user_health() function in recent months returning some absurd value in the trillions while entity_get_float(id, EV_FL_health) returns the correct value matching the hud.

Thats mostly because people try to print float value with %d or vice versa

[urban_ninja]

Originally Posted by Ef_Deas I gave you the SDK code, it works exactly like it says Thats mostly because people try to print float value with %d or vice versa

The sdk code doesn't explain why its returning the same value no matter what.

As far as the get_user_health(), it was literally indexing a number in the trillions. It wasn't a print formatting mistake. If it was that, then the condition I had if(health < 100) should of returned as true anyway but it didn't because the value that got stored was much higher than the max 100. The get_user_health() turns health as an integer which %d is the proper format for that.