Raised This Month: $32 Target: $400
 8% 

Spam Blocker v3.6


Post New Thread Reply   
 
Thread Tools Display Modes
Hawk552
AMX Mod X Moderator
Join Date: Aug 2005
Old 02-23-2009 , 00:20   Re: Spam Blocker v1.2
Reply With Quote #21

There are major errors in this that prevent it from being approved. Here are some of them:

PHP Code:
formatex (configfile255"%s/spam_blocker.ini"configfile


This is unacceptable and I'm not sure why this plugin actually works. This should crash the server and if it doesn't then you should consider yourself very lucky.

If you would like any information regarding possible adjustments you could make or things you could do to make this better, please feel free to post here or PM me.

Approval pending on changes.
__________________

Last edited by Hawk552; 02-23-2009 at 00:22.
Hawk552 is offline
Send a message via AIM to Hawk552
alexinno
Senior Member
Join Date: Mar 2007
Location: C:\
Old 02-23-2009 , 09:06   Re: Spam Blocker v1.2
Reply With Quote #22

Hi TeoNoman this is a good idea , i didn't see any good working antispam plugin.
Maybe after fixing the problems above , you could add more options like

detect also IP's (numeric)
add white list (addresses that can be said on chat)
detect spam like *.bad-domain.* , *.*.bad-tld , bad-name.*.* ,etc (i think it's called regex)
allow white listed addresses like above posted the bad ones (*.good-domain.*)

sorry for my bad english or if you didn't understand what i'm asking for
thx

Last edited by alexinno; 02-23-2009 at 09:20.
alexinno is offline
TeoNoman
Senior Member
Join Date: Jun 2008
Old 02-23-2009 , 09:50   Re: Spam Blocker v1.2
Reply With Quote #23

What the problem? You can set a list of forbidden sites instead of whitelist. I'm not sure that there is a necessity of creating a whitelist. Also I'm not sure about IP detector. Why? Let him play. When he start spamming — the plugin will kick/ban him.
__________________
My plugins:
Spam Blocker

My servers:
http://gg.zombified.ru
TeoNoman is offline
anakin_cstrike
Veteran Member
Join Date: Nov 2007
Location: Romania
Old 02-23-2009 , 10:09   Re: Spam Blocker v1.2
Reply With Quote #24

Quote:
Originally Posted by TeoNoman View Post
Ah... Got it. You know, we are talking about steamid and chat messages. I'm sure that strlen of steamid is less than 32, also about chat message. Anyway, I have a stock of place.
He meant to say that you can only use 32 slots: it starts from 0 to x-1, where x is the max slots of the array/string, in your case 32, so 31.
__________________

anakin_cstrike is offline
fysiks
Veteran Member
Join Date: Sep 2007
Location: Flatland, USA
Old 02-23-2009 , 10:09   Re: Spam Blocker v1.2
Reply With Quote #25

Quote:
Originally Posted by TeoNoman View Post
Also I'm not sure about IP detector. Why? Let him play. When he start spamming — the plugin will kick/ban him.
I think he means if someone puts an IP in chat (e.g. game server ip)
fysiks is offline
TeoNoman
Senior Member
Join Date: Jun 2008
Old 02-23-2009 , 10:18   Re: Spam Blocker v1.2.1
Reply With Quote #26

fysiks, he can put this IP in spam_blocker.ini wut the problem?
anakin_cstrike, yes, I already understood that.
__________________
My plugins:
Spam Blocker

My servers:
http://gg.zombified.ru
TeoNoman is offline
fysiks
Veteran Member
Join Date: Sep 2007
Location: Flatland, USA
Old 02-23-2009 , 10:44   Re: Spam Blocker v1.2.1
Reply With Quote #27

Quote:
Originally Posted by TeoNoman View Post
fysiks, he can put this IP in spam_blocker.ini wut the problem?
I understand that, I was just clarifying. Also, he probably means "any" IP. You can't put every IP in the list . You would have to use regex for checking for "any" IP.

Also, from what I understand, reading a file is extremely slow. You probably don't want to read the file every single time something is said. I've seen plugins that read the file on plugin_init or plugin_cfg to populate an array. This would be much less time consuming (for the processor, not the coder ).

Also, in your method the file is not closed for all situations, it's closed for the situation where nothing happens.

Last edited by fysiks; 02-23-2009 at 10:46.
fysiks is offline
TeoNoman
Senior Member
Join Date: Jun 2008
Old 02-23-2009 , 10:51   Re: Spam Blocker v1.2.1
Reply With Quote #28

Thx, going to fix.
About regex — I'm not sure that everyone can handle with regular expressions.
__________________
My plugins:
Spam Blocker

My servers:
http://gg.zombified.ru
TeoNoman is offline
fysiks
Veteran Member
Join Date: Sep 2007
Location: Flatland, USA
Old 02-23-2009 , 11:15   Re: Spam Blocker v1.2.1
Reply With Quote #29

regex.inc:

PHP Code:
#if AMXX_VERSION_NUM >= 175 
i.e. Version 1.75
__________________
fysiks is offline
TeoNoman
Senior Member
Join Date: Jun 2008
Old 02-23-2009 , 11:19   Re: Spam Blocker v1.2.1
Reply With Quote #30

No-no, I mean not all users know what is regular expressions and how to handle with it.
__________________
My plugins:
Spam Blocker

My servers:
http://gg.zombified.ru
TeoNoman is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 22:08.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode