Raised This Month: $12 Target: $400
 3% 

Plugin works in 1.8.2, breaks in 1.9


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
csykosoma
Member
Join Date: Dec 2011
Old 03-19-2020 , 12:54   Plugin works in 1.8.2, breaks in 1.9
Reply With Quote #1

Hi all, I have a plugin that works in 1.8.2, but compiling and running that same plugin in 1.9 no longer works completely correct. My hunch is that the way menu handling was implemented is breaking in 1.9.

Report this plugin on Github?
csykosoma is offline
Napoleon_be
Veteran Member
Join Date: Jul 2011
Location: Belgium
Old 03-19-2020 , 12:58   Re: Plugin works in 1.8.2, breaks in 1.9
Reply With Quote #2

Show the code
__________________
Napoleon_be is offline
Send a message via Skype™ to Napoleon_be
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 03-19-2020 , 13:02   Re: Plugin works in 1.8.2, breaks in 1.9
Reply With Quote #3

Amxx should be backwards compatible so yes, you should report it(also provide the source code).
__________________
HamletEagle is offline
csykosoma
Member
Join Date: Dec 2011
Old 03-19-2020 , 13:05   Re: Plugin works in 1.8.2, breaks in 1.9
Reply With Quote #4

It's Auto-Mix Pug by Diegorkable. It starts the voting process but then begins to loop voting for teams over and over again. Rather than proceeding to voteFF().
Attached Files
File Type: sma Get Plugin or Get Source (pimpspug.sma - 84 views - 123.5 KB)
csykosoma is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 03-19-2020 , 14:16   Re: Plugin works in 1.8.2, breaks in 1.9
Reply With Quote #5

This is unfortunate because I don't think anyone is willing to check a 5k plugin to find out the problem. Any chances you have some coding experience so you can extract that part in a small standalone plugin that replicates the issue?
__________________
HamletEagle is offline
csykosoma
Member
Join Date: Dec 2011
Old 03-19-2020 , 16:37   Re: Plugin works in 1.8.2, breaks in 1.9
Reply With Quote #6

Edit: looking at the menu handling tutorial, many conventions were broken in this code regarding menu_destroy and trying to call the same menu handler within the menu handler.

PHP Code:
public votemap(idmenuitem) {
    if( 
item == MENU_EXIT ) {
        
menu_display(idg_gVoteMenu)
        return 
PLUGIN_HANDLED;
    }
... 
So this code breaks in 1.8.3 and 1.9. Is this considered a bug still? Should we expect 1.9 to handle this?

And then when starting HLDS I see the following lines when running in 1.9, do these hold any significance?:
Code:
stray key in process_key: changeyaw 59
stray key in process_key: hashumangibs 60
stray key in process_key: hasaliengibs 61
stray key in process_key: fademonster 62
stray key in process_key: gibmonster 63
stray key in process_key: getdeathactivity 64
stray key in process_key: becomedead 65
stray key in process_key: irelationship 67
stray key in process_key: painsound 68
stray key in process_key: reportaistate 70
stray key in process_key: monsterinitdead 71
stray key in process_key: look 72
stray key in process_key: bestvisibleenemy 73
stray key in process_key: finviewcone 74
stray key in process_key: fvecinviewcone 75
stray key in process_key: item_getiteminfo 61
stray key in process_key: cstrike_item_isweapon 65
stray key in process_key: cstrike_weapon_sendweaponanim 85
stray key in process_key: cstrike_player_resetmaxspeed 69
stray key in process_key: cstrike_player_isbot 81
stray key in process_key: cstrike_player_getautoaimvector 85
stray key in process_key: cstrike_player_blind 86
stray key in process_key: cstrike_player_ontouchingweapon 87

Last edited by csykosoma; 03-19-2020 at 17:46.
csykosoma is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 14:15.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode