[Grey83]

CamerDisco, I meant that void shouldn't return value.
You should use int for this.

[xines]

Originally Posted by CamerDisco I think it doesn't matter, but yes it see better, he could do it without stacks, but it's more comfortable.

CamerDisco.

Void basically means no return value needed.
Returns used in void would be. "return;" or "return 0;". As return; points to 0 value by default.

When you are using:
return GetEntData(client, g_iAccount); it means you are returning a "integer" with the value of GetEntData, so you'll have to use "int" as the type.

Same as using the IsClientValid stock, it returns a bool of true/false, then the type haves to be "bool".


Sorry about the colors, they are just set for better readability.

Hope this helps.

[8guawong]

i dont think he even used the stock we gave him


L 12/05/2016 - 14:209: [SM] Exception reported: Property "m_iAccount" not found (entity 0/worldspawn)

[BulgarPL]

Originally Posted by 8guawong i dont think he even used the stock we gave him L 12/05/2016 - 14:209: [SM] Exception reported: Property "m_iAccount" not found (entity 0/worldspawn)

I was using it but i stil got errors.


Im testing now Greys version.

[backwards]

Originally Posted by Grey83 better PHP Code: stock bool:IsClientValid(client) {     return (0 < client <= MaxClients && IsClientInGame(client)); }

stock bool:IsClientValid(client)
{
    return (0 < IsClientInGame(client) <= client <= MaxClients);
}

better?

[Mitchell]

Originally Posted by 1337norway stock bool:IsClientValid(client) { return (0 < IsClientInGame(client) <= client <= MaxClients); } better?

IIRC No, both are wrong (programmatically). This would be doing (if client was i.e. 5):
0 < true = True,
True <= 5 = True,
True <= MaxClients = True,
The end result is True.

Now if the client passed in was 250:
0 < IsClientInGame(250)
Error: Client Index 250 is invalid.

[backwards]

Originally Posted by Mitchell IIRC No, both are wrong (programmatically). This would be doing (if client was i.e. 5): 0 < true = True, True <= 5 = True, True <= MaxClients = True, The end result is True. Now if the client passed in was 250: 0 < IsClientInGame(250) Error: Client Index 250 is invalid.

Wouldn't it be:
0 < 1 = True
1 < 5 = True
5 < MaxClients = True

&

0 < 250 = True
1 < 250 = True
250 < MaxClients = False
?

[Grey83]

1337norway, IsClientInGame() can only take two values: true or false

[backwards]

Originally Posted by Grey83 1337norway, IsClientInGame() can only take two values: true or false

Yes but in memory that would be represented as a non zero value (true) or zero (false), i'd assume the non zero value would be 1 in Sourcemod although i'm not that great at it.

[Mitchell]

Originally Posted by 1337norway Yes but in memory that would be represented as a non zero value (true) or zero (false), i'd assume the non zero value would be 1 in Sourcemod although i'm not that great at it.

Yes, True is 1 and False is 0, however in your statement you said True == 5? And IsClientInGame(205) wouldn't return a value of false but fail to execute since 205 is not a client index.
Edit: This is where I might be wrong on how sourcemod sees
"X < Y < Z"
Does it see it as "X < Y && Y < Z" or does it see it as "(X < Y) < Z"
Which the first statement would be correct, however the second one wouldnt return valid results.

Examples

Ex1:
X = 0, Y = 2, Z = 10;
First Method:
0 < 2 && 2 < 10 = True && True = True;
Second Method:
(0 < 2) < 10 = True < 10 = True;

Ex2:
X = 0, Y = 15, Z = 10;
First Method:
0 < 15 && 15 < 10 = True && False = False;
Second Method:
(0 < 15) < 10 = True < 10 = True; //This is obviously wrong.