Raised This Month: $32 Target: $400
 8% 

[many games] AdsQL Advertisements System - v1.7.8 - Last Updated 2011-04-02


Post New Thread Reply   
 
Thread Tools Display Modes
Snaggle
AlliedModders Donor
Join Date: Jul 2010
Location: England
Old 02-23-2011 , 09:09   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #21

Is anyone else hosting their website with Gameservers.com? Each time I try and view the ads page I get "500 Internal Server Error".
Snaggle is offline
PharaohsPaw
Senior Member
Join Date: Dec 2008
Old 02-23-2011 , 09:13   AdsQL: Known Issues & To-Do List
Reply With Quote #22

Known Issues / To-Do List
There are a couple things I would still like to do/fix yet with this plugin and web interface

1. Problem - Ads display two (or more) at a time sometimes - FIXED
This is a problem that has existed with the original sm_adsmysql plugin for quite some time on some games such as the Left 4 Dead series, and I also believe the potential was there for this problem to happen on other games when reloading advertisements. The plugin made no attempt to determine whether an ads display timer was already running when creating one, except when the ads display interval changed. Plugin code has been reworked to route ALL ads loading/reloading through one function, and use global boolean "gatekeeper" variables to control access to this function and ensure that only one ad display timer is running at a time. It seems to have fixed the problem.

2. Make the plugin re-check the serverid.txt file at each OnMapStart()- FIXED
Previously the serverid.txt file was being read only at plugin start, and never read again. serverid.txt is now checked at every map start - if the timestamp has changed, it will re-read the file and reload the ads if the server ID has changed.

3. Internet Explorer Problems Deleting/Re-ordering Ads - FIXED
This problem existed with the original sm_adsmysql for a long time, reported by many users. I'm not sure how many of them realized it only happened with Internet Explorer.... You can thank Microsoft for being stupid and refusing for several years now to honor established HTML standards every other browser complies with that specify that the VALUE of an image type input on a form should also be submitted, not just the X/Y coordinates. Because Microsoft chooses to be stupid over this, you have to make every image button on a form have a different name and then make the server iterate through its entire POST data searching for which button name was "set". Sheesh, what a bunch of morons.

4. Ads Support for Non-English Languages - MOSTLY FIXED
Mostly fixed? What is THAT supposed to mean? Here's the deal. The original adsmysql web interface, plugin, and database "setup" did not utilize UTF8 character set encoding everywhere it would have needed to. So in some cases, ads written in other languages that were stored correctly in UTF8 in the database would not display correctly by the plugin. Several changes have been made to try to force the plugin, web interface, and database table setup (on installs with a new database) to always use UTF8. This should fix the problem for anyone doing ads (or usernames, etc.) in other languages whose characters can be expressed in UTF8. Some special languages that cannot use UTF8 character sets will probably still have problems. Thanks to Psychonic for the help and Payalnick for the testing.

5. Optimize Ad Delete/Change Ad Order Submit Processing - FIXED
Thanks to the changes I had to make for #3 above causing extra work on the server, there would be a slight delay after clicking an ad's red X to delete it, or after clicking the green up or down arrow of an ad to move it up or down in the list -- before the ads page would reload in the brower. In my first "pass" over this (in the 1.7.5 web UI release) I did the "safe" thing in the loop to find which button was clicked, and just counted all the way from 1 to the total number of records. I knew this wasn't ideal. Now after a few changes to ads.php with 1.7.7, the lowest and highest SQL record ID of the set of ads displayed on a page are tracked, and these are used as lower and upper bounds for the "button search loop". This speeds up form submission processing considerably, especially for anyone with more than 25 ads.

6. Move sample top banner logos out of web/adsql directory for upgraders - DONE
Done with 1.7.7 release. It occurred to me that if I am going to encourage folks to just replace the entire adsql folder on their web host to upgrade to the latest web interface, I should probably move the sample adsql/images/logo02.jpg and adsql/images/logo03.jpg out of the images folder and update the install instructions to alert new installers. This way if you have created custom top logo banners, they will NOT be replaced by mine if you just unpack the latest .zip and upload the whole web/adsql/ folder to your web host. Same goes for config.php and style.css.

7. Public CVAR's don't show up on L4D1
Our L4D v1 servers don't show the plugin public cvar's in HLSW or on game-monitor. No idea why, even though the plugin works fine. Not sure what to make of it.

8. Web Interface Form Validation
Validate what the user inputs for Game Type and Server ID fields when creating or editing ads. If there is a known syntax problem, make them correct it before the ad will be saved to the database. In the meantime, the web interface does show appropriate warnings around the Game Type and Server ID input box.

Last edited by PharaohsPaw; 04-01-2011 at 09:49.
PharaohsPaw is offline
PharaohsPaw
Senior Member
Join Date: Dec 2008
Old 02-23-2011 , 09:55   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #23

Quote:
Originally Posted by Snaggle View Post
Is anyone else hosting their website with Gameservers.com? Each time I try and view the ads page I get "500 Internal Server Error".
That sux.

a phpinfo() output might be helpful. If you can create a page somehwere on your host.. oh lets say call it phpinfo.php and put this in it:

Code:
<?php

phpinfo();

?>
it should provide lots of info when you go to that page in your browser, such as which PHP version, extensions supported, whether it has MySQL support or not (i'd be pretty surprised if it didn't though).

Also, if you can find your webserver's error log it will probably have pretty specific info in it that would help.

Offhand my hunch is that it might have an outdated PHP version on it. I don't *THINK* any of the functions I used are that new, but I can check if maybe some syntax I used might be a prob if I know what version they have.

Cheers,
PharaohsPaw

Last edited by PharaohsPaw; 02-23-2011 at 09:58.
PharaohsPaw is offline
marvel
BANNED
Join Date: Dec 2009
Old 02-23-2011 , 10:01   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #24

PharaohsPaw, I only host L4D/L4D2 so it's the only game I can test it in. I'll ask our sourcemod guru, maybe he can provide a fix I'll let you know!
marvel is offline
PharaohsPaw
Senior Member
Join Date: Dec 2008
Old 02-23-2011 , 10:18   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #25

Quote:
Originally Posted by marvel View Post
PharaohsPaw, I only host L4D/L4D2 so it's the only game I can test it in. I'll ask our sourcemod guru, maybe he can provide a fix I'll let you know!
Interesting, that's where we see it happening too. Both of these games hibernate after you start them up........
PharaohsPaw is offline
Snaggle
AlliedModders Donor
Join Date: Jul 2010
Location: England
Old 02-23-2011 , 11:17   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #26

Thanks for the reply Pharaoh, here is my info file: http://gmodtech.net/info.php
Snaggle is offline
PharaohsPaw
Senior Member
Join Date: Dec 2008
Old 02-23-2011 , 11:55   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #27

Snaggle it's definitely running an up-to-date PHP version (5.3.4) and also appears to have all the MySQL support it's going to need.

I may have to look again and try to pick out what php.ini settings are in play, I just offhand can't think of anything the web interface does that would matter unless maybe it has to do with exposing the HTTP variables or something.

Do you have access to the host's httpd error logs? I can see this is a RHEL5 (or knockoff) host based on the kernel uname output.
PharaohsPaw is offline
Snaggle
AlliedModders Donor
Join Date: Jul 2010
Location: England
Old 02-23-2011 , 12:11   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #28

Quote:
Originally Posted by PharaohsPaw View Post
Do you have access to the host's httpd error logs? I can see this is a RHEL5 (or knockoff) host based on the kernel uname output.
I don't think so nope

Though on a side note, great plugin and it's nice to see quick and pretty damn helpful support from the creator
Snaggle is offline
PharaohsPaw
Senior Member
Join Date: Dec 2008
Old 02-23-2011 , 12:26   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #29

snaggle i saved a copy of that php output page that I can look at w/o needing it to be up on your host, might be good to remove/rename/hide that info.php link when you can - in case your provider would get concerned about it being visible. If you happen to be able to get to the httpd error log it would be neat to see the log entries around the time you tried, with an ISE you'll probably have some fairly specific info in it.
PharaohsPaw is offline
PharaohsPaw
Senior Member
Join Date: Dec 2008
Old 02-23-2011 , 12:33   Re: [many valve games] AdsQL Advertisements System - v1.6.2 - Last Updated 2011-02-22
Reply With Quote #30

NM i missed your last post before i posted mine. I'll see what i can figure out. I can compare your phpinfo output to ours and probably figure out the problem, but it will probably be later today before I can.
PharaohsPaw is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 19:33.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode