[XSlayer]

Hi i want to change this strings conditions to switch, how can a i do it?

new Name[33][32];

public client_connect( Client )
{
       get_user_name( Client, Name[Client], 31 );
 
       set_task( 5.0, "SiHi", Client );
}
public SiHi( Client )
{
      if(equal(Name[Client], "Pedrito" )) // Change ifs to switch
      { 
           client_print( Client, print_center, "Hello Pedrito" );
      } 
      else if( equal(Name[Client], "Alex" ))
      {
          client_print( Client, print_center, "Hello Alex" );
      }
}

[fysiks]

You cannot use switch() with strings. Since this looks like very simple test code, you should explain what you are actually trying to do and we might be able to find a better way to do it.

[XSlayer]

Originally Posted by fysiks You cannot use switch() with strings. Since this looks like very simple test code, you should explain what you are actually trying to do and we might be able to find a better way to do it.

nothing different by the way, i have many classes with strings names, so i have many conditions with if not two like the example, i read that using switchs is better than ifs to optimize the plugin just that

public fxSound2( Client )
{     
          if(!is_user_bot(Client)) 
          {
             if(equal(__str_AMXX[Client],"Freezer"))
             { 
                   emit_sound( Client, CHAN_ITEM, "xs.freezer/prepunch.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); 
             }
             else if(equal(__str_AMXX[Client],"Vegeta"))
             { 
	           emit_sound( Client, CHAN_ITEM, "xs.vegeta/prepunch.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); 
             }
             else if(equal(__str_AMXX[Client],"Goku") )
             { 
	           emit_sound( Client, CHAN_ITEM, "xs.goku/prepunch.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); 
             }
             else if(equal(__str_AMXX[Client],"Trunks") )
             { 
	           emit_sound( Client, CHAN_ITEM, "xs.trunks/prepunch.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); 
             }
             else if(equal(__str_AMXX[Client],"A18") )
             { 
	           emit_sound( Client, CHAN_ITEM, "xs.androide18/prepunch.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); 
             }
             else if(equal(__str_AMXX[Client],"Gohan") )
             { 
	           emit_sound( Client, CHAN_ITEM, "xs.gohan/prepunch.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); 
             }
             else if(equal(__str_AMXX[Client],"Bardock") )
             { 
	           emit_sound( Client, CHAN_ITEM, "xs.bardock/H3.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); 
             }
          }
}

[lexzor]

PHP Code:

switch(Name[Client][0])
{
    case 'P': client_print( Client, print_center, "Hello Pedrito" );
    case 'A': client_print( Client, print_center, "Hello Alex" );
} 


PHP Code:

new const fxSounds[][] = 
{
    "Freezer",
    "Vegeta",
    "Goku"///so on..
}

new const fxSoundsPath[][] = 
{
    "xs.freezer/prepunch.wav",
    "xs.vegeta/prepunch.wav",
    "xs.goku/prepunch.wav"//so on..
}

public fxSound2( Client )
{     
    for(new i; i < sizeof(fxSounds); i++)
    {
        if(equali(__str_AMXX[CLIENT], fxSounds[i]))
        {
            emit_sound( Client, CHAN_ITEM, fxSoundsPath[i], 1.0, ATTN_NORM, 0, PITCH_NORM ); 
        }
    }
} 


[XSlayer]

Originally Posted by lexzor PHP Code: switch(Name[Client][0]) {     case 'P': client_print( Client, print_center, "Hello Pedrito" );     case 'A': client_print( Client, print_center, "Hello Alex" ); }

mmm i think thats not exactly at all, cause if i have two names with the "P" at first letter like Pedrito and Pablo, it will cause a trouble i think, like "Goku" and "Gohan"

[lexzor]

then you can do this

PHP Code:

client_print( Client, print_center, "Hello %s", Name[Client]); 


i just wanted to show that s the only way to use strings in switch

[XSlayer]

Originally Posted by lexzor PHP Code: switch(Name[Client][0]) {     case 'P': client_print( Client, print_center, "Hello Pedrito" );     case 'A': client_print( Client, print_center, "Hello Alex" ); }  PHP Code: new const fxSounds[][] =  {     "Freezer",     "Vegeta",     "Goku"///so on.. } new const fxSoundsPath[][] =  {     "xs.freezer/prepunch.wav",     "xs.vegeta/prepunch.wav",     "xs.goku/prepunch.wav"//so on.. } public fxSound2( Client ) {          for(new i; i < sizeof(fxSounds); i++)     {         if(equali(__str_AMXX[CLIENT], fxSounds[i]))         {             emit_sound( Client, CHAN_ITEM, fxSoundsPath[i], 1.0, ATTN_NORM, 0, PITCH_NORM );          }     } }

Thanks the second is what that i wanted, thanks!
edit:i still dont know if what of all the options is better to optimize, the first one that i posted, yours second code, or using a switch, if somone knows pls let me know thanks!

[fysiks]

Originally Posted by XSlayer nothing different by the way, i have many classes with strings names, so i have many conditions with if not two like the example, i read that using switchs is better than ifs to optimize the plugin just that public fxSound2( Client ) { if(!is_user_bot(Client)) { if(equal(__str_AMXX[Client],"Freezer")) { emit_sound( Client, CHAN_ITEM, "xs.freezer/prepunch.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); } else if(equal(__str_AMXX[Client],"Vegeta")) { emit_sound( Client, CHAN_ITEM, "xs.vegeta/prepunch.wav", 1.0, ATTN_NORM, 0, PITCH_NORM ); } else if(equal(__str_AMXX[Client],"Goku") ) ...

switch() is more efficient than a bunch of if else if statements for integers. If these string that you're checking for are hard coded in the plugin, you should use an enumeration for them. When you do this, you can get rid of the if else if statements and entirely skip the switch() statement entirely and just use the enumeration variable to grab the sound file string.

Something like this:

PHP Code:

enum CLASSES {
    FREEZER,
    VEGETA,
    GOKU
}

new CLASSES:gPlayerClass[33]
new gSounds[CLASSES][] = {
    "xs.freezer/prepunch.wav",
    "xs.vegeta/prepunch.wav",
    "xs.goku/prepunch.wav"
}

public setPlayerClass(id)
{
    gPlayerClass[id] = FREEZER;
}

public fxSound2(id)
{
    if( !is_user_bot(id) )
    {
        emit_sound(id, CHAN_ITEM, gSounds[gPlayerClass[id]], 1.0, ATTN_NORM, 0, PITCH_NORM);
    }
} 


And even if they are not hard coded, something similar can easily be done.

Originally Posted by lexzor PHP Code: switch(Name[Client][0]) {     case 'P': client_print( Client, print_center, "Hello Pedrito" );     case 'A': client_print( Client, print_center, "Hello Alex" ); }

Absolutely not, completely unreliable.

[XSlayer]

Originally Posted by fysiks switch() is more efficient than a bunch of if else if statements for integers. If these string that you're checking for are hard coded in the plugin, you should use an enumeration for them. When you do this, you can get rid of the if else if statements and entirely skip the switch() statement entirely and just use the enumeration variable to grab the sound file string. Something like this: PHP Code: enum CLASSES {     FREEZER,     VEGETA,     GOKU } new CLASSES:gPlayerClass[33] new gSounds[CLASSES][] = {     "xs.freezer/prepunch.wav",     "xs.vegeta/prepunch.wav",     "xs.goku/prepunch.wav" } public setPlayerClass(id) {     gPlayerClass[id] = FREEZER; } public fxSound2(id) {     if( !is_user_bot(id) )     {         emit_sound(id, CHAN_ITEM, gSounds[gPlayerClass[0]], 1.0, ATTN_NORM, 0, PITCH_NORM);     } }  And even if they are not hard coded, something similar can easily be done. Absolutely not, completely unreliable.

Thanks i understand it a little, a have a few doubts..

PHP Code:

public setPlayerClass(id)
{
    gPlayerClass[id] = FREEZER;
} 


which does this exactly, because I am getting the string or the class name like this:

PHP Code:

public @ClassChange( Client, PreClass, PostClass )
{
          getClassDATAv(getClientCLASS(Client), cxName, __str_AMXX[Client], charsmax( __str_AMXX[] ));
} 


maybe you won't recognize the stock, and why are u setting the playerclass on freezer, and is a public where is not called in ur coded, the @ClassChange is a forward, that is called when a client change a class, so every time u change the class, the strings for the client change.

PHP Code:

public fxSound2(id)
{
    if( !is_user_bot(id) )
    {
        emit_sound(id, CHAN_ITEM, gSounds[gPlayerClass[0]], 1.0, ATTN_NORM, 0, PITCH_NORM);
    }
} 


and finally why the size in gPlayerrClass is 0 ?

[fysiks]

Originally Posted by XSlayer Thanks i understand it a little, a have a few doubts.. PHP Code: public setPlayerClass(id) {     gPlayerClass[id] = FREEZER; }  which does this exactly, because I am getting the string or the class name like this: PHP Code: public @ClassChange( Client, PreClass, PostClass ) {           getClassDATAv(getClientCLASS(Client), cxName, __str_AMXX[Client], charsmax( __str_AMXX[] )); }  maybe you won't recognize the stock, and why are u setting the playerclass on freezer, and is a public where is not called in ur coded, the @ClassChange is a forward, that is called when a client change a class, so every time u change the class, the strings for the client change. PHP Code: public fxSound2(id) {     if( !is_user_bot(id) )     {         emit_sound(id, CHAN_ITEM, gSounds[gPlayerClass[0]], 1.0, ATTN_NORM, 0, PITCH_NORM);     } }  and finally why the size in gPlayerrClass is 0 ?

I was just providing example code, you'd need to take the example and make it work for your use case. This is why I originally asked about your actual goal.

The size of gPlayerClass is not 0, it is 33. When you're using an array, you need to index it (by using the square brackets). I used a 0 just to make sure I could compile it and forgot to change it to "id" when I added more code around it. So, to fix this part, you'd need to change the 0 to id like this: gSounds[gPlayerClass[id]].

To be able to use the enum (or similar) method, you'd need to change all the places that where you need to know the class type to use the enum. When you actually do need the text, you'd have an array similar to gSounds to store the string name. This is more efficient than passing around strings for knowing the player's class.

Since you seem to be very new to scripting, it might be difficult to convert an existing plugin from using a class string to using a class enum without significant help. You're welcome to attach the .sma file in its entirety so that we can see how difficult it may be.