[Gachl]

Thanks to tcviper for approving this plugin.

[Dragonshadow]

Yea sorry Gachl I couldn't/can't get to those achievements, I'm busier than originally thought x_x

[Jindo]

Just to say that some complications have arised with my plugin, but I will do my best to get a functional and usable version of it released as soon as I can .

I'll be testing the new code tomorrow, it should loop through the entire (newly formatted) config and award achievements for each match, so multiple achievements for the same weapons/names/IDs should be possible (IF THIS WORKS, no promises I'm afraid, but I've got high hopes)

[Jindo]

I've now narrowed this plugin down to one small but very major and breaking glitch, when a death event fires, it runs through the for loop multiple times where it should only loop through it once:

PHP Code:

public Action:eCheckFile(Handle:event, const String:name[], bool:noBroadcast)
{
    
    KvRewind(g_achievements);
    
    for (new i = 1; i <= g_maxAchievements; i++)
    {
        PrintToChatAll("i = %i", i); //debugger
        new ply_id = CompareConditions(i, event);
        new ach_id = KvGetInt(g_achievements, "achid");
        KvRewind(g_achievements);
        if (ply_id != 0)
        {
            ProcessAchievement(ach_id, ply_id);
        }
    }
    return Plugin_Continue;
} 


Is there anything there that could be causing this one loop to loop several times? D:

[Xsinthis]

Originally Posted by Jindo I've now narrowed this plugin down to one small but very major and breaking glitch, when a death event fires, it runs through the for loop multiple times where it should only loop through it once:

why loop at all then? Or does this code have to be looped for other parts?

EDIT: I don't know much about sourcepawn, but this looks alot like Java. In your loop, you declare i as 1, test if it is less then or equal to g_maxAchievements, with an increment to i. Where does g_maxAchievements come from?

[Jindo]

Originally Posted by Xsinthis why loop at all then? Or does this code have to be looped for other parts?

The loop is to go through each achievement in the config.

EDIT: I don't know much about sourcepawn, but this looks alot like Java. In your loop, you declare i as 1, test if it is less then or equal to g_maxAchievements, with an increment to i. Where does g_maxAchievements come from?

g_maxAchievements is declared and defined in an earlier code, I've already debugged that part and g_maxAchievements is giving the right number, which is why I moved on to this part.

What should happen is that when someone dies, the code loops through the config file once to check which achievements match the conditions, but for some reason the loop happens multiple times (3-4) after a single death.

[SuperShadow]

Are you sure it's only being called once? You might have a better chance of getting an answer in the scripting section.

[Jindo]

Posted the thread, and just now I managed to fix it, the event was only called once, the problem for some reason was removed by changing some variables which were completely irrelevant to the event hooking...

I'll do some more tests on the plugin and have it uploaded sometime tomorrow, assuming all is well!

Example of the new config's layout:

"killtypes"
{
    "1"
    {
        "achid"                    "1"
        "weapon_eq"                "flaregun"
    }
    "2"
    {
        "achid"                    "2"
        "weapon_eq"                "flaregun"
        "victim_name_con"        "-KJ-"
    }
    "3"
    {
        "killer_name_con"        "Jindo"
        "achid"                    "3"
    }
    "4"
    {
        "killer_id_eq"            "STEAM_0:0:1234"
        "target"                "1"
        "achid"                    "4"
    }
}

[Sexual Harassment Panda]

Wow Thanks jindo, This will make everything much easier for everybody. Huge props to you. I'm excited. +karma

[Jindo]

Good news: the plugin appears to be working 100%, the debugger adjustment shows that I'm getting the right achievements under the right conditions, go me!

I'll rework the plugin to use the Custom Achievements native and upload it for testing + public use, along with a quick read me on what to do with the config file.