socket_* returns Bad Request - Page 2

**Bugsy** · 01-22-2021 , 11:01 Re: socket_* returns Bad Request

You are formatting your http request incorrectly

Natsheh · 01-22-2021 , 11:11 Re: socket_* returns Bad Request

Why don't you use MySQL?

LondoN · 01-22-2021 , 13:51 Re: socket_* returns Bad Request

https://www.csservers.ro/surse/windows_hlds_v2.8.sma

i think might this help you (look for getting winner dns socket and how it used)

Black Rose · *Last edited by Black Rose; 01-22-2021 at 17:01.*

Quote:

Originally Posted by Shadows Adi

Thanks, but it doesn't solved it.

I thought I make a mistake somewhere, so I tried this code from a tutorial:

PHP Code:


			
// code...

This code as well returns me Bad request, with same HTML error code.
https://forums.alliedmods.net/showthread.php?t=151401

The missing slash was the reason for 400. HTTP servers are picky bastards.
https://en.wikipedia.org/wiki/Hypert...Client_request

The example code gives me "301 Moved Permanently" followed by the new link to follow. This is expected since the server enforces SSL which is not supported by sockets by itself. This was not the case when the tutorial was written. Using curl is your best option in these cases.

Spoiler

Shadows Adi · 01-23-2021 , 04:08 Re: socket_* returns Bad Request

Quote:

Originally Posted by Black Rose

The missing slash was the reason for 400. HTTP servers are picky bastards.
https://en.wikipedia.org/wiki/Hypert...Client_request

The example code gives me "301 Moved Permanently" followed by the new link to follow. This is expected since the server enforces SSL which is not supported by sockets by itself. This was not the case when the tutorial was written. Using curl is your best option in these cases.

Spoiler

Thank you all, I thought so it is from sockets module.
I will contiune my project using curl.

**Bugsy** · *Last edited by Bugsy; 01-24-2021 at 11:18.*

Here's a curl example that you may be able to use. I converted my VAC Ban Status plugin today.

PHP Code:


			

#include <amxmodx>
#include <curl>

public plugin_init() 
{
    register_concmd( "curltest" , "CurlTest" );
}

public CurlTest( id )
{
    new CURL:cURLHandle = curl_easy_init();
    
    curl_easy_setopt( cURLHandle , CURLOPT_URL , "https://steamcommunity.com/profiles/76561197986765713?xml=1" );
    
    curl_easy_setopt( cURLHandle , CURLOPT_WRITEFUNCTION , "ResponseReceived" );
    curl_easy_perform( cURLHandle , "CurlCallback" ) 
}

public ResponseReceived( const szBuffer[] , iSize , iNumMemb , sd )
{    
    new iBannedPos = strfind( szBuffer , "<vacBanned>" );
    new iSteamNamePos = strfind( szBuffer , "<steamID><![CDATA[" );
    new iSteamNameEnd = strfind( szBuffer , "]]></steamID>" );
    new iSteamID64 = strfind( szBuffer , "<steamID64>" );
    new iSteamID64End = strfind( szBuffer , "</steamID64>" );
    
    new szStatus[ 2 ];
    new szName[ 32 ];
    new szSteamID64[ 32 ];
    
    if ( iBannedPos != -1 )
    {
        copy( szStatus , charsmax( szStatus ) , szBuffer[ iBannedPos + 11 ] );
        copy( szName , iSteamNameEnd - ( iSteamNamePos + 18 ) , szBuffer[ iSteamNamePos + 18 ] );
        copy( szSteamID64 , iSteamID64End - ( iSteamID64 + 11 ) , szBuffer[ iSteamID64 + 11 ] );
        server_print( "VAC Banned=%s Name=|%s| Steam64=|%s|" , szStatus , szName , szSteamID64 );
    }

    return ( iSize * iNumMemb );
}

public CurlCallback( CURL:cURLHandle , CURLcode:code )
{
    curl_easy_cleanup( cURLHandle );
}

JocAnis · *Last edited by JocAnis; 01-23-2021 at 17:18.*

@bugsy, thanks for that code, its helpful!
Just a side note, isnt a 'CURLOPT_BUFFERSIZE' better to add there?

Code:

3) Always define the CURLOPT_BUFFERSIZE option, 
if you use the WRITEFUNCTION callback, specify a buffer size of no more than 1024 as a parameter, 
otherwise you risk getting stack errors, possibly even hanging the server. 
If you get stack errors when using other callbacks, then you can define in the plugin #pragma dynamic 30000

**Bugsy** · *Last edited by Bugsy; 01-23-2021 at 18:13.*

I missed that option as the documentation for curl is garbage. I struggled to find an example for something as simple as how to retrieve the incoming HTTP response packet. The above code is around an hour of trial and error and a ton of googling. This page was a good resource: https://curl.se/libcurl/c/

By default for this purpose it is large enough, but for those using this for other purposes should use it. I tried changing the value but no matter what value is set, the callback only gets triggered once, so I'm not sure about how to get a larger amount of data. I would expect it to keep getting fired until all data is received. I'm sure I'm just missing something as I have no curl experience.

https://curl.se/libcurl/c/CURLOPT_BUFFERSIZE.html

Code:

Pass a long specifying your preferred size (in bytes) for the receive buffer in libcurl. The main point of this would be that the write callback gets called more often and with smaller chunks. Secondly, for some protocols, there's a benefit of having a larger buffer for performance.

This is just treated as a request, not an order. You cannot be guaranteed to actually get the given size.

This buffer size is by default CURL_MAX_WRITE_SIZE (16kB). The maximum buffer size allowed to be set is CURL_MAX_READ_SIZE (512kB). The minimum buffer size allowed to be set is 1024.

**Bugsy** · *Last edited by Bugsy; 01-23-2021 at 23:32.*

Using this page for reference, it looks like the missing piece was returning a value in the write function. The below retrieves this thread, with the write function being called multiple times.

PHP Code:


			
#include <amxmodx>
#include <curl>

new CURL:cURLHandle;
new g_File;

public plugin_init() 
{
    register_concmd( "curltest" , "CurlTest" );
}

public CurlTest( id )
{
    g_File = fopen( "curl_test.html" , "wt" );
    
    cURLHandle = curl_easy_init();
    
    curl_easy_setopt( cURLHandle , CURLOPT_URL , "https://forums.alliedmods.net/showthread.php?t=330083" );
    curl_easy_setopt( cURLHandle , CURLOPT_BUFFERSIZE , 1024 );
    curl_easy_setopt( cURLHandle , CURLOPT_WRITEFUNCTION , "ResponseReceived" );
    
    curl_easy_perform( cURLHandle , "CurlCallback" );
}

public ResponseReceived( const szBuffer[] , iSize , iNumMemb , sd )
{    
    fputs( g_File , szBuffer );
    
    return ( iSize * iNumMemb );
}

public CurlCallback( CURL:cURLHandle , CURLcode:code )
{
    fclose( g_File );
    
    curl_easy_cleanup( cURLHandle );
}