[Atreus]

This is cool and I really like the !aka feature

[Atreus]

The !aka features seems broken. It only returns values for youreslf, no matter what you enter.

[mardur]

The author seems to be inactive since 2007. You may take at look at:
http://forums.alliedmods.net/showthread.php?t=39755
But that is a MM Source Plugin that needs to be installed. It is not just a SourcePawn file.

However, I intend to update this plugin and fix/add some things. First of all, the plugin is vulnerable to SQL injection, as it passes all usernames and steamids to the database without escaping (especially dangerous with the argument of the !last command which every player can use. Note for myself: one should escape the following characters \,",',\r,\n,\0,%,_, at least \ and ' need to be escaped). As already requested, an option to allow only admins to make any requests would be nice (e.g. for our war server). I could also port some other features (delay to avoid spamming, showtimes, keepnames to make the database not grow to infinity) of the above mentioned plugin.

edit: I found the cause for the broken aka feature. The aka-handler explicitely searches the database for names corresponding to the steamid of the calling user (ignoring the argument of !aka). Additionally, the function uses FindTarget without loading the phrases translations (as mentioned in the API), the result however is never used.

[shustas]

Originally Posted by mardur The author seems to be inactive since 2007. You may take at look at: http://forums.alliedmods.net/showthread.php?t=39755 But that is a MM Source Plugin that needs to be installed. It is not just a SourcePawn file. However, I intend to update this plugin and fix/add some things. First of all, the plugin is vulnerable to SQL injection, as it passes all usernames and steamids to the database without escaping (especially dangerous with the argument of the !last command which every player can use. Note for myself: one should escape the following characters \,",',\r,\n,\0,%,_, at least \ and ' need to be escaped). As already requested, an option to allow only admins to make any requests would be nice (e.g. for our war server). I could also port some other features (delay to avoid spamming, showtimes, keepnames to make the database not grow to infinity) of the above mentioned plugin. edit: I found the cause for the broken aka feature. The aka-handler explicitely searches the database for names corresponding to the steamid of the calling user (ignoring the argument of !aka). Additionally, the function uses FindTarget without loading the phrases translations (as mentioned in the API), the result however is never used.

So can we expect a fix?

[oneshot23]

Hey great plugin. I have some ideas for you...

You should add this cvar:
lch_names (max names per player to be saved)

You could also make it a menu. Like when you type !admin (menu pops up) have like an added section where it goes into Last Connected. When you press a player it will post in console or say what their names are and steam id. This i think could be a nice feature to add in.

[Bittersweet92101]

Originally Posted by Atreus The !aka features seems broken. It only returns values for youreslf, no matter what you enter.

You can, but some of the code is depracated. In public Action:CommandAKA(client, args), see

GetClientAuthString(client, steamId, sizeof(steamId));

GetClientAuthString is depracated, use GetClientAuthId. target should be passed where client originally was.

GetClientAuthId(target, AuthId_Steam2, steamId, sizeof(steamId))

[Bittersweet92101]

Originally Posted by bug Could this be changed to work for admins only?

In public OnPluginStart(), replace RegConsoleCmd("sm_last", CommandLastConnect);

with RegAdminCmd("sm_last", CommandLastConnect, ADMFLAG_GENERIC).

You can use whatever admin flags you want instead of ADMFLAG_GENERIC, see admins.inc for the options.

Do the same for RegConsoleCmd("sm_aka", CommandAKA);