[Destine]

Hello there everyone, I just getting into Sourcemod scripting so I apologize for my lack of knowledge. I've been trying to execute a function every 50 seconds that makes the player say "test" but the function never gets executed.

This is my code:

PHP Code:

public OnPluginStart() 
{ 
        HookEvent("player_spawned", OnSpawn); 
} 
  
public Action:OnSpawn(Handle:event, const String:name[], bool:dontBroadcast) 
{ 
        new client = GetClientOfUserId(GetEventInt(event, "userid"));
        while(true)
        {
            CreateTimer(50.0, Timer_Test, client);
        }
}

public Action:Timer_Test(Handle:timer, any:client)
{
        FakeClientCommandEx(client, "say test");
} 


Any ideas on how to fix this?

[xines]

Like this?

PHP Code:

public void OnPluginStart()
{
    HookEvent("player_spawn", OnSpawn);
}

public Action OnSpawn(Event event, const char[] name, bool dontBroadcast)
{
    int client = GetClientOfUserId(GetEventInt(event, "userid"));
    CreateTimer(50.0, Timer_Test, client, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
}

public Action Timer_Test(Handle timer, any client)
{
    if(IsClientInGame(i))
    {
        FakeClientCommandEx(client, "say test");
    }
    
    return Plugin_Continue;
} 


[WildCard65]

Note: NEVER PASS A RAW CLIENT INDEX TO A TIMER.

PHP Code:

public void OnClientPutInServer(int client)
{
    CreateTimer(50.0, Timer_Test, GetClientUserId(client), TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
}

public void OnMapStart()
{
    for (int i = 1; i <= MaxClients; ++i)
    {
        if (IsClientInGame(i))
            CreateTimer(50.0, Timer_Test, GetClientUserId(i), TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
    }
}

public Action Timer_Test(Handle timer, any data)
{
    int client = GetClientOfUserId(data);

    if (!IsClientInGame(client))
        return Plugin_Stop;

    FakeClientCommandEx(client, "say test");
    return Plugin_Continue;
} 


[Destine]

Originally Posted by xines Like this? PHP Code: public void OnPluginStart() {     HookEvent("player_spawn", OnSpawn); } public Action OnSpawn(Event event, const char[] name, bool dontBroadcast) {     int client = GetClientOfUserId(GetEventInt(event, "userid"));     CreateTimer(50.0, Timer_Test, client, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE); } public Action Timer_Test(Handle timer, any client) {     if(IsClientInGame(i))     {         FakeClientCommandEx(client, "say test");     }          return Plugin_Continue; }

Unidentified variable i, I'm guessing thats client?

[WildCard65]

Originally Posted by Destine Unidentified variable i, I'm guessing thats client?

Ya, but it's a bad idea to pass raw client indexes to timers as it may not be the same client when timer fires.

Edit: Update code I posted in reply #3

[xines]

Originally Posted by WildCard65 Note: NEVER PASS A RAW CLIENT INDEX TO A TIMER.

True, i'm posting to fast what can i say lol

[Destine]

Originally Posted by WildCard65 Ya, but it's a bad idea to pass raw client indexes to timers as it may not be the same client when timer fires. Edit: Update code I posted in reply #3

Quick question, what would I set my HookEvent to? Like which function?

[WildCard65]

Originally Posted by Destine Quick question, what would I set my HookEvent to? Like which function?

The code I posted removed the hooking of player_spawn event as that would end up causing multiple timers to be create and none existing ones being killed which would result in multiple triggers of FakeClientCommandEx on the same client.

[Destine]

Originally Posted by WildCard65 The code I posted removed the hooking of player_spawn event as that would end up causing multiple timers to be create and none existing ones being killed which would result in multiple triggers of FakeClientCommandEx on the same client.

So what do I put into my OnPluginStart() function?

[xines]

Originally Posted by Destine So what do I put into my OnPluginStart() function?

Its not needed for the plugin to function.