[quark]

noone comment my joke

[Jhob94]

Originally Posted by Mauricio Frb Look you only need to create a new function like Send_Message() when you use it 3 times ou more. Remove this public and put in Messages_Audio.

Its the same to have in messages_audio or as it is. I just make like that for dont be together and be better to read

EDIT: (Off-Topic)

Originally Posted by quark noone comment my joke

Your joke or your spam?

[quark]

Originally Posted by Jhob94 Your joke or your spam?

That's what i said

[Jhob94]

You feeling happy for spaming as a noob?
Your join date is Oct 2011 but it looks like people that joined 2days ago have an better behavior then you...

[quark]

[ConnorMcLeod]

Have you used some code from me ?

[Jhob94]

No?

[guipatinador]

From Furien plugin !

[Jhob94]

Originally Posted by guipatinador From Furien plugin !

hum nope?

PHP Code:

T_WON = false // Turning It False
        CT_WON = false // Turning It False
        
        new Audio[14]
        get_msg_arg_string(2, Audio, charsmax(Audio)) // For check next if terro or ct
        
        if(equal(Audio, T_SOUND)) // T
            T_WON = true
        
        else if(equal(Audio, CT_SOUND)) // CT
            CT_WON = true
        
        else
            return // I dont want to check others cases, only if CT or T

        if(get_msg_block(Text_Msg) == BLOCK_NOT)
            set_msg_block(Text_Msg, BLOCK_ONCE) // Block game message
        
        Send_Message()    // Send Messages 


hum your furien plugin is like that too?

[ConnorMcLeod]

Originally Posted by ConnorMcLeod Have you used some code from me ?

Originally Posted by Jhob94 No?

Originally Posted by guipatinador From Furien plugin !

ROFL, indeed.

PHP Code:

        new szSound[14]
        get_msg_arg_string(2, szSound, charsmax(szSound))
        if( equal(szSound, "%!MRAD_ctwin") ) 


Same array size, weird ?
May be you could explain why you have chosen 14 as array size then ?

PHP Code:

        if( get_msg_block(g_iTextMsg) == BLOCK_NOT )
        {
            set_msg_block(g_iTextMsg, BLOCK_ONCE)
        } 


Same method.

Anyway, i don't care, i asked, you said no, that's fine.


About code :

PHP Code:

#define T_SOUND "%!MRAD_terwin" // Dont Change It In Any Case Or Plugin Wont Work
#define CT_SOUND "%!MRAD_ctwin" // Dont Change It In Any Case Or Plugin Wont Work 


This doesn't need to be a define, you can put it directly in code, i mean, there is no bad effect to put it as define, but there is no benefits.

PHP Code:

new bool:T_WON, bool:CT_WON 


You don't need those variables, just pass it as argument to Send_Message() function.
->

PHP Code:

Send_Message(TEAM_CT) 


Also, Send_Message() function should be private, and since it is only used at one place, it should be integrated to Messages_Audio() function, both functions are not big, and Send_Message is not called in a sbu block, so it wouldn't alter readability.

You may also use a Trie instead of using twice equal, you would retrieve Winning Team as Cell Result :

PHP Code:

    g_tWinMessage = TrieCreate();
    TrieSetCell(g_tWinMessage, "%!MRAD_terwin", 1);
    TrieSetCell(g_tWinMessage, "%!MRAD_ctwin", 2); 


PHP Code:

new Audio[14]
        get_msg_arg_string(2, Audio, charsmax(Audio))
        if( TrieGetCell(g_tWinMessage, Audio, WinningTeam) )
        {
            Send_Message(WinningTeam) // pass 1 or 2, 1 for Ts, 2 for CTs
            if(get_msg_block(Text_Msg) == BLOCK_NOT)
                set_msg_block(Text_Msg, BLOCK_ONCE)
            return PLUGIN_HANDLED
        }