[rogeraabbccdd]

Which is better?
I always use 1 in my plugins.

1.

Spoiler

PHP Code:

public void OnPluginStart() 
{
    CreateConVar("sm_my_cvar", "1", "My Cvar", FCVAR_NOTIFY, true, 0.0, true, 1.0);
}

if(GetConVarBool(FindConVar("sm_my_cvar"))) do_something; 


and

2.

Spoiler

PHP Code:

ConVar Cvar_mycvar;
bool b_cvar;
public void OnPluginStart() 
{
    Cvar_mycvar = CreateConVar("sm_my_cvar", "1", "My Cvar", FCVAR_NOTIFY, true, 0.0, true, 1.0);
    Cvar_mycvar.AddChangeHook(OnCvarChange);
}

public void OnCvarChange(ConVar convar, char[] oldValue, char[] newValue)
{
    if (convar == Cvar_mycvar)
    {
        b_cvar = GetConVarBool(Cvar_mycvar);
    }
}

if(b_cvar) do_something; 


[Timocop]

2.

[ESK0]

Please do not public your plugins 2

[rogeraabbccdd]

LOL, I think it's time to rewrite all my shit.
Thank you guys.

[hmmmmm]

I doubt it makes that much of a difference, but if you're calling it really often second *might* be better. Also you should use new syntax by doing cvar.BoolValue instead of GetConVarBool(cvar)

[rogeraabbccdd]

Originally Posted by hmmmmm I doubt it makes that much of a difference, but if you're calling it really often second *might* be better. Also you should use new syntax by doing cvar.BoolValue instead of GetConVarBool(cvar)

You're right.
I know I can use cvar.BoolValue, these are just quick samples to show my question.

[Powerlord]

It depends on what you're doing. But yeah, if you want to do something as soon as a cvar changes, use 2.

[Franc1sco]

2.

I always do it when I want to do it optimized as you should already have saw it here.

Also I saw that you use entity index on timers instead of ref. That is unsafe since the index are constantly changing so you should get entity ref for timers instead of directly the index, like here.

[rogeraabbccdd]

Wiki needs an update to help more people.
https://wiki.alliedmods.net/Optimizi...Mod_Scripting)