[jediZEr0]

Yes I know that . I just don't know how to work with arrays. Your tutorial confused me a bit: I retrieved some random IDs but where are them? cs_set_user_team(index, CS_TEAM_CT). Where is "index"?

[Bugsy]

This will only return a player that has not yet been selected. Once all players have been selected you must call ResetPlayers() to be able to select players again; you could modify the code to make it automatically reset selected players when all players have been selected. If you are unsure how to do this just ask.

PHP Code:

new g_Selected;
new g_MaxPlayers;

g_MaxPlayers = get_maxplayers();

public client_disconnect(id)
{
    g_Selected &= ~( 1 << (id-1) ) )
}

ResetSelected()
{
    g_Selected = 0;
}

GetRandomPlayer()
{
    new iPlayerBits;
    new i;
    
    //Make a bitsum of connected player indexes. 
    //You can add additional checks here (bot,team,admin, etc).
    for ( i = 1 ; i <= g_MaxPlayers ; i++ )
        if ( is_user_connected( i ) )
            iPlayerBits |= ( 1 << ( i - 1 ) );
    
    //No players are connected.
    if ( !iPlayerBits )
        return 0;

    //Keep looping until there is no players that haven't been selected.
    while( iPlayerBits != g_Selected )
    {
        //Get random player id
        i = ( random_num( 1 , g_MaxPlayers ) - 1 );
        
        //If player is connected and has not yet been selected
        if ( ( iPlayerBits & ( 1 << i ) ) && !( g_Selected & ( 1 << i ) ) )
        {
            //Set bit in g_Selected bit-field so they will be ignored on the next call
            g_Selected |= ( 1 << i );
            return ( i + 1 );
        }
    }
    
    //All players have already been selected.
    return 0;
} 


[joaquimandrade]

Originally Posted by Bugsy This will only return a player that has not yet been selected. Once all players have been selected you must call ResetPlayers() to be able to select players again; you could modify the code to make it automatically reset selected players when all players have been selected. If you are unsure how to do this just ask. PHP Code: new g_Selected; new g_MaxPlayers; g_MaxPlayers = get_maxplayers(); ResetSelected() {     g_Selected = 0; } GetRandomPlayer() {     new iPlayerBits;     new i;          //Make a bitsum of connected player indexes.      //You can add additional checks here (bot,team,admin, etc).     for ( i = 1 ; i <= g_MaxPlayers ; i++ )         if ( is_user_connected( i ) )             iPlayerBits |= ( 1 << ( i - 1 ) );          //No players are connected.     if ( !iPlayerBits )         return 0;     //Keep looping until there is no players that haven't been selected.     while( iPlayerBits != g_Selected )     {         //Get random player id         i = ( random_num( 1 , g_MaxPlayers ) - 1 );                  //If player is connected and has not yet been selected         if ( ( iPlayerBits & ( 1 << i ) ) && !( g_Selected & ( 1 << i ) ) )         {             //Set bit in g_Selected bit-field so they will be ignored on the next call             g_Selected |= ( 1 << i );             return ( i + 1 );         }     }          //All players have already been selected.     return 0; }

If one or more selected players get disconnected and there is one or more connected player, all already selected, the loop will be infinite.

[Bugsy]

Fixed, maybe.

[joaquimandrade]

Originally Posted by Bugsy Fixed, maybe.

Yes. How I would implement the final part:

PHP Code:

new g_Selected;
new g_MaxPlayers;

g_MaxPlayers = get_maxplayers();

public client_disconnect(id)
{
    g_Selected &= ~( 1 << (id-1) ) )
}

GetRandomPlayer()
{
    new iPlayerBits;
    new i;
    
    //Make a bitsum of connected player indexes. 
    //You can add additional checks here (bot,team,admin, etc).
    for ( i = 1 ; i <= g_MaxPlayers ; i++ )
        if ( is_user_connected( i ) )
            iPlayerBits |= ( 1 << ( i - 1 ) );
    
    //No players are connected.
    if ( !iPlayerBits )
        return 0;
    else if( iPlayerBits == g_Selected )
        g_Selected = 0

    //Keep looping until there is no players that haven't been selected.
    do
    {
        //Get random player id
        i = ( random_num( 1 , g_MaxPlayers ) - 1 );
        
        //If player is connected and has not yet been selected
        if ( ( iPlayerBits & ( 1 << i ) ) && !( g_Selected & ( 1 << i ) ) )
        {
            //Set bit in g_Selected bit-field so they will be ignored on the next call
            g_Selected |= ( 1 << i );
            return ( i + 1 );
        }
    }
    while(true)
    
    //All players have already been selected.
    return 0;
} 


or

PHP Code:


new g_MaxPlayers;
new g_iPlayerBits
new g_Selected

public plugin_cfg()
{
     g_MaxPlayers = get_maxplayers();
}

public client_connect(id)
{
    g_iPlayerBits |= ( 1 << (id - 1) );
}
public client_disconnect(id)
{
    g_iPlayerBits &= ~( 1 << (id-1) ) )
    g_Selected &= ~( 1 << (id-1) ) )
}

GetRandomPlayer()
{
    //At least, one player is connected.
    if (iPlayerBits)
    {
        if( iPlayerBits == g_Selected )
           g_Selected = 0

        new i;

        //Keep looping until there is no players that haven't been selected.
        do
        {
            //Get random player id
            i = ( random_num( 1 , g_MaxPlayers ) - 1 );
        
            //If player is connected and has not yet been selected
            if ( ( iPlayerBits & ( 1 << i ) ) && !( g_Selected & ( 1 << i ) ) )
            {
                //Set bit in g_Selected bit-field so they will be ignored on the next call
                g_Selected |= ( 1 << i );
                return ( i + 1 );
            }
        }
        while(true)
    }    
    //All players have already been selected.
    return 0;
} 


[jediZEr0]

Originally Posted by joaquimandrade PHP Code:         //Get random player id         i = ( random_num( 1 , g_MaxPlayers ) - 1 );

So it's going to be cs_set_user_team(i, CS_TEAM_CT) ?

[joaquimandrade]

Originally Posted by jediZEr0 So it's going to be cs_set_user_team(i, CS_TEAM_CT) ?

You would have to use something like this in your code:

PHP Code:

new player = GetRandomPlayer()

if(player)
{
    cs_set_user_team(player,CS_TEAM_CT)
} 


[Exolent[jNr]]

Updated with the "better looking" loop and more efficient way of removing the random index.
Added the Sort*() function from AMXX as shown by P34nut and arkshine.
Added 2 examples of retrieving random players.

[Bugsy]

@joa

I left the resetting of already selected players up to the user because some may only want to issue a command on a set of players (on a random basis) once; they can then reset selected-players manually if they would like to again issue commands on a random basis. Automatically resetting will always return a player even if the player has already been selected once prior.

[joaquimandrade]

Originally Posted by Bugsy @joa I left the resetting of already selected players up to the user because some may only want to issue a command on a set of players (on a random basis) once; they can then reset selected-players manually if they would like to again issue commands on a random basis. Automatically resetting will always return a player even if the player has already been selected once prior.

Automatic resetting will just return an already selected player if there are no more players to select so, i'm not seeing what would be the difference.