[pcquad]

Following code should only show the average ping ( Sum of all pings / playercount )
but it just shows some strange charsequence (e.g. the average Server ping is: Y?}BY?*********D******************C)
could anyone help me?

#pragma semicolon 1

#include <sourcemod>

#define PLUGIN_VERSION "1.4"

// Plugin info
public Plugin:myinfo = 
{
	name = "Get average Ping",
	author = "pcquad",
	description = "Simple average ping collect",
	version = PLUGIN_VERSION,
	url = "http://pcquad.de"
};

// Here we go!
public OnPluginStart()
{
 RegServerCmd("getpings", getpings);
}

// Check the ping!
public Action:getpings(args)
{



	new Float:Ping;
	new Float:Pinga;
	new Float:Pingaverage;
	// Admin flag immunity

	

	// First, let's get a count of the players in-game.
	new Players = 0;
	for (new i = 1; i <= MaxClients; i++)
	{
		if (IsClientConnected(i) && IsClientInGame(i) && !IsFakeClient(i))
			Players++;
	}

	// Perform the actual ping checking and warn issuing.
	for (new i = 1; i <= MaxClients; i++)
	{
		if (IsClientConnected(i) && IsClientInGame(i) && !IsFakeClient(i))
		{


			//GetClientAuthString(i, SteamID, sizeof(SteamID));
			//GetClientName(i, Name, sizeof(Name));

			Ping = GetClientAvgLatency(i, NetFlow_Outgoing) * 1024;
			Pinga = Pinga + Ping;


		}

	}
     Pingaverage = Pinga / MaxClients;

PrintToChatAll("the average Server ping is: %s", Pingaverage);
        Pingaverage = 0;
        Ping = 0;
        Pinga = 0;
return Plugin_Handled;
}

[Bimbo1]

put %f in the place of %s,[since it's a float, not a string] divide Pinga by Players[, which is the player count] and you don't need to perform two loops. you can do the player count and get pings at the same loop. also, you don't to set everything to zero, once finished the code.

[Afronanny]

You'll want to change this line:

PHP Code:

Pingaverage = Pinga / MaxClients; 


The average would be not Pinga divided by MaxClients, but Pinga divided by the number of in-game players.

[Bimbo1]

Originally Posted by Afronanny You'll want to change this line: PHP Code: Pingaverage = Pinga / MaxClients;  The average would be not Pinga divided by MaxClients, but Pinga divided by the number of in-game players.

yeah, he/she did the calc for the number of in-game players:

new Players = 0; 	for (new i = 1; i <= MaxClients; i++) 	{ 		if (IsClientConnected(i) && IsClientInGame(i) && !IsFakeClient(i)) 			Players++; 	}

he/she didn't use it, though.

[berni]

Also keep in mind, that the ping displayed in the player's scoreboard, is not the same ping you get from GetClientAvgLatency.

[pcquad]

thanks guys

Originally Posted by berni Also keep in mind, that the ping displayed in the player's scoreboard, is not the same ping you get from GetClientAvgLatency.

could you explain that ?

[berni]

well, have you ever compared the ping from the scoreboard with that you get from GetClientAvgLatency ? It's not the same.

Valve uses some weird formula to calculate a corrected ping.
You can find more details in this function which is a clone of the HL2 SDK code.

[pcquad]

Originally Posted by berni well, have you ever compared the ping from the scoreboard with that you get from GetClientAvgLatency ? It's not the same. Valve uses some weird formula to calculate a corrected ping. You can find more details in this function which is a clone of the HL2 SDK code.

now what is the more exact algorithm is that known?

[berni]

I think there are multiple definitions what a ping or latency actually is in relation with gameservers.

I think the value displayed in the scoreboard is an attempt of the source makers to somewhat give the player a pretty and good-looking value, but I doubt that it is the real physical value.

But since players only know this value, I would just use this value retrieved from Client_GetFakePing for your scripting, anything else will probably confuse the players.
I can't tell tho if Valve changed anything in that formula for CS:GO or in some updates, you have to try it out, but I don't think so.