[AnubisTF2]

I'm trying to write a plugin where when the player attacks, it will deal damage in a radius around the player, but I haven't had any luck. Here's what I've got:

public Action:TF2_CalcIsAttackCritical(client, weapon, String:weaponname[], &bool:isCrit)
{
	g_fRadius = 600.0;
	g_fDamage = 100.0;
	
	decl Float:origin[3];
	GetClientAbsOrigin(client, origin);
	
    if(1.00 > GetRandomFloat(0.0, 1.0) && GetClientTeam(client) == BossTeam)
    {
        isCrit = true;
		
		DamageArea(origin, g_fRadius, g_fDamage, client, client, GetClientTeam(client), DMG_GENERIC, -1, NULL_VECTOR);
    }
    return Plugin_Continue;
}

stock DamageArea(Float:origin[3], Float:distance = 500.0, Float:damage = 500.0, &attacker, &inflictor, int team = 0, damagetype, int weapon = -1, Float:damageforce[3] = NULL_VECTOR)
{
    if (distance <= 0.0 || damage <= 0.0)
        return;

    float vecOrigin[3];
    for (int i = 1; i <= MaxClients; i++)
    {
        if (!IsClientInGame(i) || !IsPlayerAlive(i) || (team > 0 && team != GetClientTeam(i)) || (attacker > 0 && i == attacker))
            continue;

        GetClientAbsOrigin(i, vecOrigin);

        if (GetVectorDistance(origin, vecOrigin) > distance)
            continue;

        SDKHooks_TakeDamage(i, inflictor, attacker, damage, damagetype, weapon, damageforce, origin);
    }

    int entity = -1;
    while ((entity = FindEntityByClassname(entity, "*")) != -1)
    {
        if (!HasEntProp(entity, Prop_Send, "m_vecOrigin") || attacker > 0 && attacker == entity)
            continue;

        GetEntPropVector(entity, Prop_Send, "m_vecOrigin", vecOrigin);

        if (GetVectorDistance(origin, vecOrigin) > distance)
            continue;

        SDKHooks_TakeDamage(entity, inflictor, attacker, damage, damagetype, weapon, damageforce, origin);
    }
}

Would really appreciate all the help I can get, thanks!

[8guawong]

team != GetClientTeam(i)

Unless what you want is to deal damage to teammates I think the above is what is wrong?

[AnubisTF2]

Originally Posted by 8guawong team != GetClientTeam(i) Unless what you want is to deal damage to teammates I think the above is what is wrong?

hm still doesn't work
compiles fine, but nothing happens in game.
the crit part works however, just not the radius damage part

[8guawong]

Originally Posted by AnubisTF2 hm still doesn't work compiles fine, but nothing happens in game. the crit part works however, just not the radius damage part

in that case you should do some debugging and see what part of the code is not working as expected

[AnubisTF2]

Originally Posted by 8guawong in that case you should do some debugging and see what part of the code is not working as expected

ive tried quite a bit of debugging, but no luck.
im pretty bad with SP, so thats why I came here to ask for some help

[Starbish]

PHP Code:

team > 0 && team != GetClientTeam(i) 


I think this is what you've mistaken.

Is this code intended to deal damage around your teammate?

You can find which statement makes something filtered.

I think That's what he mentioned 'debugging'.

[AnubisTF2]

so another problem has risen
the point of the plugin, deal damage in a certain area on attack, works
however, every time you attack, it does 1 damage, sometimes 2 damage, and the radius is a lot larger than the value set. it's unusual, since the damage is set to 125, and the range is set to 400
https://pastebin.com/raw/kX5ERjpP
any ideas on why this occurs?

[Whai]

Originally Posted by AnubisTF2 so another problem has risen the point of the plugin, deal damage in a certain area on attack, works however, every time you attack, it does 1 damage, sometimes 2 damage, and the radius is a lot larger than the value set. it's unusual, since the damage is set to 125, and the range is set to 400 https://pastebin.com/raw/kX5ERjpP any ideas on why this occurs?

From sdkhooks.inc :

native void SDKHooks_TakeDamage(int entity, int inflictor, int attacker,
		float damage, int damageType=DMG_GENERIC, int weapon=-1,
		const float damageForce[3]=NULL_VECTOR, const float damagePosition[3]=NULL_VECTOR);

You skipped damageForce, You should try this :

SDKHooks_TakeDamage(entity, inflictor, attacker, damage, damagetype, weapon, _, origin);