[condolent]

I'm stuck on something here..

I'm making a plugin for my server where VIP's automatically gets a ✪ before their name.
I realized it needs to be on a repeatable timer that checks whether or not they actually got their names changed by the plugin.

So I made this:

PHP Code:

public void SetName(int client) {
    if(CheckCommandAccess(client, "", ADMFLAG_RESERVATION, true)) {
        char orig_name[MAX_NAME_LENGTH];
        char newName[MAX_NAME_LENGTH];
        
        GetClientName(client, orig_name, sizeof(orig_name));
        Format(newName, sizeof(newName), "✪ %s", orig_name);
        
        if(!StrEqual(orig_name, newName)) {
            SetClientName(client, newName);
        }
    }
} 


And with the latter if-statement I thought it wouldn't change the names if they already had the star in their name. That didn't work, it just repeats each one second that the timer is set to and gives one more star each second.

How can I change it so it only applies the newName variable if they don't have a star before?
Is it possible to check if a variable contains a character?

EDIT
Found that string.inc had StrContains(), so I did this:

PHP Code:

public void SetName(int client) {
    if(CheckCommandAccess(client, "", ADMFLAG_RESERVATION, true)) {
        char curName[MAX_NAME_LENGTH];
        char newName[MAX_NAME_LENGTH];
        
        GetClientName(client, curName, sizeof(curName));
        Format(newName, sizeof(newName), "✪ %s", curName);
        
        if(!StrContains(curName, "✪", false)) {
            SetClientName(client, newName);
        }
    }
} 


But that never actually seems to update the name..

[stephen473]

Have you tried StrContains ?

[condolent]

Originally Posted by stephen473 Have you tried StrContains ?

Updated the OP the second before your answer xd

[stephen473]

I can fix it maybe tomorrow

[condolent]

Originally Posted by stephen473 So the problem solved?

Nah, it never actually changes the name now! I added the code with StrContains() in the main post

[condolent]

I'm stupid, realized that StrContains never returns true or false... xD

PHP Code:

if(StrContains(curName, "✪", false) != -1) {
    GetClientName(client, curName, sizeof(curName));
    Format(newName, sizeof(newName), "✪ %s", curName);
    
    SetClientName(client, newName);
} 


Still doesn't work tho :/

[Papero]

StrContains isn't a bool, you should do something like this

PHP Code:

StrContains (...) == 0; // is the first character
StrContains (...) != 1; //it contains it in any position 


Edit: I think I'm total wrong, !... Is ok

[stephen473]

https://forums.alliedmods.net/showthread.php?t=186346

You can take some help from this plugin

[condolent]

Originally Posted by Papero StrContains isn't a bool, you should do something like this PHP Code: StrContains (...) == 0; // is the first character StrContains (...) != 1; //it contains it in any position

I see, then this should work am I right?

PHP Code:

if(StrContains(curName, "✪", false) == -1) {
            GetClientName(client, curName, sizeof(curName));
            Format(newName, sizeof(newName), "✪ %s", curName);
            
            SetClientName(client, newName);
        } 


But that still repeats and adds a new one.

EDIT
Obviously put the GetClientName in the wrong place after trying to sort the method out lol..

This is what I ended up with:

PHP Code:

public void SetName(int client) {
    if(CheckCommandAccess(client, "", ADMFLAG_RESERVATION, true)) {
        char curName[MAX_NAME_LENGTH];
        char newName[MAX_NAME_LENGTH];
        
        GetClientName(client, curName, sizeof(curName));
        
        if(StrContains(curName, "✪", false) == -1) {
            Format(newName, sizeof(newName), "✪ %s", curName);
            
            SetClientName(client, newName);
        }
    }
} 


And it finally works!

Thanks for all the help

[stephen473]

You're welcome