[Forgetest]

Mostly it is intuitive that post-hooks don't get fired if functions are completely skipped, though guess there's still a need for it. Perhaps it's better to reach for the DHooks authors, as I do remember the invalid index error had never happened until some updates.
Yet this one isn't quite breaking for scripting, except some really redundant-like checks need to be in post-hooks (checking "m_isGhost" in OnEnterGhostState )

[eyal282]

Originally Posted by Silvers Ahh I see "L4D2_OnPlayerFling" line was missing to detect it. Thanks. Post hooks will always fire as that's the end of the function being detoured. Will set some indexes to 0 or -1 where applicable, hopefully those can be checked in post to validate it's not being blocked. Was possibly thinking of setting a flag if a pre hook is blocked so the post would never fire. Thoughts?

The only reason any developer want a post is for successful flings. It would be a lie to fire L4D2_OnPlayerFlingPost if the player wasn't flung after the checker. This should mimic Sourcemod's SDKHooks because otherwise it creates confusion for no reason.

[LordVGames]

Getting an error on the latest left4dhooks when trying to use L4D_IsAnySurvivorInStartArea(). A similar error also happens when using L4D_HasAnySurvivorLeftSafeArea().

L 03/28/2022 - 02:24:27: [SM] Exception reported: g_pDirector not available ().
L 03/28/2022 - 02:24:27: [SM] Blaming: left4dhooks.smx
L 03/28/2022 - 02:24:27: [SM] Call stack trace:
L 03/28/2022 - 02:24:27: [SM]   [0] ThrowNativeError
L 03/28/2022 - 02:24:27: [SM]   [1] Line 5394, C:\Servers\L4D2\left4dead2\addons\sourcemod\scripting\left4dhooks.sp::ValidateAddress
L 03/28/2022 - 02:24:27: [SM]   [2] Line 6131, C:\Servers\L4D2\left4dead2\addons\sourcemod\scripting\left4dhooks.sp::Native_CDirector_IsAnySurvivorInStartArea
L 03/28/2022 - 02:24:27: [SM]   [4] L4D_IsAnySurvivorInStartArea
L 03/28/2022 - 02:24:27: [SM]   [5] Line 172, f:\Stuff\EVERYTHING ELSE\Left 4 Dead 2 Dedicated Servers\left4dead2\addons\sourcemod\scripting\all4dead2.sp::OnPluginStart

[Silvers]

Originally Posted by LordVGames Getting an error on the latest left4dhooks when trying to use L4D_IsAnySurvivorInStartArea(). A similar error also happens when using L4D_HasAnySurvivorLeftSafeArea(). L 03/28/2022 - 02:24:27: [SM] Exception reported: g_pDirector not available (). L 03/28/2022 - 02:24:27: [SM] Blaming: left4dhooks.smx L 03/28/2022 - 02:24:27: [SM] Call stack trace: L 03/28/2022 - 02:24:27: [SM] [0] ThrowNativeError L 03/28/2022 - 02:24:27: [SM] [1] Line 5394, C:\Servers\L4D2\left4dead2\addons\sourcemod\scripting\left4dhooks.sp::ValidateAddress L 03/28/2022 - 02:24:27: [SM] [2] Line 6131, C:\Servers\L4D2\left4dead2\addons\sourcemod\scripting\left4dhooks.sp::Native_CDirector_IsAnySurvivorInStartArea L 03/28/2022 - 02:24:27: [SM] [4] L4D_IsAnySurvivorInStartArea L 03/28/2022 - 02:24:27: [SM] [5] Line 172, f:\Stuff\EVERYTHING ELSE\Left 4 Dead 2 Dedicated Servers\left4dead2\addons\sourcemod\scripting\all4dead2.sp::OnPluginStart

Try the latest version, seems you're using an old one. Although this hasn't changed afaik, maybe issue with the map or something.

[LordVGames]

Originally Posted by Silvers Try the latest version, seems you're using an old one. Although this hasn't changed afaik, maybe issue with the map or something.

I found out through a bit of testing that the error only happens when either of those functions are called before anyone joins the server. Once I joined the server and reloaded the plugin that tried the function it worked fine.

[Silvers]

Originally Posted by LordVGames I found out through a bit of testing that the error only happens when either of those functions are called before anyone joins the server. Once I joined the server and reloaded the plugin that tried the function it worked fine.

It seems this had been called before left4dhooks had even initialized from OnPluginStart, which is very strange. The string "not available ()." between the () should contain details on game/OS/plugin version, but this is empty. The field is populated in "LoadGameData" which is called from "OnPluginStart". No idea how that could have happened, maybe some rare bug, or left4dhooks was taking a while to load and still able to call the related native since those are created before "OnPluginStart". I would leave the plugin(s) as is and check if the error occurs again, please report if it does. Then maybe the plugin using these natives should add a slight delay, maybe only calling the function after "OnAllPluginsLoaded".

[Silvers]

1.94 (29-Mar-2022)
	- Added natives "L4D_GetReserveAmmo" and "L4D_SetReserveAmmo" to get and set a players weapons reserve ammo.

	- Changed forward "L4D2_CGasCan_ShouldStartAction" swapping the nozzle and gascan params - to keep consistency with "L4D2_CGasCan_ActionComplete". Thanks to "Eyal282" for reporting.

	- Fixed forward "L4D2_OnPlayerFling" not firing. Thanks to "Forgetest" for reporting.

	- The follow forwards will no longer fire their post hook counterparts when blocked in the pre-hook (this allows using the post hooks to guarantee the forwards detoured function is invoked):
		"L4D2_OnHitByVomitJar", "L4D_OnVomitedUpon", "L4D2_CInsectSwarm_CanHarm", "L4D2_OnStartCarryingVictim", "L4D2_OnStartCarryingVictim", "L4D2_OnJockeyRide", "L4D_OnGrabWithTongue",
		"L4D2_CGasCan_ActionComplete", "L4D2_CGasCan_ShouldStartAction", "L4D_PipeBombProjectile_Pre", "L4D_OnMaterializeFromGhostPre", "L4D2_OnPlayerFling", "L4D2_OnThrowImpactedSurvivor",
		"L4D2_OnPummelVictim", "L4D_OnKnockedDown", "L4D2_OnPounceOrLeapStumble", "L4D2_OnEndVersusModeRound", "L4D_OnTryOfferingTankBot", "L4D_TankClaw_OnPlayerHit_Pre", "L4D_OnGetMissionVSBossSpawning",
		"L4D_OnEnterGhostState", "L4D_OnSpawnMob", "L4D_OnSpawnITMob", "L4D_OnMobRushStart", "L4D_OnFirstSurvivorLeftSafeArea", "L4D_OnSpawnWitch", "L4D2_OnSpawnWitchBride", "L4D_OnSpawnTank" and "L4D_OnSpawnSpecial".

[LordVGames]

Originally Posted by Silvers It seems this had been called before left4dhooks had even initialized from OnPluginStart, which is very strange. The string "not available ()." between the () should contain details on game/OS/plugin version, but this is empty. The field is populated in "LoadGameData" which is called from "OnPluginStart". No idea how that could have happened, maybe some rare bug, or left4dhooks was taking a while to load and still able to call the related native since those are created before "OnPluginStart". I would leave the plugin(s) as is and check if the error occurs again, please report if it does. Then maybe the plugin using these natives should add a slight delay, maybe only calling the function after "OnAllPluginsLoaded".

It worked fine when calling the function in OnAllPluginsLoaded. I guess it error-ed out previously since the plugin file I was working on started with an 'a', so it loaded before left4dhooks and broke when trying to use a function from it.

[Silvers]

Originally Posted by LordVGames It worked fine when calling the function in OnAllPluginsLoaded. I guess it error-ed out previously since the plugin file I was working on started with an 'a', so it loaded before left4dhooks and broke when trying to use a function from it.

The filename does not determine the load order, it could be any random order which cannot be defined, so for early things relying on other plugins you must use something like OnAllPluginsLoaded.

[ProjectSky]

can you add OnWitchSetHarasser forward? idk why witch_harasser_set event not fire sometimes.