[Annihilator]

Pretty hard to know what the plugin is supposed to do, since all it does is announce that "Boxing is enabled/disabled", turn on friendly fire, but disables ff for CT.

So, I'm assuming its a plugin that lets CTs turn on Ts-only friendly fire (although there's a bug, that doesn't turn ff off when trying to disable).

[PreFix]

Yeah.I founded that bug too...Can you make that when box is enabled , CT can't kill other CT?
And you should remove those team attacking messages when box is enabled.(somehow..)

[shavit]

Originally Posted by PreFix Yeah.I founded that bug too...Can you make that when box is enabled , CT can't kill other CT? And you should remove those team attacking messages when box is enabled.(somehow..)

CT aren't supposed to kill another CTs, because a Box is a mini-game that guards playing with prisoners.
Also, I'll fix the messages in the next version.

[PreFix]

Just can you do it in case...

[shavit]

Update!
1.3 - (04 July 2012)
Fixed the bug that you can receive damage from attacks only.

[RedSword]

At any round end the jailbreak box disabling, due a CT abuse to kill T's with no sense. [freekilling]

I really don't get why you say that. CTs can always attack Ts, and your plugin only change friendly-fire. CTs and Ts aren't the same team (obv.), so I don't understand why that statement of yours :/.

Also, I don't think you should be returning Plugin_Handled on L53, as, let's take this scenario :
1- A don't like B. A has a nade. A throw his nade at B.
2- C see that and kill A.
3- A's nade explode and damage B.

The nade does no damage, because L53 is reached. I doubt this is wanted.

(trivial) Also you're duplicating the checks on a valid attacker (which is unneeded).

Box feature is a friendlyfire fight between teams on jailbreak.

But if both players are CTs they won't be able to damage each other... (see L46).

Also, I'm pretty sure you mean by L42 GetConVarInt/Bool(gH_ff) rather than gH_ff. (Maybe I'm wrong, tell me)

I really think you should say in your initial post that your plugin override completely mp_friendlyfire rules.

Red

[hardy4u]

 L 02/10/2013 - 19:22:26: SourceMod error session started
    L 02/10/2013 - 19:22:26: Info (map "ba_jail_blackops") (file "errors_20130210.log")
    L 02/10/2013 - 19:22:26: [SM] Native "RemoveLastRequestFromList" reported: LR Name (Shotgun Wars) Not Found
    L 02/10/2013 - 19:22:26: [SM] Displaying call stack trace for plugin "lastrequest_shotgunwars.smx":
    L 02/10/2013 - 19:22:26: [SM] [0] Line 83, lastrequest_shotgunwars.sp::OnPluginEnd()
    L 02/10/2013 - 19:29:12: [SM] Native "GetClientTeam" reported: Client index -3 is invalid
    L 02/10/2013 - 19:29:12: [SM] Displaying call stack trace for plugin "jailbreakbox.smx":
    L 02/10/2013 - 19:29:12: [SM] [0] Line 79, C:\Users\????\Desktop\????? ?????\pstudio-0.8.3\jailbreakbox.sp::BoxmenuHandler()
    L 02/10/2013 - 19:29:13: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
    L 02/10/2013 - 19:29:13: [SM] Displaying call stack trace for plugin "jailbreakbox.smx":
    L 02/10/2013 - 19:29:13: [SM] [0] Line 79, C:\Users\????\Desktop\????? ?????\pstudio-0.8.3\jailbreakbox.sp::BoxmenuHandler()
    L 02/10/2013 - 20:00:53: [SM] Native "GetClientTeam" reported: Client index 0 is invalid
    L 02/10/2013 - 20:00:53: [SM] Displaying call stack trace for plugin "jailbreakbox.smx":
    L 02/10/2013 - 20:00:53: [SM] [0] Line 79, C:\Users\????\Desktop\????? ?????\pstudio-0.8.3\jailbreakbox.sp::BoxmenuHandler()
    L 02/10/2013 - 20:52:24: Error log file session closed.

[shavit]

I'll fix it tomorrow.

Originally Posted by RedSword I really don't get why you say that. CTs can always attack Ts, and your plugin only change friendly-fire. CTs and Ts aren't the same team (obv.), so I don't understand why that statement of yours :/. Also, I don't think you should be returning Plugin_Handled on L53, as, let's take this scenario : 1- A don't like B. A has a nade. A throw his nade at B. 2- C see that and kill A. 3- A's nade explode and damage B. The nade does no damage, because L53 is reached. I doubt this is wanted. (trivial) Also you're duplicating the checks on a valid attacker (which is unneeded). But if both players are CTs they won't be able to damage each other... (see L46). Also, I'm pretty sure you mean by L42 GetConVarInt/Bool(gH_ff) rather than gH_ff. (Maybe I'm wrong, tell me) I really think you should say in your initial post that your plugin override completely mp_friendlyfire rules. Red

Already fixed all of those in my private server.
And:

But if both players are CTs they won't be able to damage each other... (see L46).

The point of the plugin is enabling friendlyfire for terrorists only, so it'll be more realistic. (Prison guards won't attack each other IRL, but the prisoners can attack each other while in cells)

[shavit]

1.4 - (18 February 2013)
Fixed every listed problem/error and rewrote the plugin.

[RedSword]

Hi,

Plugin seems ok. Approved.

Some points you may want to change :

• You may want to tell in your first post that your plugin toys with friendly-fire; and so plugin modifying FF could have some conflicts with your plugin.
• I do believe you could reach a wider audience by removing the "need hostie" thing; as I do believe it is possible to compile without; with the good preprocessor directives.

btw :

Terrorists (and only terrorists) can attack each other, as a mini-game.

way better description than before, AFAICR.

Red