[341464]

I'm currently writing a plugin that communicates with an Android app to forward the chat and game info. I'm pretty new to socket so, I have no idea why this is happening -

PHP Code:

public OnChildSocketReceive(Handle socket, char[] receiveData, const int dataSize, any hFile)
{
    PrintToServer("Received packet: %i bytes, Message: %s", dataSize, receiveData);
    bool err = false;

    ByteBuffer status = CreateByteBuffer(true, out, sizeof(out));
    status.WriteInt(0xFFFFFFFF);
    char key[36];
    g_ConnectionPassword.GetString(key, sizeof(key));

    if(!StrContains(receiveData, key) != -1)
    {
        PrintToServer("Invalid password from client! Kicking it off...");
        status.WriteByte(PTYPE_CONNECTION_FAILURE);
        status.WriteShort(sizeof(badPassword));
        status.WriteString(badPassword);
        err = true;
    }
    if (!err)
    {
        ByteBuffer validation = CreateByteBuffer(true, receiveData, dataSize);
        if (ValidateServer(socket, validation))
        {
            PrintToServer("Accepting connection...");
            status.WriteByte(PTYPE_CONNECTION_SUCCESS);
            status.WriteShort(sizeof(success));
            status.WriteString(success);
        }
    }

    out_size = status.Dump(out,sizeof(out));
    SocketSend(socket, out, out_size);
    if (err)
    {
        int index = FindValueInArray(ARRAY_Connections, socket);
        if(index != -1)
            RemoveFromArray(ARRAY_Connections, index);
        CloseHandle(socket);
    }
} 


Whenever I try to print the received data packet from a socket it throws garbled data at me. But if I do receieveData[dataSize-20] or some random number I suddenly get readable output? In this case, an IP address.

[StSatan]

Line 110:

PHP Code:

if(!StrContains(receiveData, key) != -1) 


0 always != -1

must be

PHP Code:

if(StrContains(receiveData, key) != -1) 


[341464]

Thanks for pointing that out but it didn't answer my question.

[Arkarr]

Originally Posted by 341464 Thanks for pointing that out but it didn't answer my question.

Can I see your code to send the infos ? You might want to read my tutorial about sockets.
The problem probably come from the size of the paquets. I had some probelms with the socket extension also, 'cause of the wrong termination of paquets... Normally, it should end with "\0".
EDIT: The size is definitly the problem.

[341464]

Originally Posted by Arkarr Can I see your code to send the infos ? You might want to read my tutorial about sockets. The problem probably come from the size of the paquets. I had some probelms with the socket extension also, 'cause of the wrong termination of paquets... Normally, it should end with "\0". EDIT: The size is definitly the problem.

It's odd, socket picked up the 30 bytes data, the same from Wireshark as well. I agree that the null delimiter seems to be off, not sure.

[341464]

Bump. I still can't figure out how to fix this.

[Arkarr]

Originally Posted by 341464 Bump. I still can't figure out how to fix this.

try to add the terminator manually in your string. If you don't mind, you could send me the whole code (thorugh PM if it has to remain private) and I can try to fix it.

[341464]

Originally Posted by Arkarr try to add the terminator manually in your string. If you don't mind, you could send me the whole code (thorugh PM if it has to remain private) and I can try to fix it.

I did try to add the terminator in the end and it still wouldn't show up properly.

Here's the code.
http://pastebin.com/C1FG5PnE

EDIT: Also, ignore the useless ValidateServer function. It was yet to be implemented.

[341464]

Figured it out, if you do %X and then print out the data. It'll only show FFFFFFFF because the rest were cut due to the null delimiter in the packet data before the full message ends. Looks like I'll just have to do something like this now -

	char server_key[64];
	char client_key[64];
	//Obtain server password
	g_ConnectionPassword.GetString(server_key, sizeof(server_key));
	//Obtain client password
	strcopy(client_key, sizeof(client_key), receiveData[9]);

[Arkarr]

Erf... Too late. Anyway, good job. I was pretty sure it was 'cause of the delimiter.