[ConnorMcLeod]

He means, as claudiuhks already said, to check if destination string is not in arguments.

[Mofforg]

Originally Posted by ConnorMcLeod He means, as claudiuhks already said, to check if destination string is not in arguments.

I am not really sure....

If something is wrong - will compiler return an error or i can find problems only in real testing?

[Mofforg]

Originally Posted by ConnorMcLeod He means, as claudiuhks already said, to check if destination string is not in arguments.

I am not really sure....

If something is wrong - will compiler return an error or i can find problems only in real testing?

ex from mutemenu

PHP Code:

    new nLen = formatex(szMenuBody, MENU_SIZE-1, g_menutitle[g_is_counterstrike], "", pos+1, (nNum / MENU_PLAYERS + ((nNum % MENU_PLAYERS) ? 1 : 0 )))
    new nEnd = nStart + MENU_PLAYERS
    new nKeys = (1<<9)
    
    if( nEnd > nNum )
        nEnd = nNum
    
    for(i = nStart; i < nEnd; i++)
    {
        iPlayerID = g_nMenuPlayers[i]
        get_user_name(iPlayerID, szUserName, 31)
        
        if(access(iPlayerID, ADMIN_KICK) || iPlayerID == id)
        {
            nCurrKey++
            nLen += formatex(szMenuBody[nLen], (MENU_SIZE-1-nLen), g_menutext1[g_is_counterstrike], nCurrKey, szUserName)
        }
        else
        {
            nKeys |= (1<<nCurrKey++)
            nLen += formatex(szMenuBody[nLen], (MENU_SIZE-1-nLen), g_menutext2[g_is_counterstrike], nCurrKey, (gb_mute[id][iPlayerID] ? "mute" : ""), szUserName)
        }
    }
    
    if(nEnd != nNum)
    {
        formatex(szMenuBody[nLen], (MENU_SIZE-1-nLen), "^n9. More...^n0. %s", pos ? "Back" : "Exit")
        nKeys |= (1<<8)
    }
    else
        formatex(szMenuBody[nLen], (MENU_SIZE-1-nLen), "^n0. %s", pos ? "Back" : "Exit") 


[ConnorMcLeod]

Compiler will never say anything about this.

In your example it is ok.

Check szMenuBody variable, when it is used as argument 4 or more, then you can't use formatex.

[Mofforg]

Originally Posted by ConnorMcLeod Compiler will never say anything about this. In your example it is ok. Check szMenuBody variable, when it is used as argument 4 or more, then you can't use formatex.

If i will - what will happen?

Would plugin return an error to log / server crash / or what else?

[ConnorMcLeod]

No, but string will be messed up

format(dest, charsmax(dest), "blabla %s", dest) is ok because format keeps dest in memory

Do the same with formatex, and when last argument is read, it is empty, or something like that, so you would have the end string : "blabla " instead of "blabla other chars"

[YamiKaitou]

I don't think an error will be generated, just the formatted string will not be as you expect

[Mofforg]

Thank you guys.