[CSS] Remove player weapon

altex · **Author**

What is the difference between two functions

Code:

new ent = GetPlayerWeaponSlot(client, slot);
RemoveEdict(ent);

and

Code:

new ent = GetPlayerWeaponSlot(client, slot);
RemovePlayerItem(client, ent);

Which aproach is most correct and why?

jackpf · 12-25-2009 , 04:12 Re: [CSS] Remove player weapon

I'd say the latter, since you're specifically removing a client's weapon, not just any entity.

altex · 12-25-2009 , 04:13 Re: [CSS] Remove player weapon

But why? I tested and both works fine :-|

also i was found even the following code in forum

Code:

new ent = GetPlayerWeaponSlot(client, slot);
RemovePlayerItem(client, ent);
RemoveEdict(ent);

jackpf · 12-25-2009 , 04:20 Re: [CSS] Remove player weapon

Well, as you've stated yourself, both work.

I'm simply making a decision on suitability imo, but obviously it's completely down to taste/coding style

Quote:

new ent = GetPlayerWeaponSlot(client, slot);
RemovePlayerItem(client, ent);
RemoveEdict(ent);

I'm not sure why that's necessary, or even valid. Surely destroying an entity twice, it will not exist the second time, so will throw an error. Could be wrong though.

altex · 12-25-2009 , 04:23 Re: [CSS] Remove player weapon

sourcemod-1.2.4\linux\addons\sourcemod\scripting\includ e\tf2_stocks.inc

Code:

/**
 * Removes all weapons from a client's weapon slot
 *
 * @param client		Player's index.
 * @param slot			Slot index (0-5)
 * @noreturn
 * @error				Invalid client, invalid slot or lack of mod support
 */
stock TF2_RemoveWeaponSlot(client, slot)
{
	new weaponIndex;
	while ((weaponIndex = GetPlayerWeaponSlot(client, slot)) != -1)
	{
		RemovePlayerItem(client, weaponIndex);
		RemoveEdict(weaponIndex);
	}
}

Dragonshadow · 12-25-2009 , 10:56 Re: [CSS] Remove player weapon

I think it works because it removes the item from the player and then deletes the ent.

altex · 12-25-2009 , 11:52 Re: [CSS] Remove player weapon

Actualy i do not understand what "remove from player" means. I just noticed that it makes sdk call to RemovePlayerItem function.

Dragonshadow · 12-25-2009 , 14:26 Re: [CSS] Remove player weapon

Quote:

Originally Posted by altex

Actualy i do not understand what "remove from player" means. I just noticed that it makes sdk call to RemovePlayerItem function.

Ok, player is holding a weapon, first part removes the weapon from the player. Now the weapon is "gone" but the entity still exists, so the second part removes the actual entity

altex · 12-25-2009 , 14:33 Re: [CSS] Remove player weapon

So the most correct way is

Code:

new ent = GetPlayerWeaponSlot(client, slot);
RemovePlayerItem(client, ent);
RemoveEdict(ent);

Thank you

Dragonshadow · 12-25-2009 , 15:35 Re: [CSS] Remove player weapon

No problem ^^