[amirwolf]

Hello
What I was trying to do
Trying to add some random color to the door

PHP Code:

#define bar_Random(%1) %1 == -1 ? g_fColor[random(MAX_COLORS)] : %1

set_pev(g_iEntBarrier,pev_rendercolor,bar_Random(g_eSettings[BARRIER_COLOR][0],g_eSettings[BARRIER_COLOR][1],g_eSettings[BARRIER_COLOR][2])); 


[lexzor]

post how you declare g_fColor

[amirwolf]

PHP Code:

#define MAX_COLORS 25
new const Float:g_fColor[MAX_COLORS][3] = 
{
    {200.0, 000.0, 000.0},
    {255.0, 083.0, 073.0},
    {255.0, 117.0, 056.0},
    {255.0, 174.0, 066.0},
    {255.0, 207.0, 171.0},
    {252.0, 232.0, 131.0},
    {254.0, 254.0, 034.0},
    {059.0, 176.0, 143.0},
    {197.0, 227.0, 132.0},
    {000.0, 150.0, 000.0},
    {120.0, 219.0, 226.0},
    {135.0, 206.0, 235.0},
    {128.0, 218.0, 235.0},
    {000.0, 000.0, 255.0},
    {146.0, 110.0, 174.0},
    {255.0, 105.0, 180.0},
    {246.0, 100.0, 175.0},
    {205.0, 074.0, 076.0},
    {250.0, 167.0, 108.0},
    {234.0, 126.0, 093.0},
    {180.0, 103.0, 077.0},
    {149.0, 145.0, 140.0},
    {000.0, 000.0, 000.0},
    {255.0, 255.0, 255.0},
    {000.0, 000.0, 000.0}
} 


[Celena Luna]

I think it is because bar_Random only take 1 parameters, not 3

[Bugsy]

Try this

PHP Code:

new iColorIndex = bar_Random( g_eSettings[ BARRIER_COLOR ][ 0 ]  ); 
set_pev(g_iEntBarrier,pev_rendercolor,g_eSettings[iColorIndex][0],g_eSettings[iColorIndex][1],g_eSettings[iColorIndex][2])); 


[amirwolf]

Same error again
why when i add this

random_float(0.0, 255.0)

Only red color is visible

[lexzor]

since g_fColor has float values, bar_Random is made to return float values

PHP Code:

#define bar_Random(%1) %1 == -1 ? g_fColor[random(MAX_COLORS)] : %1 


not the index of the colors from g_fColors

since the value of g_fColors is hardcorded, you could return the index of the colors by using random(sizeof(g_fColors)-1)

[amirwolf]

The error is now fixed
But it still does not work, random values ​​are not added

[fysiks]

If you're just trying to get a random index value for the colors array, you simply do that first:

PHP Code:

new iRandomIndex = random(sizeof(g_fColors)) 


Then, you can choose to use that or whatever settings you have.

PHP Code:

new ActualColorIndex = (setting == -1 ? iRandomIndex : setting) 


then use this index for g_fColor:

PHP Code:

new red = g_fColor[ActualColorIndex][0]
new green = g_fColor[ActualColorIndex][1]
new blue = g_fColor[ActualColorIndex][2] 


If you want each component of the color to be independently random then you need to do the same thing for each of the three components.

I think you're complicating things by trying to be clever with your code. Stop using the preprocessor and write basic code first, it doesn't have to be pretty or scalable, just write it to make it work. Get that working and then optimize later.

Originally Posted by lexzor since the value of g_fColors is hardcorded, you could return the index of the colors by using random(sizeof(g_fColors)-1)

The function "random" is designed specifically for indexing arrays based on the size of the array so you should not subtract 1 unless you're intentionally trying to exclude the last value in the array.

[amirwolf]

It has always been difficult for me to understand
I will try my best
thank you