iChat 2.3.3 - The most powerful chat manager - Page 22

dangerlord63 · 08-15-2014 , 11:36 Re: iChat 2.3.0 - The most powerful chat manager

bug detected

if anybody use "say #Cstrike_GIGN_Label #Cstrike_GIGN_Label" command every player is quiting the game
u need to use this ;
replace_all(szSaid, charsmax(szSaid), "#", "*" );

Kidev · *Last edited by Kidev; 11-07-2014 at 14:27.*

Here are some bug fixes. Untested.

File removed, iChat bugs are now fixed

GordonFreeman (RU) · *Last edited by GordonFreeman (RU); 09-28-2014 at 22:33.*

Yea, Valve style fix.

To fix this you just need to to pass %s2 as 2nd parameter and your message as 4nd parameter. Example code:

Spoiler

More about Valve fix.

Kidev · *Last edited by Kidev; 10-02-2014 at 16:37.*

With this, all players arn't kick, but it breaks the colors. Is it normal? Shall I use something different than "^x03" for the colors now?

GordonFreeman (RU) · 10-09-2014 , 13:38 Re: iChat 2.3.0 - The most powerful chat manager

Hm. Make a format string like that:

Code:

^^3%%s1^^1: ^^4%%s2^^1

%%s1 will replaced with senders name by client. You don't need get_user_name calls.

This way is more save and can handle very big messages without cut.
http://steamcommunity.com/sharedfile.../?id=302205173

Kidev · *Last edited by Kidev; 11-07-2014 at 15:04.*

Ok thanks to GordonFreeman (RU), ALL the issues related to clients saying shit are now CORRECTED. A player can type "say %s%s%s%s%s%s" if he wants; what will be displayed is "%s%s%s%s%s%s". Thus iChat seems to be bug-free !

Have fun with it, and report any issue please. New features are coming once all my plugins are bug-free.

Updated to 2.3.3:

Fixed all "say" issues, and more
Changed MSG_ONE_UNRELIABLE to MSG_ONE

Bradberry · 12-02-2014 , 11:00 Re: iChat 2.3.0 - The most powerful chat manager

Quote:

Originally Posted by -Kid-

Ok thanks to GordonFreeman (RU), ALL the issues related to clients saying shit are now CORRECTED. A player can type "say %s%s%s%s%s%s" if he wants; what will be displayed is "%s%s%s%s%s%s". Thus iChat seems to be bug-free !

Have fun with it, and report any issue please. New features are coming once all my plugins are bug-free.

Updated to 2.3.3:

Fixed all "say" issues, and more
Changed MSG_ONE_UNRELIABLE to MSG_ONE

Hi dude, found one "bug" which annoys me.
Player presses alt + 0153 (0157 0152 e.t.c) in say messagemode and message displayed as empty.
It's possible to fix it? =/

PRoSToTeM@ · *Last edited by PRoSToTeM@; 12-02-2014 at 15:04.*

Try "say #Spec_Duck" and you will see in chat "Press DUCK for Spectator Menu", to fix add to said '^n'. (see https://github.com/ValveSoftware/hal...lls/client.cpp Host_Say function)
Example code:

Code:

    new nLen = strlen(szSaid);
    if (nLen == charsmax(szSaid)) {
        szSaid[charsmax(szSaid) - 1] = '^n';
        //szSaid[charsmax(szSaid)] = '^0';
    } else {
        szSaid[nLen] = '^n';
        //szSaid[nLen + 1] = '^0';
    }

Also need replace unprintable chars ('^0' < ch < ' ' and ch == 0x7F (DEL)) with spaces, because player can use SOH, STX, ETX, EOT (^1, ^2, ^3, ^4) chars to manipulate with colors.
Example code:

Code:

    new nLen = strlen(szSaid);
    for (new n = 0; n < nLen; n++) {
        if ('^0' < szSaid[n] < ' ' || szSaid[n] == 0x7F) {
            szSaid[n] = ' ';
        }
    }

PRoSToTeM@ · 12-04-2014 , 09:09 Re: iChat 2.3.3 - The most powerful chat manager

You can use PLUGIN_HANDLED_MAIN return value, instead of checking for "last plugin". (in say and say_team callbacks). PLUGIN_HANDLED block gamedll callback and next plugins callbacks, PLUGIN_HANDLED_MAIN do same, but don't block next plugins callbacks. (I think this is what you need)

And I think better replace all unreliable messages (MSG_ONE_UNRELIABLE, MSG_BROADCAST) to reliable (MSG_ONE, MSG_ALL).

Kidev · 12-04-2014 , 19:39 Re: iChat 2.3.3 - The most powerful chat manager

I used to use _MAIN but I think I remember there was a problem. I'll check all of your codes tomorrow! Thanks for your help!