[addons_zz]

Originally Posted by fysiks Keeping a global array for menu id's, especially player specific, seems completely unnecessary. I'd say it's indicative of poorly designed code. Using menus is simple. If you create a menu dynamically, destroy it in the menu handler. If you have a menu that is global (created in plugin_init and rarely, if ever, edited/changed) then it should be destroyed at plugin_end. FYI, when one menu overwrites another menu, MENU_EXIT is called on the first menu (this is why, unless it's a global menu, you should always destroy it in the menu handler in the MENU_EXIT).

This is not fully working for the AMXX 182 at least. This is my test, and attached is the plugin used, so you can try also.

L 07/10/2016 - 18:47:22: World triggered "Round_Start"
I AM ENTERING ON createMenu(1) | player_id: 1
I AM EXITING ON createMenu(1)
Addons zz : mymenu
L 07/10/2016 - 18:47:26: "Addons zz<1><STEAM_ID_LAN><TERRORIST>" say "mymenu"
SV_StartSound: player/sprayer.wav not precached (0)
restart
☺[AMXX] ♦Addons zz☺  ( ♦STEAM_ID_LAN☺  -  ♦192.168.25.165:27005☺ )  has disconnected  ( ♦LAN☺ ).



I AM ENTERING ON plugin_end(0). THE END OF THE PLUGIN LIFE!
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 0
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 1
( clearMenuMapIndexForPlayers) | I am destroying the menu, g_generalUsePlayersMenuId[1]: 5
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 2
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 3
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 4
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 5
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 6
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 7
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 8
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 9

As you see, one menu was destroyed on the 'plugin_end(0)'.

What I did was to open mymenu, then opened the AMX Mod X Menu (amxmodmenu).
And closed it. And as you see, we must see the print
'( clearMenuMapIndexForPlayers) | I am destroying the menu, g_generalUsePlayersMenuId[%d]: %d'
when I opened the amxmodmenu, but it do not happened.
Then, when I restarted the server and plugin_end(0) was called, it deleted the menu, as we can see.


But on my second test, I opened the galileo nomination menu, which uses also the new menu system, and it worked.

L 07/10/2016 - 18:57:31: World triggered "Round_Start"
I AM ENTERING ON createMenu(1) | player_id: 1
I AM EXITING ON createMenu(1)
Addons zz : mymenu
L 07/10/2016 - 18:57:34: "Addons zz<2><STEAM_ID_LAN><CT>" say "mymenu"
I AM ENTERING ON menu_handler(1) | player_id: 1, menu: 5, item: -3
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 1
( clearMenuMapIndexForPlayers ) | I am destroying the menu, g_generalUsePlayersMenuId[1]: 5
    ( menu_handler ) Just Returning PLUGIN_CONTINUE.
restart
☺[AMXX] ♦Addons zz☺  ( ♦STEAM_ID_LAN☺  -  ♦192.168.25.165:27005☺ )  has disconnected  ( ♦LAN☺ ).



I AM ENTERING ON plugin_end(0). THE END OF THE PLUGIN LIFE!
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 0
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 1
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 2
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 3
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 4
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 5
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 6
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 7
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 8
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 9

Worked also, when I opened the same menu again.

L 07/10/2016 - 19:13:54: "Addons zz<2><STEAM_ID_LAN><CT>" say "mymenu"
I AM ENTERING ON createMenu(1) | player_id: 1
( createMenu ) | I am destroying the menu, g_generalUsePlayersMenuId[1]: 5
( createMenu ) | I destroyed the menu!
I AM ENTERING ON menu_handler(1) | player_id: 1, menu: 5, item: -3
I AM ENTERING ON clearMenuMapIndexForPlayers(1) | player_id: 1
( clearMenuMapIndexForPlayers ) | I am destroying the menu, g_generalUsePlayersMenuId[1]: 6
    ( menu_handler ) Just Returning PLUGIN_CONTINUE.
I AM EXITING ON createMenu(1)
Addons zz : mymenu
L 07/10/2016 - 19:13:58: "Addons zz<2><STEAM_ID_LAN><CT>" say "mymenu"

This looks like a problem between the old menu system (amxmodmenu) and the new menu system.

[addons_zz]

Originally Posted by HamletEagle Yeah, if you are going to use a cvar more than two times in a function be sure to cache it.

I cached them now. It updated on the version '3.2.0-208' at the file 'galileo.sma' on the first post.
The zip 'Galileo-3.2.0.zip' file keeps with the version '3.2.0-195':

/**
 * Try to set the new game limits as specified by the cvars 'gal_srv_..._restart' feature. This
 * macro requires the integer variable 'serverLimiterValue' defined before the use of this macro.
 * 
 * @param limiterCvarPointer      the 'gal_srv_..._restart' pointer
 * @param serverCvarPointer       the game cvar pointer as 'cvar_mp_timelimit'.
 * @param limiterOffset           the current game limit as an integer. Example: 'map_getMinutesElapsedInteger(0)'.
 */
#define CALCULATE_NEW_GAME_LIMIT(%1,%2,%3) \
do \
{ \
    serverLimiterValue = get_pcvar_num( %1 ); \
    if( serverLimiterValue ) \
    { \
        new serverCvarValue = get_pcvar_num( %2 ); \
        if( serverCvarValue ) \
        { \
            serverCvarValue = serverCvarValue - %3 + serverLimiterValue - 1; \
            if( serverCvarValue > 0 ) \
            { \
                saveEndGameLimits(); \
                set_pcvar_num( %2, serverCvarValue ); \
            } \
        } \
    } \
} while( g_dummy_value )

public resetRoundsScores()
{
    LOGGER( 128 + 2, "I AM ENTERING ON resetRoundsScores(0)" );
    LOGGER( 2, "( resetRoundsScores ) TRYING to change the cvar %15s = '%f'", "'mp_timelimit'", get_pcvar_float( cvar_mp_timelimit ) );
    LOGGER( 2, "( resetRoundsScores ) TRYING to change the cvar %15s = '%d'", "'mp_fraglimit'", get_pcvar_num( cvar_mp_fraglimit ) );
    LOGGER( 2, "( resetRoundsScores ) TRYING to change the cvar %15s = '%d'", "'mp_maxrounds'", get_pcvar_num( cvar_mp_maxrounds ) );
    LOGGER( 2, "( resetRoundsScores ) TRYING to change the cvar %15s = '%d'", "'mp_winlimit'", get_pcvar_num( cvar_mp_winlimit ) );
    
    new serverLimiterValue;
    
    CALCULATE_NEW_GAME_LIMIT( cvar_serverTimeLimitRestart, cvar_mp_timelimit, map_getMinutesElapsedInteger() );
    CALCULATE_NEW_GAME_LIMIT( cvar_serverWinlimitRestart, cvar_mp_winlimit, max( g_totalTerroristsWins, g_totalCtWins ) );
    CALCULATE_NEW_GAME_LIMIT( cvar_serverMaxroundsRestart, cvar_mp_maxrounds, g_roundsPlayedNumber );
    CALCULATE_NEW_GAME_LIMIT( cvar_serverFraglimitRestart, cvar_mp_fraglimit, g_greatestKillerFrags );
    
    // Reset the plugin internal limiter counters.
    g_totalTerroristsWins = 0;
    g_totalCtWins         = 0;
    g_roundsPlayedNumber  = -1;
    g_greatestKillerFrags = 0;
    
    LOGGER( 2, "( resetRoundsScores ) CHECKOUT the cvar %-23s is '%f'", "'mp_timelimit'", get_pcvar_float( cvar_mp_timelimit ) );
    LOGGER( 2, "( resetRoundsScores ) CHECKOUT the cvar %-23s is '%d'", "'mp_fraglimit'", get_pcvar_num( cvar_mp_fraglimit ) );
    LOGGER( 2, "( resetRoundsScores ) CHECKOUT the cvar %-23s is '%d'", "'mp_maxrounds'", get_pcvar_num( cvar_mp_maxrounds ) );
    LOGGER( 2, "( resetRoundsScores ) CHECKOUT the cvar %-23s is '%d'", "'mp_winlimit'", get_pcvar_num( cvar_mp_winlimit ) );
    LOGGER( 1, "I AM EXITING ON resetRoundsScores(0)" );
}

[BeNq!]

Where I add sound after the vote maps, so as not to play sound 3x?

[addons_zz]

Originally Posted by BeNq! Where I add sound after the vote maps, so as not to play sound 3x?

Here:

Spoiler

/**
 * Restore global variables to is default state. This is to be ready for a new voting.
 */
stock finalizeVoting()
{
    LOGGER( 128, "I AM ENTERING ON finalizeVoting(0)" );
    
    g_isVotingByTimer               = false;
    g_isVotingByRounds              = false;
    g_isVotingByFrags               = false;
    g_isRunOffNeedingKeepCurrentMap = false;
    
    // vote is no longer in progress
    g_voteStatus &= ~VOTE_IS_IN_PROGRESS;
    
    // if we were in a runoff mode, get out of it
    g_voteStatus &= ~VOTE_IS_RUNOFF;
    
    // this must be called after 'g_voteStatus &= ~VOTE_IS_RUNOFF' above
    vote_resetStats();
}

[BeNq!]

1. No, I add sound in finalizeVoting() and sounds play on start a map. Why?
2. Why vote running when timeleft = 6/7 minutes? Should be a 3 minutes before the end of the map.
3. Please change cvar gal_nom_qtyused, because when I have gal_vote_mapchoices 4 and qtyused 4 players can nominate more maps. A maximum should be "4" and notice "Error... Maksimum nominations is finally".
4. Please delete GAL_MATCHING, because when is blocked more than 6 maps, this may result in crash. Check it.
5. What do you think to add settings data hours?

Example whitelist:

[22-10]
de_dust2
de_dust
de_inferno
de_nuke
gal_banrecent 3 ( default 5 )

Thank you.

[addons_zz]

Originally Posted by BeNq! 1. No, I add sound in finalizeVoting() and sounds play on start a map. Why?

Add it here then:

Spoiler

    }
    
    LOGGER( 1, "    ( computeVotes|out ) g_isTimeToRestart: %d, \
            g_isTimeToChangeLevel: %d \
            g_voteStatus & VOTE_IS_FORCED: %d", \
                                         g_isTimeToRestart, \
            g_isTimeToChangeLevel, \
            g_voteStatus & VOTE_IS_FORCED != 0 );
 // here
    finalizeVoting();
}

/**
 * Restore global variables to is default state. This is to be ready for a new voting.
 */
stock finalizeVoting()
{
    LOGGER( 128, "I AM ENTERING ON finalizeVoting(0)" );
    
    g_isVotingByTimer               = false;
    g_isVotingByRounds              = false;
    g_isVotingByFrags               = false;
    g_isRunOffNeedingKeepCurrentMap = false;

Originally Posted by BeNq! 2. Why vote running when timeleft = 6/7 minutes? Should be a 3 minutes before the end of the map.

If you enable the cvar it will be:

// Indicates whether there should be created a 4 minutes range before
// the last 2 minutes to detect a round start and to give time about 20
// seconds to buy weapons after the round to start and before the map
// voting to start.
// 0 - disabled this feature
// 1 - enable this feature
gal_endofmapvote_start 1

Set it to zero, to always be on the last ~2 minutes

Originally Posted by BeNq! 3. Please change cvar gal_nom_qtyused, because when I have gal_vote_mapchoices 4 and qtyused 4 players can nominate more maps. A maximum should be "4" and notice "Error... Maksimum nominations is finally".

I will check this and fix any overflow, if there are.

Originally Posted by BeNq! 4. Please delete GAL_MATCHING, because when is blocked more than 6 maps, this may result in crash. Check it.

If it may result in crash, I will fix the crash.

Originally Posted by BeNq! 5. What do you think to add settings data hours? Example whitelist: [22-10] de_dust2 de_dust de_inferno de_nuke gal_banrecent 3 ( default 5 ) Thank you.

It can be done.

[addons_zz]

Released a new version:

2016-07-20 | v3.2.1-243

1. Fixed possible server crash on certain circumstances as with the Whitelist and Minimum Players features.
2. Improved over all performance completely removing the debugging tools from the final code.

Originally Posted by BeNq! 3. Please change cvar gal_nom_qtyused, because when I have gal_vote_mapchoices 4 and qtyused 4 players can nominate more maps. A maximum should be "4" and notice "Error... Maksimum nominations is finally".

I checked, there is any overflow. This function is as it is on the original Galileo by Brad. And as said on its documentation:

// Specifies how many of the nominations made will be considered for use
// in the next map vote.
// A value of 0 means all the nominated maps will be considered.
gal_nom_qtyused 0

It does not say it will block more than 4 nominations in game, it says that when the voting starts it will consider all nominations if the cvar value is 0, or until the value specified. And it is doing that.

Originally Posted by BeNq! 4. Please delete GAL_MATCHING, because when is blocked more than 6 maps, this may result in crash. Check it.

Fixed.

Originally Posted by BeNq! 5. What do you think to add settings data hours?

It can be done. But is is out of a mapchooser plugin. You can use this plugin for hourly configurations.
The plugin Task Scheduler can do that.

[BeNq!]

WTF? Why runoff is not map? This is the vote:

1.
2.

0.

WTF? Galileo 3.2.1-243... Does not display the names of the map.

[addons_zz]

Released a new version:

2016-07-20 | v3.2.2-248

1. Fixed run-off voting showing empty map names.

[gabuch2]

Hello addons_zz

Great job on everything you have done so far.

Do you mind expanding Sven Co-op support?

You can use is_running("svencoop") to add some extra checks and to manipulate some specific cvars.

Examples:

PHP Code:

set_pcvar_string( g_cvar_amx_nextmap, nextMap );
if(is_running("svencoop"))
{
    set_cvar_string( "mp_nextmap_cycle", nextMap );
} 


This controls the Next Map: [map name] text which appears in the scoreboard, which is tied to the mp_nextmap_cycle cvar. I know there are more references to amx_nextmap in your code but it was just an example.

Also:

PHP Code:

#include <hamsandwich> 


[plugin_init()]

PHP Code:

if(is_running("svencoop"))
{
    RegisterHam(Ham_Use, "game_end", "voteNextmap");
} 


PHP Code:

voteNextmap()
{
    [call the vote next map method, to immediately change]
} 


This allows the players to choose the nextmap everytime they complete the current one. I tested with server_cmd("gal_startvote") and it works (executing the command because it's a different .amxx plugin), and it would be better if you call the function directly.

Thanks in advance.