[M1NDFREAK]

Hello,
i try to hook FireBullets but it doesn't work.
I Hook it like this: (windows)

PHP Code:

#define HVFUNC( funcname, returntype, proto) \
    typedef returntype ( __stdcall * funcname##Func ) proto ; \
    extern funcname##Func funcname; \
    extern CVirtualCallGate funcname##Gate; \
    returntype __stdcall funcname##_hook proto;

#define HOOKVFUNC( classptr , index , funcname ) \
    if (! funcname##Gate.IsBuilt() ) { \
    DeProtect((void*)VTBL( classptr ), ( index * sizeof(void*)) + 4 ); \
    funcname##Gate.Build((void*)VFN( classptr , index ), funcname##_hook , & funcname ); \
    *(DWORD*)PVFN( classptr , index ) = funcname##Gate.Gate(); \
    }

HVFUNC(h_FireBullets, void, ( CBasePlayer* pPlayer, const FireBulletsInfo_t &info ))


DEFVFUNC(h_FireBullets, void, ( CBasePlayer* pPlayer, const FireBulletsInfo_t &info ))
{
    Msg("h_FireBullets called @ %.1f\n", gpGlobals->curtime);
    h_FireBullets(pPlayer,info);
}

void TestPlugin::ClientActive( edict_t *pEntity )
{
    CBaseEntity *pBaseEnt = pEntity->GetUnknown()->GetBaseEntity();
    HOOKVFUNC(pBaseEnt, 110, h_FireBullets);
} 


What am I doing wrong?

[asherkin]

You aren't using SourceHook.

[M1NDFREAK]

Yes because I'm writing a VSP and I can only use SourceHook in a MetaMod-Plugin right?

[psychonic]

Originally Posted by M1NDFREAK Yes because I'm writing a VSP

AlliedModders Forum Index > SourceMod > Metamod: Source > Coding MM:S Plugins for HL2

[Afronanny]

Originally Posted by M1NDFREAK Yes because I'm writing a VSP and I can only use SourceHook in a MetaMod-Plugin right?

You can embed SourceHook in a VSP.

Anyhow, why mess about with hooking when you can detour? Detouring is easier to manage.

[Chrisber]

So, aren't detouring and hooking basicly the same idea?

[Wazz]

Don't listen to Afronappy, SourceHook manages the hooks which makes it 100 times better and improves your plugin's compatibility with other plugins. Use it.

[pRED*]

Originally Posted by Wazz Don't listen to Afronappy, SourceHook manages the hooks which makes it 100 times better and improves your plugin's compatibility with other plugins. Use it.

SourceHook can only improve compatibility with other plugins when both plugins are sharing the same instance of it. This is true for MM:S plugins, but if you embed your own copy of SH, then you will (potentially) run into the exact same resource conflicts as you would with detouring/other hooking methods.

[asherkin]

Originally Posted by pRED* SourceHook can only improve compatibility with other plugins when both plugins are sharing the same instance of it. This is true for MM:S plugins, but if you embed your own copy of SH, then you will (potentially) run into the exact same resource conflicts as you would with detouring/other hooking methods.

Which is why MM:S exists and why no one should be making VSPs.

[Afronanny]

VSPs are devilishly useful for things you want to keep running even when MM:S breaks. Because VSPs almost never break.