[thatguyyoulove]

Quick question on detecting player connections. Can I detect if a player connects to the server, starts downloading files, and then disconnects(hits Cancel) before he even finishes downloading the files.

I want to write a Google Analytics-esque plugin for Source which will let you figure out your server bounce rate (what I am describing above), daily/hourly/monthly/yearly traffic, average connection time, etc. and show them on your website or admin panel. Detecting bounced players (players who quit connecting before they ever actually get into the server) is one of the most metrics as it will help server owners figure out if their copious downloads (custom sounds, skins, etc.) are having an impact on new traffic.

[necavi]

Easiest way would likely be to do OnClientConnected saving a value to a variable, then clearing it OnClientAuthorized (which I believe is fired after they finish downloading, but I could be wrong about that one) and checking the value OnClientDisconnected, if it has one then log it to a database as a bounce. Please excuse the rambling enclosed, I hope it helps you in some way.

[Dr. McKay]

PHP Code:

#pragma semicolon 1

#include <sourcemod>

new bool:connecting[MAXPLAYERS + 1] = {false, ...};

public OnClientConnected(client) {
    connecting[client] = true;
}

public OnClientInGame(client) {
    connecting[client] = false;
}

public OnClientDisconnect(client) {
    if(connecting[client]) {
        // this is a bounced connection, log it!
    }
    connecting[client] = false;
} 


[thatguyyoulove]

Thank you very much sir! I had overlooked the OnClientInGame function so I wasn't quite sure what stage of joining a server the OnClientConnected was called at. I appreciate the code as well, although I'm not sure what the ellipsis are about. Surely I wouldn't have to hard-code in all of the "false"s right? I thought that new booleans were false by default. I guess if I have to manually set them all to false I would think a for loop would be sufficient.

[Dr. McKay]

Originally Posted by thatguyyoulove Thank you very much sir! I had overlooked the OnClientInGame function so I wasn't quite sure what stage of joining a server the OnClientConnected was called at. I appreciate the code as well, although I'm not sure what the ellipsis are about. Surely I wouldn't have to hard-code in all of the "false"s right? I thought that new booleans were false by default. I guess if I have to manually set them all to false I would think a for loop would be sufficient.

The ellipsis tells the compiler to initialize all of the values as false. Yes, I'm pretty sure they do initialize as false anyway, but it can't hurt to specify. Likewise, new bool:connecting[MAXPLAYERS + 1] = {true, ...}; would initialize all values as true. You don't need to mess with that line at all.

[Impact123]

I've never heard about

PHP Code:

OnClientInGame 


Are you sure that works?

Yours sincerely
Impact

[thatguyyoulove]

Oh wow I have never heard of the ellipsis doing that. Very cool!

Impact I didn't see it in the function list and a Google search didn't reveal much. Maybe he meant OnClientPutInServer? I will test it tomorrow either way so I will find out.

[DarthNinja]

PHP Code:

new bool:connecting[MAXPLAYERS+1] = true; 


Is also totally valid.

Also McKay in your example you have OnClientConnected where what you should have is OnClientConnect.

[Despirator]

Originally Posted by Dr. McKay PHP Code: #pragma semicolon 1 #include <sourcemod> new bool:connecting[MAXPLAYERS + 1] = {false, ...}; public OnClientConnected(client) {     connecting[client] = true; } public OnClientPutInServer(client) {     connecting[client] = false; } public OnClientDisconnect_Post(client) {     if(connecting[client]) {         // this is a bounced connection, log it!     }     connecting[client] = false; }

[Dr. McKay]

I meant OnClientPutInServer. I always get mixed up because of IsClientInGame.

Originally Posted by DarthNinja PHP Code: new bool:connecting[MAXPLAYERS+1] = true;  Is also totally valid. Also McKay in your example you have OnClientConnected where what you should have is OnClientConnect.

What's wrong with OnClientConnected?