[brlight]

hi, I´m having problems with the plugin, it´s not working anymore, got this errors but I don´t know how to fix them.

L 03/26/2016 - 00:584: [AMXX] Displaying debug trace (plugin "sank_sounds.amxx", version "1.8.3")
L 03/26/2016 - 00:584: [AMXX] Run time error 10: native error (native "ArrayGetArray")
L 03/26/2016 - 00:584: [AMXX] [0] sank_sounds.sma::array_add_inner_element (line 2265)
L 03/26/2016 - 00:584: [AMXX] [1] sank_sounds.sma::parse_sound_file (line 1825)
L 03/26/2016 - 00:584: [AMXX] [2] sank_sounds.sma::plugin_cfg (line 59

Any ideas?
Thanks in advance

[karlos]

Actually i have no idea. all you can do is send me your .cfg file and let me test.
1) Have you changed something to the .cfg lately?
2) Is it happening with every map change/server start?

[brlight]

Hi,
Thx for the fast response, I guess it was my fault, I wanted to disable SND_JOIN and SND_EXIT sounds, so I edited the cfg file comenting those two like this:

#SND_JOIN;
#SND_EXIT;

Plugin didn´t like that I guess : ). I just leave like this and now seems to work fine
SND_JOIN;
SND_EXIT;

[Nero-sama]

Hey! Excellent plugin!
I just figured out how to add spliced words to keywords (making vox,barney,scientist, etc say whatever you want) eg: amx_sound_add banana "bust(e25) canal(s10e50) antenna(s50)"

This works just fine, except that I have to keep adding them after every new map loads.
If I use amx_sound_write the keywords get saved, but they can't be loaded.

L 05/21/2016 - 23:26:02: [sank_sounds.amxx] Sank Sounds >> Trying to load a file that dont exist. Skipping this file: "sound/../bust(e25) canal(s10e50) antenna(s50)"
L 05/21/2016 - 23:26:02: [sank_sounds.amxx] Sank Sounds >> Found keyword without any valid sound. Skipping this keyword: "banana"

In order to fix this, I had to comment out the following code:

        if ( allow_check_existence )
        {

            if ( !file_exists(sound_file_name) )
            {
                log_amx("Sank Sounds >> Trying to load a file that dont exist. Skipping this file: ^"%s^"", sound_file_name)

                return -1
            }

            subData[DURATION] = _:cfg_get_duration(sound_file_name, is_mp3 ? SOUND_TYPE_MP3 : SOUND_TYPE_WAV )
            
            if ( subData[DURATION] <= 0.0 )
            {
                log_amx("Sank Sounds >> Sound duration is not valid. File is damaged. Skipping this file: ^"%s^"", sound_file_name)
                
                return -1
            }
        }

This works and all, but it is not an ideal solution. And it might cause other problems?
EDITt: Such as

Invalid file type...skipping download of bust(e25) canal(s10e50) antenna(s50)

Which probably isn't a biggy, but still... D:

Would you be able to update the plugin to let it handle speech files with modifications (e60, p110, s20, etc) ?

Please and thank you.

EDIT2:
I also noticed a bug when adding some of my spliced sentences
Running
amx_sound_add mlp "mike(e60) liquid(e25) test(e20) cable(s50) exposure(s40e60) any(s30)" (don't ask)
amx_sound_add svc_bad "bizwarn bizwarn _comma escape(e30) b(e50) c(e70) bad detected"

And then using that trigger will cause every player on the server to go into some sort of intermission mode (camera gets set lower, you can't move but you can look around and shoot, enabling thirdperson will set the camera inside the player model at around the crotch)
The sound also only plays up to "exposure(s40e60)" for the first one, and up to "bad" in the second.

Suiciding doesn't help.
The only fix I've found is to reconnect. :\

EDIT3: The above bug can be avoided by increasing TOK_LENGTH, but I left the bug report in because of the strangeness of what happens. o.O

[karlos]

Update v1.8.6: (22.05.2016)
fixed:
- players could get stuck in a "spectator" mode state or being kicked if trying to play a sound with exactly TOK_LENGTH length

v1.8.5: (04.05.2014) (seems like I forgot to publish this version)
added:
- support to also load files from "<MOD>_downloads" folder
fixed:
- issue with ADMINS_ONLY and RCON access level

@Nero-sama
1) regarding your load error: if you add this to the config file:

banana; "bust(e25) canal(s10e50) antenna(s50)"

you will not get any error and it will be added on each map load. So I do not understand why you have that error. (this also applies to version 1.8.4)
Are you missing quotes in the config file?
2) to fix the "spectator" error download the update.

[Nero-sama]

Oooh, thanks! :O

Yeah the config file does not have the quotes, however I do not currently have access to edit it (it's for a server I'm an admin on) so when using amx_sound_write it gets added like this:

banana; bust(e25) canal(s10e50) antenna(s50);
panties; panel(e40) security(s70) science(s70);

etc

[Nero-sama]

Any chance you could make it so that amx_sound_add automatically adds the quotes?

Also (this is for Sven Co-op btw) the plugin is looking for sounds only in the main folder, but with the addition of Steampipe we now have modname_addon and modname_downloads (svencoop_addon and svencoop_downloads in my case)

I see you've added the _downloads folder, could you also add the _addon folder please?

[gabuch2]

Originally Posted by Nero-sama I see you've added the _downloads folder, could you also add the _addon folder please?

Line 2251

PHP Code:

        if ( allow_check_existence )
        {
            if ( !file_exists(sound_file_name) )
            {
                new alt_sound_file_name[TOK_LENGTH + 1 + 10 + 32]
                new modname[32]
                get_modname(modname, 31)
                formatex(alt_sound_file_name, TOK_LENGTH + 10 + 32, "../%s_downloads/%s", modname, sound_file_name)
                if ( !file_exists(alt_sound_file_name) )
                {
                    log_amx("Sank Sounds >> Trying to load a file that does not exist. Skipping this file: ^"%s^"", sound_file_name)
                    
                    return -1
                }
                copy(sound_file_name, TOK_LENGTH + 10, alt_sound_file_name);
            } 


>>

PHP Code:

        if ( allow_check_existence )
        {
            if ( !file_exists(sound_file_name) )
            {
                new alt_sound_file_name[TOK_LENGTH + 1 + 10 + 32]
                new modname[32]
                get_modname(modname, 31)
                formatex(alt_sound_file_name, TOK_LENGTH + 10 + 32, "../%s_downloads/%s", modname, sound_file_name)
                if ( !file_exists(alt_sound_file_name) )
                {
                    formatex(alt_sound_file_name, TOK_LENGTH + 10 + 32, "../%s_addons/%s", modname, sound_file_name)
                    if ( !file_exists(alt_sound_file_name) )
                    {
                        log_amx("Sank Sounds >> Trying to load a file that does not exist. Skipping this file: ^"%s^"", sound_file_name)
                        
                        return -1
                    }
                }
                copy(sound_file_name, TOK_LENGTH + 10, alt_sound_file_name);
            } 


Hacky, untested.

[Nero-sama]

aight, will try it out. Thanks
EDIT: I probably could have figured that out on my own, but I'm not a programmer so I'm afraid I'll just break it, and the amxmodx language is visual aids to me ;_;

EDIT2:sank_sounds.sma(2272) : warning 217: loose indentation

lol wat

[gabuch2]

Originally Posted by Nero-sama EDIT2:sank_sounds.sma(2272) : warning 217: loose indentation

Ignore it, it shouldn't cause any problem.