[seriousspot]

crash dump:

Uploading dump (in-process) [proxy ''] /tmp/dumps/crash_20130818233030_1.dmp success = yes response: CrashID=bp-399c0ee9-1330-4879-bd54-1ce752130818 Segmentation fault

version:

version Protocol version 48 Exe version 1.1.2.7/Stdio (cstrike) Exe build: 10:03:21 Aug 8 2013 (6132)

meta list:

meta list Currently loaded plugins: description stat pend file vers src load unlod [ 1] AMX Mod X RUN - amxmodx_mm_i386. v1.8.3-d ini Start ANY [ 2] Fun RUN - fun_amxx_i386.so v1.8.3-d pl1 ANY ANY [ 3] CStrike RUN - cstrike_amxx_i38 v1.8.3-d pl1 ANY ANY [ 4] CSX RUN - csx_amxx_i386.so v1.8.3-d pl1 ANY ANY [ 5] Ham Sandwich RUN - hamsandwich_amxx v1.8.3-d pl1 ANY ANY [ 6] FakeMeta RUN - fakemeta_amxx_i3 v1.8.3-d pl1 ANY ANY [ 7] Engine RUN - engine_amxx_i386 v1.8.3-d pl1 ANY ANY 7 plugins, 7 running

meta version:

meta version Metamod v1.21-am 2013-03-15 (5:13) by Will Day <[email protected]> http://www.metamod.org/ compiled: Mar 15 2013, 150:22 -0500 (optimized)

code:

PHP Code:

public event_alive_frags_t () {
    if (is_game_started == false) {
        return 1
    }
    
    if (is_game_started == true) {
    
        for (integer = 1; integer <= cache_maxplayers; integer += 1) {
            new id = integer
            
            if (get_pdata_int(id, pdata_team_offset) == TEAM_TERRORIST && cache_is_connected[id] == true && cache_is_bot[id] == false && cache_is_hltv[id] == false && cache_is_alive[id] == true && is_game_runing == true) {
                static Float:frags
            
                pev(id, pev_frags, frags)
                set_pev(id, pev_frags, frags + float(alive_t_frags))
            }
        }
    }
    return 0
} 


global pcvar alive_t_frag cached on hltv round start event

function public event_alive_frags_t () called when terrorist win or in hostiges not resqued txt hooked events, any ideas?

[ConnorMcLeod]

Nothing to do with game update, your code is bad.

The loop way shouldn't be used, because with those kind of loops, you need to check if each players is connected, this is the thing you don't check and when you try to retrieve pdata, it generates errors or crashes.

Anyway, use get_players, so you can retrieve a list of connected players, and if you use filters, you can retrieve all TERRORIST at once.

[seriousspot]

Originally Posted by ConnorMcLeod Nothing to do with game update, your code is bad. The loop way shouldn't be used, because with those kind of loops, you need to check if each players is connected, this is the thing you don't check and when you try to retrieve pdata, it generates errors or crashes. Anyway, use get_players, so you can retrieve a list of connected players, and if you use filters, you can retrieve all TERRORIST at once.

WRONG - theres nothing todo with loop, my method - get_maxplayers is more efficient than get_players since i cached all events for each index in right events also get_players sometimes returning false values, this only small part of the code, i am using like 9 loops per all code, have no crashes, rock stable 24/7.

[ConnorMcLeod]

Originally Posted by seriousspot WRONG - theres nothing todo with loop, my method - get_maxplayers is more effiecient than get_players since i cached all events for each index in right events also get_players sometimes returning false values, this only small part of the code, i am using like 9 loops per all code, have no crashes, rock stable 24/7.

Then it is fine, what was your thread about ?

[seriousspot]

Originally Posted by ConnorMcLeod Then it is fine, what was your thread about ?

i am not expierenced in fakemeta, i think there's something wrong i did with it.

[ConnorMcLeod]

Look how this :

PHP Code:

public event_alive_frags_t () {
    if (is_game_started == false) {
        return 1
    }
    
    if (is_game_started == true) {
    
        for (integer = 1; integer <= cache_maxplayers; integer += 1) {
            new id = integer
            
            if (get_pdata_int(id, pdata_team_offset) == TEAM_TERRORIST && cache_is_connected[id] == true && cache_is_bot[id] == false && cache_is_hltv[id] == false && cache_is_alive[id] == true && is_game_runing == true) {
                static Float:frags
            
                pev(id, pev_frags, frags)
                set_pev(id, pev_frags, frags + float(alive_t_frags))
            }
        }
    }
    return 0
} 


should look, and you gonna understand how get_players is better then 1 - maxplayers loops :

PHP Code:

public event_alive_frags_t ()
{
    if (is_game_started )
    {
        new players[32], count, id
        get_players(players, count, "ae", "TERRORIST")
        for(--count; count>=0; count--)
        {
            id = players[ count ];
            set_user_frags(id, get_user_frags(id) + alive_t_frags);
        }
    }
} 


[seriousspot]

Originally Posted by ConnorMcLeod Look how this : PHP Code: public event_alive_frags_t () {     if (is_game_started == false) {         return 1     }          if (is_game_started == true) {              for (integer = 1; integer <= cache_maxplayers; integer += 1) {             new id = integer                          if (get_pdata_int(id, pdata_team_offset) == TEAM_TERRORIST && cache_is_connected[id] == true && cache_is_bot[id] == false && cache_is_hltv[id] == false && cache_is_alive[id] == true && is_game_runing == true) {                 static Float:frags                              pev(id, pev_frags, frags)                 set_pev(id, pev_frags, frags + float(alive_t_frags))             }         }     }     return 0 }  should look, and you gonna understand how get_players is better then 1 - maxplayers loops : PHP Code: public event_alive_frags_t () {     if (is_game_started )     {         new players[32], count, id         get_players(players, count, "ae", "TERRORIST")         for(--count; count>=0; count--)         {             id = players[ count ];             set_user_frags(id, get_user_frags(id) + alive_t_frags);         }     } }

can you please post benchmarks wich is better? because the thing is this mean nothing to me, thanks


By the way figured out what was wrong, i take get user team statement from whole statement

PHP Code:

public event_alive_frags_t () {
    if (is_game_started == false) {
        return 1
    }
    
    if (is_game_started == true) {
    
        for (integer = 1; integer <= cache_maxplayers; integer += 1) {
            new id = integer
            
            if (cache_is_connected[id] == true && cache_is_bot[id] == false && cache_is_hltv[id] == false && cache_is_alive[id] == true && is_game_runing == true) {
                if (get_pdata_int(id, pdata_team_offset) == TEAM_TERRORIST) {    
                
                    static Float:frags
                
                    pev(id, pev_frags, frags)
                    set_pev(id, pev_frags, frags + float(alive_t_frags))
                    
                    // Connors way
                    //set_user_frags(id, get_user_frags(id) + alive_t_frags)
                }
            }
        }
    }
    return 0
} 


and theres another question, is there any diffrence between - get_pdata_int(id, pdata_team_offset) and get_user_team(id) ?

[ConnorMcLeod]

This is your plugin, your job to benchmark if you don't believe me.

But suppose there are 10 players alive :

Your code : 10 * get_pdata_int calls
get_players : 1 * get_players

[r0ck]

About get_players ConnorMcLeod , I have experience a lot of false returns .. So ( In my PLugin ) i had to remove all get_players with get_maxplayers with loop... (never bugged after that)
I have read a lot that get_players is efficient but it returns false results

The interesting part is this once it bugs ( returns false results ) it doesnt work till we dont restart server, map restart also doesnt works.

I have only checked get_players with team check , maybe thats what it bugs it ?
Can the reason be multimods ? Running different mods in a server ...

[dFF]

@r0ck, you was used get_players in zombie mod ? Explain better (with some code example if you can) what is the problem exactly.
Maybe sometimes get_players with team-flag can result wrong in zombie mod, because zombiemod change team a lot of times and can't be updately instantly.. or somethings like this (with some private datas, scoreboard, etc.).