[Silvers]

Originally Posted by user2000 sourcemod 1.11.0.6711 metamod 11.0-dev+1143V maybe i have to update my sourcemod?

Try it, let me know.

Originally Posted by tRololo312312 Getting crashes since updating Left 4 Dhooks. https://crash.limetech.org/ei3lwu5zkogx https://crash.limetech.org/pamhaxdntnbj https://crash.limetech.org/dwrshy7fqaqm EDIT: Oops i was supposed to post this under L4DD thread... Anyway, the crash seems to come from IsReachable.

I moved the post.

Which plugin is using this? You can PM me link/source if it's private. I can't see anything wrong with the function so long a Survivor Bot is calling it (and I added checks to prevent anything else using). Might have to remove or see check for a replacement function. Which game, l4d2? I'll double check windows signature at some point to verify it's calling the correct function. Does it happen on first use or randomly at some point? Maybe the Survivor is dead or something?

Edit: Turns out spcomp didn't get replaced when I updated even though I specifically updated those. Anyway I see the error now and will fix for next release. Thanks.

[user2000]

Originally Posted by Silvers Try it, let me know.

with which version of sourcemod exactly you use it, because I have tried with

sourcemod-1.11.0 6820
sourcemod-1.11.0 6814
sourcemod-1.11.0 6813
sourcemod-1.11.0 6810
sourcemod-1.11.0 6809

and I have this error:

//// left4dhooks.sp // // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(1353) : error 183: brackets after variable name indicates a fixed-size array, but size is missing or not constant // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(1354) : error 183: brackets after variable name indicates a fixed-size array, but size is missing or not constant // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(1355) : error 183: brackets after variable name indicates a fixed-size array, but size is missing or not constant // // 3 Errors. // // Compilation Time: 0.33 sec // ----------------------------------------

and with the version sourcemod-1.11.0.6724 I get

//// left4dhooks.sp // // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(154) : error 009: invalid array size (negative, zero or out of bounds) // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(163) : error 010: invalid function or declaration // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(1541) : error 009: invalid array size (negative, zero or out of bounds) // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(1599) : error 010: invalid function or declaration // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(1601) : error 009: invalid array size (negative, zero or out of bounds) // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(1636) : error 010: invalid function or declaration // E:\JuegosSteam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\inclu de\left4dhooks_stocks.inc(1672) : error 010: invalid function or declaration // // 7 Errors. // // Compilation Time: 0.28 sec // ---------------------------------------- Press enter to exit ...

[Silvers]

Originally Posted by user2000 -snip-

Originally Posted by Silvers Edit: Turns out spcomp didn't get replaced when I updated even though I specifically updated those. Anyway I see the error now and will fix for next release. Thanks.

Edit fixed:

1.75 (18-Nov-2021)
    - Fixed forward "L4D2_OnHitByVomitJar" throwing errors about null pointer.
    - Forwards "L4D_OnVomitedUpon" and "L4D2_OnHitByVomitJar" attacker can now be reported as 0.

    - "left4dhooks_silver.inc" include:
        - Deprecated stock "L4D_IsPlayerIncapped".

    - "left4dhooks_stocks.inc" include:
        - Renamed the stock "L4D_HasAnySurvivorLeftSafeArea" to "L4D_HasAnySurvivorLeftSafeAreaStock" (the native "L4D_HasAnySurvivorLeftSafeArea" still exists).
        - Fixed compile errors on SourceMod version 1.11. Thanks to "user2000" for reporting.
        - Replaced indentation spaces with tabs.

    - Note: "#include <left4dhooks>" will load all <left4dhooks_*> includes. Other "#include <left4dhooks_*>" will attempt to load each other if included on their own.
    - Only required to use "#include <left4dhooks>" for all features and stocks availability.

    - Plugin and Include files updated.

[Tank Rush]

I'm using l4d2_tank_announce.sp and have this error in the logs

L 11/18/2021 - 20:11:22: SourceMod error session started
L 11/18/2021 - 20:11:22: Info (map "c2m1_highway") (file "D:\Program Files\Steam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\logs\errors_20211118.log")
L 11/18/2021 - 20:11:22: [SM] Exception reported: Function signature "ZombieManager::SpawnTank" was not found.
L 11/18/2021 - 20:11:22: [SM] Blaming: optional\l4d2_tank_announce.smx
L 11/18/2021 - 20:11:22: [SM] Call stack trace:
L 11/18/2021 - 20:11:22: [SM]   [0] DHookCreateFromConf
L 11/18/2021 - 20:11:22: [SM]   [1] Line 38, D:\Program Files\Steam\steamapps\common\Left 4 Dead 2\left4dead2\addons\sourcemod\scripting\l4d2_tank_announce.sp::OnPluginStart
L 11/18/2021 - 20:11:26: Error log file session closed.

from gamedata left4dhooks.l4d2.txt

my operating system is windows 10, for L4D2

[Shadowysn]

At least two people have told me they're having errors about failing to find the signature for Music::Play in the gamedata:
user2000 and Edison1318 (in private messaging)

The reported L4DHooks version used by user2000 is 1.74, but there's no mention of fixing the gamedata sigs in 1.75 so this may still be unfixed?

[Silvers]

1.76 (20-Nov-2021)
    - Fixed native "L4D2_IsReachable" using a bad signature. Thanks to "tRololo312312" for reporting.
    - Wildcarded the "Music::Play" signatures to be compatible with plugins detouring. Thanks to "user2000", "Edison1318" and "Shadowysn" for reporting.
    - Wildcarded the "ZombieManager::SpawnTank" signatures to be compatible with plugins detouring. Thanks to "Tank Rush" for reporting.

    - L4D1 and L4D2 GameData files updated.

This should fix the issues reported.

[fdxx]

I don't know why, using L4D_OnEnterGhostStatePre alone does not work.
It can work if you use L4D_OnEnterGhostStatePre and L4D_OnEnterGhostState together.

PHP Code:

// Use L4D_OnEnterGhostStatePre alone
public Action L4D_OnEnterGhostStatePre(int client)
{
    LogMessage("%N L4D_OnEnterGhostStatePre", client); // not work
    return Plugin_Continue;
} 


PHP Code:

// Use L4D_OnEnterGhostState alone
public void L4D_OnEnterGhostState(int client)
{
    LogMessage("%N L4D_OnEnterGhostState post", client); // work
} 


PHP Code:

// Use L4D_OnEnterGhostStatePre and L4D_OnEnterGhostState together
public Action L4D_OnEnterGhostStatePre(int client)
{
    LogMessage("%N L4D_OnEnterGhostStatePre", client); // work
    return Plugin_Continue;
}

public void L4D_OnEnterGhostState(int client)
{
    LogMessage("%N L4D_OnEnterGhostState post", client); // work
} 


Linux
L4D2
sourcemod 1.11.0.6806
left4dhooks 1.76

[Silvers]

Thanks for the report will have a look.

Edit: it's the recent changes I made to the functions checking for required detours. The whole things a mess and should be re-written but I don't know how else to make it. I will fix the issue for the next version.

Excellent find, thank you for reporting. Seems 1 line messed it up, hopefully this now works without any other issues. I tested several different cases, only enabling 1 of each and both together. Seems all is working correctly and reporting the correct detours/plugins using them with the command sm_l4dd_detours.

1.77 (21-Nov-2021)
    - Fixed not detouring some functions when only 1 detour was used instead of both pre and post. Thanks to "fdxx" for reporting.

This update is probably quite critical. This bug has been present since either version 1.63 or 1.71.

[Silvers]

1.78 (23-Nov-2021)
    - Added forwards "L4D_OnSpawnSpecial_Post", "L4D_OnSpawnTank_Post", "L4D_OnSpawnWitch_Post" and "L4D2_OnSpawnWitchBride_Post". Requested by "A1m".
    - Added stocks "GetAnyRandomClient", "GetRandomSurvivor" and "GetRandomInfected" to the "left4dhooks_silver.inc" include file.

    - Updated: Plugin and Test plugin.
    - Updated: "left4dhooks.l4d1" and "left4dhooks.l4d2" GameData files.
    - Updated: "left4dhooks.inc" and "left4dhooks_silver.inc" Include files.

1.79 (23-Nov-2021)
    - Changed forward "L4D_OnSpawnSpecial_Post" prototype to remove the reference variable.

    - Updated: Plugin and Test plugin.
    - Updated: "left4dhooks.inc" Include file.

[fdxx]

PHP Code:

L 11/23/2021 - 10:23:48: [SM] Exception reported: Invalid parameter or parameter type
L 11/23/2021 - 10:23:48: [SM] Blaming: new/left4dhooks.smx
L 11/23/2021 - 10:23:48: [SM] Call stack trace:
L 11/23/2021 - 10:23:48: [SM]   [0] Call_PushCellRef
L 11/23/2021 - 10:23:48: [SM]   [1] Line 8593, C:\Servers\L4D2\left4dead2\addons\sourcemod\scripting\left4dhooks.sp::DTR_ZombieManager_SpawnSpecial_Post
L 11/23/2021 - 10:23:48: [SM]   [3] FakeClientCommand
L 11/23/2021 - 10:23:48: [SM]   [4] Line 1298, new/l4d2_dev_menu.sp::CheatCommand
L 11/23/2021 - 10:23:48: [SM]   [5] Line 369, new/l4d2_dev_menu.sp::SpawnSpecial_ClassSelect_MenuHandler 


Linux
L4D2
sourcemod 1.11.0.6806
left4dhooks 1.79