[Grovliom]

Drums

Version 1.0 :

First version of the drums plugin.

Version 1.1 :

Improved the code.

Version 1.1.0 :

Optimized the code.

Version 1.1.1 :

Optimized the code, again.

Video :

https://www.youtube.com/watch?v=dGm1-LSQ6LI

Command :
Type in console : d_menu

[Napoleon_be]

Poorly coded, could be optimized a lot. Save your paths in a 2D array. use the menu_additem() info parameter to pass info into it, this way the switch() could be removed and a lot of code will become unnessecary. Also please don't hardcode array lengths, use charsmax() instead. U could use menu_display() just once, just check if item != MENU_EXIT.

Remove the .amxx file from your post, it's not allowed to post .amxx files.

[Grovliom]

Originally Posted by Napoleon_be Poorly coded, could be optimized a lot. Save your paths in a 2D array. use the menu_additem() info parameter to pass info into it, this way the switch() could be removed and a lot of code will become unnessecary. Also please don't hardcode array lengths, use charsmax() instead. U could use menu_display() just once, just check if item != MENU_EXIT. Remove the .amxx file from your post, it's not allowed to post .amxx files.

im just a beginer trying to learn. i will try to optimize it, but what is charsmax()

[thEsp]

Neat idea but in my opinion not worth approving.

[Napoleon_be]

PHP Code:

menu_item_getinfo(menu, item, access, data, 8, iName, 63, callback); 


-->

PHP Code:

menu_item_getinfo(menu, item, access, data, charsmax(data), iName, charsmax(iName), callback); 


[Craxor]

Charmax is defined in amxx include library, You can open and read anytime to learn new things .

[Grovliom]

Ok! i Improved the code a bit...

[Napoleon_be]

Looks much better. You could actually just remove this part:

PHP Code:

new data[8], iName[64];
    new access, callback;
    menu_item_getinfo(menu, item, access, data, charsmax(data), iName, charsmax(iName), callback);
    new key = str_to_num(data); 


and use this:

PHP Code:

client_cmd(id, "spk %s", drums[item]); 


This way, you just eliminated the switch() and extra useless typing.

EDIT:

Did you test your plugin before updating the thread? This won't work

PHP Code:

public plugin_precache()
{
    precache_sound(drums[0][0]) //Precache the drum samples
} 


Use a for() loop instead.

Also, this isn't nessecary, since you already check if player didn't press MENU_EXIT.

PHP Code:

if(item == MENU_EXIT) // if pressed MENU_EXIT or 0 it destroys the menu
    {
        menu_destroy(menu);
        return PLUGIN_HANDLED
    } 


Just simply destroy the menu at the end of the function.

[Grovliom]

Originally Posted by Napoleon_be Looks much better. You could actually just remove this part: PHP Code: new data[8], iName[64];     new access, callback;     menu_item_getinfo(menu, item, access, data, charsmax(data), iName, charsmax(iName), callback);     new key = str_to_num(data);  and use this: PHP Code: client_cmd(id, "spk %s", drums[item]);  This way, you just eliminated the switch() and extra useless typing. EDIT: Did you test your plugin before updating the thread? This won't work PHP Code: public plugin_precache() {     precache_sound(drums[0][0]) //Precache the drum samples }  Use a for() loop instead. Also, this isn't nessecary, since you already check if player didn't press MENU_EXIT. PHP Code: if(item == MENU_EXIT) // if pressed MENU_EXIT or 0 it destroys the menu     {         menu_destroy(menu);         return PLUGIN_HANDLED     }  Just simply destroy the menu at the end of the function.

i tested the plugin and it worked really good! no errors and no warnings.. i will optimize it more if you want!

[thEsp]

i tested the plugin and it worked really good! no errors and no warnings.. i will optimize it more if you want!

Make sure players download the sounds if they don't have them already.

for (new iSound = 0; iSound < sizeof(drums); iSound++)
    precache_sound(drums[iSound]);