[indraraj striker]

This is useful as owner dont want to give permission of certain cvars to admin only basic sv_restart 1 etc

PHP Code:

 cvar_on = register_cvar("testing_cvar","1"); 


this should be like this

PHP Code:

 cvar_on = register_cvar("testing_cvar","1",ADMIN_IMMUNITY); 


PHP Code:

#include <amxmodx> 

new cvar_on; 

public plugin_init() 
{ 
    register_clcmd("say /test","show_test"); 
    //this cvar should be change by ADMIN_IMMUNITY ONLY 
    cvar_on = register_cvar("testing_cvar","1"); 
} 

public show_test(id) 
{ 
    if(get_pcvar_num(cvar_on)) 
    { 
        client_print(id,print_chat,"command is working"); 
    } 
    else 
    { 
        client_print(id,print_chat,"command is not working") 
    } 
} 


Link : https://forums.alliedmods.net/showthread.php?t=289402

[shehzad1234]

working on 1.8.2 ??

[shehzad1234]

and 1.8.1 ???

[fysiks]

Originally Posted by shehzad1234 working on 1.8.2 ??

Originally Posted by shehzad1234 and 1.8.1 ???

No. This will never be implemented because it doesn't really make any sense.

A better method would be to modify the amx_cvar command validate a request to change a cvar. The command can check a file to check permissions and allow or deny the request.

[shehzad1234]

Originally Posted by fysiks No. This will never be implemented because it doesn't really make any sense. A better method would be to modify the amx_cvar command validate a request to change a cvar. The command can check a file to check permissions and allow or deny the request.

thanks bro

[Arkshine]

That's not necessarily a bad request. amx_cvar hard codes a check to enforce the use of sv_password with ADMIN_PASSWORD flag. I guess it would be possible to generalize that at cvar registration scope (or a new native) in order to tailor the permissions of this command and having the access flags generated in a cvaraccess:ini file similar to the commands.

[fysiks]

If you do exactly has he is suggesting, you'd have to pass the entity index (id) to all of the [get|set]_[p]cvar_[]() functions. Then, you'd have to find a way to pass out the success or failure without completely destroying backwards compatibility.

For these reasons, I don't think it should be implemented in a native like this. The only place that permissions is relevant (the way that he's suggesting) is when using the amx_cvar command. Therefore, this should be implemented in the amx_cvar command with the permissions list coming from a file similar to cmdaccess.ini.

[addons_zz]

> to find a way to pass out the success or failure without completely destroying backwards compatibility.

Break the plugin execution when someone call the cvar without the required access level. It would be something like, there is no cvar registered error when someone try to access an nonexisting cvar. It kinda makes sense, if you do not have access to the cvar, it is like the cvar does not exist to you and the exception should be throw. But in our case, we do not literally throw an exception, we just cut the execution.

[fysiks]

Stopping execution if it fails is not an option. What if I have code that I need to run regardless of it passing or failing?? Therefore, that is not an option.

[addons_zz]

You right, easily can leak to memory leaks as not closing a file pointer. Therefore it can be done on plugin level the the programmer checking the the user has the specific flag before call the `cvar`. This way the programmer may handle correctly to close file pointers or whatever he needs to.

Moreover sticking with the option to add the access level on the cvar creation to restrict the access on the command `amx_cvar` seems a good option. We may instead of receive the level on the `register_cvar` command and use it, later will get some work to propagate it until `amx_cvar` hard coded value for `ADMIN_CVAR`.

Anyways I do not know whether it is worth to implement right away or not. I would say check the Issue Tracker and see what is on the queue prioritizing the bugs Issues as I prefer a not so big project/features working good than a big project/features filled bugs.