[StayOx]

I need help, I'm trying to create a function to verify the value of the client cvar "cl_downloadfilter". that cvar use values: none, all, mapsonly, nosound.

I'm struggling to check these values ​​and the value of convar is not "all" plugin print a message for client.

PHP Code:

 
#define CVAR_ALL = "all";
 
public Action:Timer_QueryClient(Handle:timer, any:client)
{
 g_hTimer_Query[client] = INVALID_HANDLE;
 if(IsClientInGame(client))
 {
  QueryClientConVar(client, "cl_downloadfilter", ConVarQueryFinished:ClientConVar, client);
 }
 return Plugin_Continue;
}
public ClientConVar(QueryCookie:cookie, client, ConVarQueryResult:result, const String:cvarName[], const String:cvarValue[])
{
 if(g_bEnabled && IsClientInGame(client))
 {
  if(result == ConVarQuery)
  {
   new bool:_bCurrent = StringToInt(cvarValue);
   if(cvarValue) != CVAR_ALL)
 
   if(_bCurrent != g_bDisabled[client])
   { 


[Powerlord]

It'd help if you posted what the compiler's error message was.

However, just from glancing at the code, you have two errors (one syntax, one logic) on this line:

if(cvarValue) != CVAR_ALL)

[StayOx]

Yes, however I really can not find a way to do this correctly. please the the spoiler

Spoiler

//SourceMod Batch Compiler
// by the SourceMod Dev Team

//// sm_force_fastdl_filter.sp
// C:\Users\ESR\Documents\Plugins Compiler\sm_force_fastdl_filter.sp(154) : warn
ing 213: tag mismatch
// C:\Users\ESR\Documents\Plugins Compiler\sm_force_fastdl_filter.sp(155) : erro
r 029: invalid expression, assumed zero
// C:\Users\ESR\Documents\Plugins Compiler\sm_force_fastdl_filter.sp(155) : warn
ing 215: expression has no effect
// C:\Users\ESR\Documents\Plugins Compiler\sm_force_fastdl_filter.sp(155) : erro
r 029: invalid expression, assumed zero
// C:\Users\ESR\Documents\Plugins Compiler\sm_force_fastdl_filter.sp(155 -- 157)
 : warning 215: expression has no effect
// C:\Users\ESR\Documents\Plugins Compiler\sm_force_fastdl_filter.sp(157) : erro
r 001: expected token: ";", but found "if"
// C:\Users\ESR\Documents\Plugins Compiler\sm_force_fastdl_filter.sp(157) : fata
l error 127: too many error messages on one line
//
// Compilation aborted.
// 4 Errors.
//
// Compilation Time: 0,16 sec
// ----------------------------------------
Press enter to exit ...

[RedSword]

Strings are not built-in SourcePawn. What you're having is a char array. Therefore you can't use

"str" == "str"

directly like in some other languages.

You probably want to use StrEqual or StrContains.

[StayOx]

Originally Posted by RedSword Strings are not built-in SourcePawn. What you're having is a char array. Therefore you can't use directly like in some other languages. You probably want to use StrEqual or StrContains.

thank you very much, despite the links have not worked you reminded me it existed

PHP Code:

public ConVar_QueryClient(QueryCookie:cookie, client, ConVarQueryResult:result, const String:cvarName[], const String:cvarValue[])
{
       if(g_bEnabled && IsClientInGame(client))
       {
             if(result == ConVarQuery_Okay)
             {
                  new bool:_bCurrent = StrContains("all", cvarValue) ? true : false;
                  if(_bCurrent != g_bDisabled[client])
                  {
 
                         /// code continue.... 


damn, I need to write everything not to forget ?!

Thanks for all

[sheo]

You should replace "StrContains("all", cvarValue) ? true : false;" by "StrContains("all", cvarValue) != -1 ? true : false;"

[Mitchell]

Originally Posted by sheo You should replace "StrContains("all", cvarValue) ? true : false;" by "StrContains("all", cvarValue) != -1 ? true : false;"

Not sure if necessary, but adding parentheses may also help keep clean code

new bool:bStatement = (StrContains("all", cvarValue) != -1) ? true : false;

[Dr. McKay]

PHP Code:

new bool:bStatement = StrContains("all", cvarValue) != -1; 


Boolean comparisons already return a bool, no need to do a ternary conditional.

[Mitchell]

Originally Posted by Dr. McKay PHP Code: new bool:bStatement = StrContains("all", cvarValue) != -1;  Boolean comparisons already return a bool, no need to do a ternary conditional.

Good point.

[StayOx]

in my case the function should search only the value of the cvar "all" if the player set to any other value a message is shown every 5 seconds for him.