[rekcah]

i was trying to think of ways to give infected players new abilities that can also encourage them to play with a higher level of skill.

this plugin rewards hunters who can pull off long distance pounces.

when a hunter lands a pounce with a distance over 500 it creates an impact crater, plays an explosion sound, flings all survivors in the area away and they take 20 damage.

i left in my testing command !testhit that admins can use to see what it actually does when a hunter lands.

[KRUTIK]

when compiled on 1.9 E:\sourcemod\addons\sourcemod\scripting\meteo r hunter.sp(24) : warning 203: symbol is never used: "hunter"

[HarryPotter]

wait, you have signature?
so this plugin only works in linux?

PHP Code:

stock L4D2_Fling(target, Float:vector[3], attacker, Float:incaptime = 3.0)
{
    new Handle:MySDKCall = INVALID_HANDLE;    
    StartPrepSDKCall(SDKCall_Player);
    PrepSDKCall_SetSignature(SDKLibrary_Server, "@_ZN13CTerrorPlayer5FlingERK6Vector17PlayerAnimEvent_tP20CBaseCombatCharacterf", 0);

    PrepSDKCall_AddParameter(SDKType_Vector, SDKPass_ByRef);
    PrepSDKCall_AddParameter(SDKType_PlainOldData, SDKPass_Plain);
    PrepSDKCall_AddParameter(SDKType_CBasePlayer, SDKPass_Pointer);
    PrepSDKCall_AddParameter(SDKType_Float, SDKPass_Plain);

    MySDKCall = EndPrepSDKCall();
    if(MySDKCall == INVALID_HANDLE)
    {
        LogError("Could not prep the Fling function");
    }
    
    SDKCall(MySDKCall, target, vector, 76, attacker, incaptime); //76 is the 'got bounced' animation in L4D2
} 


[Silvers]

This code is really really bad sorry to say.

1. Old syntax.
2. Hard coding signatures is bad, use a gamedata file.
3. Your "MySDKCall" is leaking handles, you should only prep the SDKCalls in plugin start storing handle in global variable. Right now you're constantly prepping on use which is bad.
4. See left4dhooks for windows and linux signature, why are you only including linux signature? These have been known for ages.
5. You're leaking the TR_TraceRayFilterEx handle - creating memory leak.
6. Redundant "IsValidEntity" check in player loop.
7. Using old "PrecacheParticle" method, see any of my plugins with effects for better method.
8. Using old "HurtEntity" method, see various plugins of mine for "SDKHooks_TakeDamage" method.
9. Not using entity references in timers to delete entities (so you'll inadvertently delete something else).
10. Using "return Plugin_Stop" in timer callback when it's not a repeating timer, unnecessary.
11. You have multiple warnings: "warning 234: symbol "FloatMul" is marked as deprecated: This native is internal implementation. For multiplication use the '*' operator."
12. Your "Plugin myinfo" section is weirdly placed half way through the script, standard practice is at the top of script.

[rekcah]

added the window signatures and fixed a few of the other issues silvers listed.
my code is still probably pretty bad tho

[HarryPotter]

I love the idea of this plugin, and want to put it in my server, so I remake code.
Hope you don't mind.

Updated:
Remake code, thanks to Silvers and Lux

-Convar-

Spoiler

cfg/sourcemod/l4d_meteor_hunter.cfg

PHP Code:

// 0=Plugin off, 1=Plugin on.
l4d_meteor_hunter_allow "1"

// Damage caused by meteor strike.
l4d_meteor_hunter_damage "15.0"

// Hunter Pounce Distance needed to trigger meteor strike.
l4d_meteor_hunter_distance "800"

// Turn on the plugin in these game modes, separate by commas (no spaces). (Empty = all).
l4d_meteor_hunter_modes ""

// Turn off the plugin in these game modes, separate by commas (no spaces). (Empty = none).
l4d_meteor_hunter_modes_off ""

// Turn on the plugin in these game modes. 0=All, 1=Coop, 2=Survival, 4=Versus, 8=Scavenge. Add numbers together.
l4d_meteor_hunter_modes_tog "0"

// How much force is applied to the survivor (meteor strike).
l4d_meteor_hunter_power "300"

// Hunter meteor strike range.
l4d_meteor_hunter_range "200"

// Vertical force multiplier (meteor strike).
l4d_meteor_hunter_vertical_mult "1.5" 


-Edit-
Latest version always here

[Silvers]

@fbef0102: your version is leaking handles in "CreateRing" - missing "delete hPack".

[HarryPotter]

Originally Posted by Silvers @fbef0102: your version is leaking handles in "CreateRing" - missing "delete hPack".

Mabye I got wrong, I thought CreateTimer would automatically delete hPack,
do not need to call CloseHandle() only when using "CreateDataTimer"?

[Lux]

Originally Posted by fbef0102 Mabye I got wrong, I thought CreateTimer would automatically delete hPack, do not need to call CloseHandle() only when using "CreateDataTimer"?

PHP Code:

CreateTimer(0.3,CreateRing,hbPack,TIMER_FLAG_NO_MAPCHANGE|TIMER_DATA_HNDL_CLOSE); 


PHP Code:

#define TIMER_REPEAT            (1<<0)      /**< Timer will repeat until it returns Plugin_Stop */
#define TIMER_FLAG_NO_MAPCHANGE (1<<1)      /**< Timer will not carry over mapchanges */
#define TIMER_HNDL_CLOSE        (1<<9)      /**< Deprecated define, replaced by below */
#define TIMER_DATA_HNDL_CLOSE   (1<<9)      /**< Timer will automatically call CloseHandle() on its data when finished */ 


[HarryPotter]

Originally Posted by Lux PHP Code: CreateTimer(0.3,CreateRing,hbPack,TIMER_FLAG_NO_MAPCHANGE|TIMER_DATA_HNDL_CLOSE);  PHP Code: #define TIMER_REPEAT            (1<<0)      /**< Timer will repeat until it returns Plugin_Stop */ #define TIMER_FLAG_NO_MAPCHANGE (1<<1)      /**< Timer will not carry over mapchanges */ #define TIMER_HNDL_CLOSE        (1<<9)      /**< Deprecated define, replaced by below */ #define TIMER_DATA_HNDL_CLOSE   (1<<9)      /**< Timer will automatically call CloseHandle() on its data when finished */

Thanks, Lux, one more question, what if I use CreateDataTimer?
should I also write TIMER_DATA_HNDL_CLOSE?

PHP Code:

CreateDataTimer(0.3,CreateRing,hbPack,TIMER_FLAG_NO_MAPCHANGE|TIMER_DATA_HNDL_CLOSE);