[Dragokas]

Originally Posted by Dominatez This no longer works either. Crashes to desktop (L4D1)

It's somehow related to server hardware. I remember when I tested absolutely identical set of plugins and settings on 2 different Linux machines. First one always crashes client applications, Second - never. That's happened on old plugin version with non-SDK activation method.

Originally Posted by sonic155 Please add to the notes that this plugin changes/adds binds to your game without letting you know before hand thank you -.-

It does not, if you have a licensed version of the game.
But, ok.

Updated.

1.7.7 (07-Nov-2022) - Removed binds. - Fixed compilation warnings on SM 1.11. 1.7.6 (22-Nov-2021) - Fixed ConVar error in L4D2. 1.7.5 (21-Nov-2021) - Integration with VIP Core (by R1KO).

[Dominatez]

Firstly - THANK YOU SO MUCH FOR THE AWESOME PLUGINS YOU DO and the help you give on here.

I am running the server on a ubuntu 20.04LTS server and the server doesn't crash at all, it is my client. It always crashes me to desktop when it changes map when the laser is on. Every single time. I have tried and tested it, but cannot get it working. Even on a vanilla server, it crashes me to desktop every time (Windows 10 for Gaming, Ubuntu for all other chores) and (L4D1)

I wonder why it is just the laser that is causing massive headaches for everyone. The plugin works great if i remove the code with the laser in it.

Do you have any ideas as to how to get the laser to function ?

Originally Posted by Dragokas It's somehow related to server hardware. I remember when I tested absolutely identical set of plugins and settings on 2 different Linux machines. First one always crashes client applications, Second - never. That's happened on old plugin version with non-SDK activation method. It does not, if you have a licensed version of the game. But, ok. Updated.

[Dragokas]

Yeah, I know that it's client crashes, which is even more complicates things, because not much ways to fix.
Unfortunately I don't have any recommendations other than try changing the server, it's somehow help the fix client.
Maybe also try to play with different network settings (e.g. different tick and so) on server and video settings on client.

[Sunyata]

Just a quick question: is there any way to disable the perks upgrade sound?

I'm referring to the "orch_hit_Csharp_short.wav" at this folder location:

"STEAM\steamapps\common\left 4 dead\left4dead\sound\player"

This is the sound file players get to hear at the start of each new map.

I'd like to disable this sound for all the clients. Im not sure what is involved to do this. Does it involve commenting out one of the cryptic lines of code in the script? Or would it involve another script to disable the above sound file?

Sunyata

[Dragokas]

If you know the exact sound name, you may block the sound by hook,
see: Silver's tuto, item 7. Sound Hooks

As about perk sound, as far as I can remember, it is a call located in the one of the perk activation functions, it can be disabled by NOP-ing it (patch the memory).

[Dragokas]

Here it is:

char *__cdecl CTerrorPlayer::AddUpgrade(CBaseEntity *a1, int a2)
{
...
      UTIL_SayTextAll(CTerrorPlayer::AddUpgrade(SurvivorUpgradeType)::msg, 0, 0);
      CCSPlayer::EmitPrivateSound(a1, "Player.AwardUpgrade");
      v9 = (KeyValues *)KeyValues::operator new((KeyValues *)&dword_24);
...
}

[Dragokas]

Ahh, I already patched that call.

The fact is Left 4 Dead 2 emit 3 sounds for upgrade:
1) The short loud low one (which I already patched above).
2) The continuous quiet high (which I don't know where is located, maybe in gameeventmanager).
3) sometimes 3rd sound related to game hint instructor (together with on screen hint).

Unless, somebody know where the call is located exactly here, I don't have time for that kind of experiments, sorry.

disassembly

int __usercall CTerrorPlayer::AddUpgrade@<eax>(long double a1@<st2>, long double a2@<st1>, long double a3@<st0>, CCSPlayer *a4, int a5)
{
  int *v5; // edi
  int v6; // eax
  int v8; // eax
  int v9; // eax
  const char *v10; // eax
  const char *v11; // eax
  void (__cdecl *v12)(CCSPlayer *, char *, int, char *, _DWORD, _DWORD, _DWORD); // edi
  int v13; // eax
  int v14; // edi
  int v15; // eax
  void (__cdecl *v16)(int, char *, const char *); // ebx
  const char *v17; // eax
  int v18; // [esp+24h] [ebp-144h]
  void (__cdecl *v19)(int, const char *, int); // [esp+28h] [ebp-140h]
  unsigned __int8 v20; // [esp+2Ch] [ebp-13Ch]
  void (__cdecl *v21)(int, const char *, int); // [esp+2Ch] [ebp-13Ch]
  void (__cdecl *v22)(int, char *, const char *); // [esp+2Ch] [ebp-13Ch]
  int v23; // [esp+3Ch] [ebp-12Ch] BYREF
  char v24[263]; // [esp+41h] [ebp-127h] BYREF
  char v25[20]; // [esp+148h] [ebp-20h] BYREF

  v20 = 0;
  v5 = GetUpgradeInfo(a5);
  if ( v5 )
  {
    v6 = (*(*a4 + 1156))(a4, 0);
    if ( v6 )
    {
      if ( (*(*v6 + 1704))(v6, a5) )
      {
        CCSPlayer::EmitPrivateSound(a1, a2, a3, a4, "Player.AwardUpgrade");
        v8 = (*(*gameeventmanager + 28))(gameeventmanager, "receive_upgrade", 0, 0);
        if ( v8 )
        {
          v21 = *(*v8 + 48);
          v18 = v8;
          v9 = (engine->vptr->GetPlayerUserId)(engine, *(a4 + 12));
          v21(v18, "userid", v9);
          v22 = *(*v18 + 60);
          v10 = UpgradeToString(a5);
          v22(v18, "upgrade", v10);
          (*(&off_20 + *gameeventmanager))(gameeventmanager, v18, 0);
        }
        v11 = v5[8];
        v20 = 1;
        if ( v11 )
        {
          v12 = *(*a4 + 1972);
          CFmtStrN<256>::CFmtStrN(&v23, "ItemPickedUp:%s", v11);
          CAI_Concept::CAI_Concept(v25, "PlayerPickup");
          v12(a4, v25, 3, v24, 0, 0, 0);
        }
      }
    }
    else
    {
      v13 = (*(*gameeventmanager + 28))(gameeventmanager, &unk_CC03B9, 0, 0);
      v14 = v13;
      if ( v13 )
      {
        v19 = *(*v13 + 48);
        v15 = (engine->vptr->GetPlayerUserId)(engine, *(a4 + 12));
        v19(v14, "userid", v15);
        v16 = *(*v14 + 60);
        v17 = UpgradeToString(a5);
        v16(v14, "upgrade", v17);
        (*(&off_20 + *gameeventmanager))(gameeventmanager, v14, 0);
      }
    }
  }
  return v20;
}

[Sunyata]

Hi Dragokas,

Thanks for the quick replies. Your pointers were extremely helpful, although the part about the signatures is way over my head.

Thanks for your link to Silvers' thread on the sound hooks. That works perfectly at omitting the sound file for the game.

Here's my script for the sound file location:

#include <sourcemod>
#include <sdktools>

#pragma semicolon 1
#pragma newdecls required

#define PLUGIN_VERSION "1.3"

public Plugin myinfo = 
{
	name = "Remove l4d1 upgrade sound effect",
	author = "Silvers + edit by sunyata",
	description = "Remove l4d1 upgrade sound effect on map start",
	version = PLUGIN_VERSION,
	url = "https://forums.alliedmods.net/showpost.php?p=2798977&postcount=65"
};

public void OnPluginStart()
{
    AddNormalSoundHook(SoundHook);
    AddAmbientSoundHook(AmbientHook);
}

public void OnPluginEnd()
{
    RemoveNormalSoundHook(SoundHook);
    RemoveAmbientSoundHook(AmbientHook);
}

Action SoundHook(int clients[MAXPLAYERS], int &numClients, char sample[PLATFORM_MAX_PATH], int &entity, int &channel, float &volume, int &level, int &pitch, int &flags, char soundEntry[PLATFORM_MAX_PATH], int &seed)
{
    if( strcmp(sample, "player/orch_hit_Csharp_short.wav") == 0 )
    {
        return Plugin_Handled;
    }

    return Plugin_Continue;
}

Action AmbientHook(char sample[PLATFORM_MAX_PATH], int &entity, float &volume, int &level, int &pitch, float pos[3], int &flags, float &delay)
{
    if( strcmp(sample, "player/orch_hit_Csharp_short.wav") == 0 )
    {
        return Plugin_Handled;
    }

    return Plugin_Continue;
}

I'm grateful for your input Dragokas, and also to Silvers for making the generic sound hook script.

Cheers,

Sunyata

[Dragokas]

Sunyata, isn't my plugin blocking this sound as it (it should), or you're using other plugin?
I don't have this sound played using the patch integrated in plugin.

[Sunyata]

I used to have the old version of your plugin, where I was using two perks: the night vision and faster weapon reload speed. However, recently I was trying to find another simple plugin to add a larger 50% weapon mag/clip upgrade to my server. After some enquiries, another coder asked me what perks plugin I was already using. I told him it was yours. He then took a copy of your current script and made a minor amendment to it by adding one line of code to include the larger mag-clip size.

Since this small change got added to the script the upgrade sound effect got re-enabled on my server.


PS: btw, it was the latest version of your plugin being used on my server and not the old version.