[Arkarr]

Hello,

I have several #define right now :

PHP Code:

#define AS_REGISTER_SERVER        0
#define AS_HOOK_CHAT            1
#define AS_UNHOOK_CHAT            2
#define AS_SIMPLE                3
#define AS_TRADEOFFER_SUCCESS    4
#define AS_TRADEOFFER_DECLINED    5
#define AS_SCAN_INVENTORY        6
#define AS_CREATE_TRADEOFFER    7
#define AS_NOT_FRIENDS            8
#define AS_TRADE_TOKEN            9
#define AS_FRIEND_INVITE        10
#define AS_REPORT_PLAYER        11
#define AS_INVITE_GROUP            12
#define AS_SCAN_INVENTORY_IMG   13
#define AS_EXECUTE_CMD            14
#define AS_DISCONNECT            15
#define AS_SG_ANNOUCEMENT        16 


And I will probably have a lot more.

This is my forward :

PHP Code:

/** 
 * Fire when ever you get a message from ASteambot.
 * 
 * @return          Nothing.
 */ 
forward int ASteambot_Message(int MessageType, char[] message, const int messageSize); 


My question is, should I use enum ? Would it be better for my forward so I would have something like this :

PHP Code:

/** 
 * Fire when ever you get a message from ASteambot.
 * 
 * @return          Nothing.
 */ 
forward int ASteambot_Message(MyCustomType MessageType, char[] message, const int messageSize); 


[ThatKidWhoGames]

I think it honestly comes down to preference. Personally, I believe that an enum would be better for this.

[Arkarr]

Originally Posted by ThatKidWhoGames I think it honestly comes down to preference. Personally, I believe that an enum would be better for this.

Okay... Still weird to me why we have enum then.

[hmmmmm]

Honestly I would always choose an enum for this type of situation. Even if you don't want the "custom type" of the enum, you can omit the name and it will basically just become an int.

It also makes your list a little more manageable. For example if for any reason you needed to add a field in the middle you wouldn't have to update the numbers for all the fields that go after that one manually.

Here's what your example would look like as an enum without having to change anything in your forward (can stay as an int instead of MyCustomType):

PHP Code:

enum
{
    AS_RegisterServer = 0,
    AS_HookChat,
    AS_UnhookChat,
    AS_Simple,
    ...
}; 


[Arkarr]

Originally Posted by hmmmmm Honestly I would always choose an enum for this type of situation. Even if you don't want the "custom type" of the enum, you can omit the name and it will basically just become an int. It also makes your list a little more manageable. For example if for any reason you needed to add a field in the middle you wouldn't have to update the numbers for all the fields that go after that one manually. Here's what your example would look like as an enum without having to change anything in your forward (can stay as an int instead of MyCustomType): PHP Code: enum {     AS_RegisterServer = 0,     AS_HookChat,     AS_UnhookChat,     AS_Simple,     ... };

So... just as in a real programming language ? Cool.
That would also work, right ?

PHP Code:

enum MyType
{
    AS_RegisterServer = 0,
    AS_HookChat,
    AS_UnhookChat,
    AS_Simple,
    ...
};

MyType value1 = AS_RegisterServer;
MyType value2 = AS_Simple;

MyType result = value1 + value2;

PrintToServer(">>> %i", result); //Excepted : ">>> 3" 


EDIT: I would have tested it by myself/searched if I could.

[hmmmmm]

Yes, compiles and runs fine in that context. But as soon as you try to assign the enum type to an int type you'll get tag mismatch warnings. If you don't need to assign to ints at all then that should work fine but if you do I suggest removing the enum name so you dont get into the view_as hell.

Also SourcePawn is a real language

[Arkarr]

Originally Posted by hmmmmm Yes, compiles and runs fine in that context. But as soon as you try to assign the enum type to an int type you'll get tag mismatch warnings. If you don't need to assign to ints at all then that should work fine but if you do I suggest removing the enum name so you dont get into the view_as hell. Also SourcePawn is a real language

Alright, thank you !
Yeah, you are right ! I don't know, for a second I thought it was interpreted...

[asherkin]

Originally Posted by hmmmmm Yes, compiles and runs fine in that context. But as soon as you try to assign the enum type to an int type you'll get tag mismatch warnings. If you don't need to assign to ints at all then that should work fine but if you do I suggest removing the enum name so you dont get into the view_as hell.

If the enum values should implicitly convert to int, make the first character of the name lowercase, if they should not, make it uppercase. That is how Pawn controls strict/weak type conversion. See: bool vs Float.