[xbatista]

Hi again,
It's funny, but it seems that only I use sdk hooks
There is a heavy bug with SetTransmit.

PHP Code:

public Action onSetTransmit(int entity, int client) 
{
    return Plugin_Handled;
} 


Try that and you will see magic. Or try to do checks(if) and return handled.
So let the magic begin: you will have view as a spectator, sometimes no, sometimes you will be teleporting while walking and if there is player near that has set transmit too. Or you can stuck in spawn point for few seconds. And the best one I liked, game client crash without errors.
So the logics/idea is that if somehow entity(you) equals client(you), you will get bad day. Some people can mess with this. It can ignore your check logics written in callback, unless you know how it works really.

Fix. Add this at the beginning of setTransmit callback:

PHP Code:

if (entity == client) return Plugin_Continue; 


[Miu]

Seems like intended behavior

[thecount]

Why would you block the transmit of a client to himself? Doesn't sound like a bug, but a logical fallacy.

[xbatista]

I don't block themselves. As I wrote above, it can happen with simple check:

PHP Code:

if ( GetClientTeam(entity) != GetClientTeam(client) && !isGhost[entity]
    && GetClientTeam(client) == CS_TEAM_T && isGhost[client] && shouldCollide[client] && shouldCollide[entity] )
        return Plugin_Handled; 


Here good luck with that. It is still entity == client.

If you don't believe you can do several checks/tests.

So logically I need to add additional check: GetClientTeam(entity) == CS_TEAM_CT, if I want to prevent glitch. That logics in SetTransmit really strangly works. So Fix I wrote above remove all problems.

[friagram]

That's like sending quit in servercommand and wondering why your server is ded

[xbatista]

That's like sending quit in servercommand and wondering why your server is ded

Atleast it prints why is ded...

I'm wondering why this check not inside sdkhooks. Because it's not needed outside. Thats why I was thinking how do my server lags.
I've seen some plugins using SetTransmit without checking if it is not the same player by entity.
So they are like slow motion bomb. Some day it will blow up server without knowing what happened.
And good luck then testing 2000 thousands of code lines which provoked server yelling.

[Dr!fter]

Originally Posted by xbatista Atleast it prints why is ded... I'm wondering why this check not inside sdkhooks. Because it's not needed outside. Thats why I was thinking how do my server lags. I've seen some plugins using SetTransmit without checking if it is not the same player by entity. So they are like slow motion bomb. Some day it will blow up server without knowing what happened. And good luck then testing 2000 thousands of code lines which provoked server yelling.

Because the hook just hooks the function, there is some checks but they are to protect from crashes mostly, you are responsible for the logic.