[edon1337]

I'm making a stock to add up minutes to a given time, but I need a way to copy first 2 characters of a string into another one.

I made this code, but the part where we transfer hours and minutes into individual strings doesn't work.

PHP Code:

AddMinutesToTime( const szTime[ ], const iMinutesToAdd, szReturnTime[ ], const iLen )
{
    new szHour[ 2 ], szMinutes[ 2 ];

    // szTime[ 0 ] = 0
    // szTime[ 1 ] = 1
    // szTime[ 2 ] = :
    // szTime[ 3 ] = 4
    // szTime[ 4 ] = 1
    
    if( szTime[ 0 ] == 0 )
    {
        szHour[ 0 ] = szTime[ 1 ];
    }
    
    else if( szTime[ 0 ] != 0 )
    {
        szHour[ 0 ] = szTime[ 0 ];
        szHour[ 1 ] = szTime[ 1 ];
    }
    
    if( szTime[ 3 ] == 0 )
    {
        szMinutes[ 0 ] = szTime[ 4 ];
    }
    
    else if( szTime[ 3 ] != 0 )
    {
        szMinutes[ 0 ] = szTime[ 3 ];
        szMinutes[ 1 ] = szTime[ 4 ];
    }
    
    new iTimeMinutes = str_to_num( szMinutes );
    new iTimeHour = str_to_num( szHour );

    log_to_file( "Hour.txt", "#1 Minutes: %d | Hours: %d", iTimeMinutes, iTimeHour );
    
    new iFinalHour, iFinalMinutes;
    
    new iToAdd = iTimeMinutes + iMinutesToAdd; // 5:32 + 200
    
    if( iToAdd > 59 ) // 232 > 59
    {
        new iDivide = iToAdd / 60; // 232 / 60 = 3
        
        iFinalHour = iTimeHour + iDivide; // 5 -> 8
        iFinalMinutes = ( iToAdd - ( 60 * iDivide ) ); // 232 - (60*3) == 232-180 = 52
        
        log_to_file( "Hour.txt", "#2 Minutes: %d | Hours: %d", iFinalMinutes, iFinalHour );
    }
    
    formatex( szReturnTime, iLen, "%d:%d", iFinalHour, iFinalMinutes );
} 


L 08/16/2018 - 18:57:10: #1 Minutes: 4 | Hours: 1
L 08/16/2018 - 18:57:10: 0:0

[Ghosted]

You want Time String (03:43) to Hour & Minute Numbers?

[edon1337]

Originally Posted by Ghosted You want Time String (03:43) to Hour & Minute Numbers?

03 to be in szHour string and 43 in szMinutes string, note that we have to get rid of the first zeros.

Ex: 03:09 - > 3:9

[Ghosted]

Originally Posted by edon1337 03 to be in szHour string and 43 in szMinutes string, note that we have to get rid of the first zeros. Ex: 03:09 - > 3:9

new szHours[3], szMinutes[3] // 3rd = string terminator
num_to_str(str_to_num(szTime), szHours, charsmax(szHours));
num_to_str(str_to_num(szTime[2]), szMinutes, charsmax(szMinutes));

[edon1337]

Originally Posted by Ghosted new szHours[3], szMinutes[3] // 3rd = string terminator num_to_str(str_to_num(szTime), szHours, charsmax(szHours)); num_to_str(str_to_num(szTime[2]), szMinutes, charsmax(szMinutes));

Well that logically wasn't supposed to work but I tested to prove myself right.

PHP Code:

#1 Minutes: 0 | Hours: 1 


While it should be

PHP Code:

#1 Minutes: 1 | Hours: 41 


I guess you didn't understand me:

I have szTime[ 5 ]

where szTime[ 0 ] and szTime[ 1 ] should be transferred to szHours while szTime[ 3 ] and szTime[ 4 ] should be transferred to szMinutes

[Ghosted]

Originally Posted by edon1337 Well that logically wasn't supposed to work but I tested to prove myself right. PHP Code: #1 Minutes: 0 | Hours: 1  While it should be PHP Code: #1 Minutes: 1 | Hours: 41  I guess you didn't understand me: I have szTime[ 5 ] where szTime[ 0 ] and szTime[ 1 ] should be transferred to szHours while szTime[ 3 ] and szTime[ 4 ] should be transferred to szMinutes

szTime[2] => szTime[3]

[edon1337]

Originally Posted by Ghosted szTime[2] => szTime[3]

Thank you, worked.

[fysiks]

Note that if you want to store a 2 digit number as a string, you need an array size of 3 (i.e. szHour and szMinutes). I'm not sure how str_to_num() handles invalid strings but maybe it's ok since you say your code is working.

Overall, it looks like you are doing way more work than necessary for both parsing of the incoming string (instead, use strtok()) and for calculating the resulting time (instead, use modulus). See the simplified version below:

public AddMinutesToTime( const szTime[ ], const iMinutesToAdd, szReturnTime[ ], const iLen )
{
	// szTime[0] = '0'
	// szTime[1] = '1'
	// szTime[2] = ':'
	// szTime[3] = '4'
	// szTime[4] = '1'
	// szTime[5] = EOS

	new szHours[3], szMinutes[3], iHours, iMinutes;
	strtok(szTime, szHours, charsmax(szHours), szMinutes, charsmax(szMinutes), ':')  // Parse the string for 'minutes' and 'hours'
	
	iHours = str_to_num( szHours );
	iMinutes = str_to_num( szMinutes );
	
	iMinutes += iMinutesToAdd  // Add the requested minutes
	
	iHours += iMinutes / 60  // Calculate and add the number of hours from iMinutes
	iMinutes = iMinutes % 60  // Remove the hours that was added to iHours from iMinutes
	
	formatex(szReturnTime, iLen, "%d:%d", iHours, iMinutes);
}

[edon1337]

Originally Posted by fysiks Note that if you want to store a 2 digit number as a string, you need an array size of 3 (i.e. szHour and szMinutes). I'm not sure how str_to_num() handles invalid strings but maybe it's ok since you say your code is working. Overall, it looks like you are doing way more work than necessary for both parsing of the incoming string (instead, use strtok()) and for calculating the resulting time (instead, use modulus). See the simplified version below: public AddMinutesToTime( const szTime[ ], const iMinutesToAdd, szReturnTime[ ], const iLen ) { // szTime[0] = '0' // szTime[1] = '1' // szTime[2] = ':' // szTime[3] = '4' // szTime[4] = '1' // szTime[5] = EOS new szHours[3], szMinutes[3], iHours, iMinutes; strtok(szTime, szHours, charsmax(szHours), szMinutes, charsmax(szMinutes), ':') // Parse the string for 'minutes' and 'hours' iHours = str_to_num( szHours ); iMinutes = str_to_num( szMinutes ); iMinutes += iMinutesToAdd // Add the requested minutes iHours += iMinutes / 60 // Calculate and add the number of hours from iMinutes iMinutes = iMinutes % 60 // Remove the hours that was added to iHours from iMinutes formatex(szReturnTime, iLen, "%d:%d", iHours, iMinutes); }

Cool. Unfortunately I don't get how modulus operator works so instead I have to make more calculations.

[klippy]

Instead of saying "I don't get how modulus operator works" you should learn it, it's a basic concept that's taught in elementary school when you are like 11 or so (remember division remainders?). Same goes for your other topic where you reject the answer because you don't understand Unix timestamps. Learn the right way to do things, operations on time/time spans should only be done in Unix timestamps.